Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] [RFC] environment/configure/hardening: add -Werror=implicit.
@ 2021-02-01 15:16 ericonr
  2021-02-01 15:24 ` [PR REVIEW] " sgn
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: ericonr @ 2021-02-01 15:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1814 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages werror
https://github.com/void-linux/void-packages/pull/28389

[RFC] environment/configure/hardening: add -Werror=implicit.
Warnings for implicit function definitions should be errors, since they
can lead to issues down the line when the implicit type rules get things
wrong, especially with variadic functions.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28389.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-werror-28389.patch --]
[-- Type: text/x-diff, Size: 876 bytes --]

From 0d7f06b6cdfef872ef9afbc0b2f628ae086cd077 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 1 Feb 2021 12:14:28 -0300
Subject: [PATCH] environment/configure/hardening: add -Werror=implicit.

Warnings for implicit function definitions should be errors, since they
can lead to issues down the line when the implicit type rules get things
wrong, especially with variadic functions.
---
 common/environment/configure/hardening.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/environment/configure/hardening.sh b/common/environment/configure/hardening.sh
index 9e02364f2a1..5e07eccf030 100644
--- a/common/environment/configure/hardening.sh
+++ b/common/environment/configure/hardening.sh
@@ -28,3 +28,5 @@ else
 	FFLAGS="-fno-PIE ${FFLAGS}"
 	LDFLAGS="-no-pie ${LDFLAGS}"
 fi
+
+CFLAGS="${CFLAGS} -Werror=implicit"

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] [RFC] environment/configure/hardening: add -Werror=implicit.
  2021-02-01 15:16 [PR PATCH] [RFC] environment/configure/hardening: add -Werror=implicit ericonr
@ 2021-02-01 15:24 ` sgn
  2021-02-01 15:30 ` ericonr
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2021-02-01 15:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28389#discussion_r567908478

Comment:
I worry that this may break autotools, specifically, `AC_CHECK_LIBS` or `AC_SEARCH_LIBS`

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] [RFC] environment/configure/hardening: add -Werror=implicit.
  2021-02-01 15:16 [PR PATCH] [RFC] environment/configure/hardening: add -Werror=implicit ericonr
  2021-02-01 15:24 ` [PR REVIEW] " sgn
@ 2021-02-01 15:30 ` ericonr
  2021-02-02 20:14 ` [PR PATCH] [Updated] " ericonr
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-02-01 15:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28389#discussion_r567913486

Comment:
Argh, true. I will test some packages that use it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] [RFC] environment/configure/hardening: add -Werror=implicit.
  2021-02-01 15:16 [PR PATCH] [RFC] environment/configure/hardening: add -Werror=implicit ericonr
  2021-02-01 15:24 ` [PR REVIEW] " sgn
  2021-02-01 15:30 ` ericonr
@ 2021-02-02 20:14 ` ericonr
  2021-03-24  3:55 ` ericonr
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-02-02 20:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages werror
https://github.com/void-linux/void-packages/pull/28389

[RFC] environment/configure/hardening: add -Werror=implicit.
Warnings for implicit function definitions should be errors, since they
can lead to issues down the line when the implicit type rules get things
wrong, especially with variadic functions.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28389.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-werror-28389.patch --]
[-- Type: text/x-diff, Size: 920 bytes --]

From c80e97f74da3d1311f3b921ae7d8eb3010b6e206 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 1 Feb 2021 12:14:28 -0300
Subject: [PATCH] environment/configure/hardening: add
 -Werror=implicit-function-declaration.

Warnings for implicit function declarations should be errors, since they
can lead to issues down the line when the implicit type rules get things
wrong, especially with variadic functions.
---
 common/environment/configure/hardening.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/environment/configure/hardening.sh b/common/environment/configure/hardening.sh
index 9e02364f2a1..025bb153183 100644
--- a/common/environment/configure/hardening.sh
+++ b/common/environment/configure/hardening.sh
@@ -28,3 +28,5 @@ else
 	FFLAGS="-fno-PIE ${FFLAGS}"
 	LDFLAGS="-no-pie ${LDFLAGS}"
 fi
+
+CFLAGS="${CFLAGS} -Werror=implicit-function-declaration"

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC] environment/configure/hardening: add -Werror=implicit.
  2021-02-01 15:16 [PR PATCH] [RFC] environment/configure/hardening: add -Werror=implicit ericonr
                   ` (2 preceding siblings ...)
  2021-02-02 20:14 ` [PR PATCH] [Updated] " ericonr
@ 2021-03-24  3:55 ` ericonr
  2021-03-24 23:52 ` sgn
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-03-24  3:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28389#issuecomment-805467452

Comment:
I'm strongly considering adding this for build styles other than `gnu-configure`.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC] environment/configure/hardening: add -Werror=implicit.
  2021-02-01 15:16 [PR PATCH] [RFC] environment/configure/hardening: add -Werror=implicit ericonr
                   ` (3 preceding siblings ...)
  2021-03-24  3:55 ` ericonr
@ 2021-03-24 23:52 ` sgn
  2021-03-25  0:03 ` ericonr
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2021-03-24 23:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28389#issuecomment-806256866

Comment:
> I'm strongly considering adding this for build styles other than `gnu-configure`.

Doesn't above change affect all packages?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC] environment/configure/hardening: add -Werror=implicit.
  2021-02-01 15:16 [PR PATCH] [RFC] environment/configure/hardening: add -Werror=implicit ericonr
                   ` (4 preceding siblings ...)
  2021-03-24 23:52 ` sgn
@ 2021-03-25  0:03 ` ericonr
  2021-06-10 16:44 ` [PR PATCH] [Updated] " ericonr
  2021-06-10 17:20 ` ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-03-25  0:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28389#issuecomment-806260955

Comment:
Yes, the PR would have to be changed a lot.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] [RFC] environment/configure/hardening: add -Werror=implicit.
  2021-02-01 15:16 [PR PATCH] [RFC] environment/configure/hardening: add -Werror=implicit ericonr
                   ` (5 preceding siblings ...)
  2021-03-25  0:03 ` ericonr
@ 2021-06-10 16:44 ` ericonr
  2021-06-10 17:20 ` ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-06-10 16:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages werror
https://github.com/void-linux/void-packages/pull/28389

[RFC] environment/configure/hardening: add -Werror=implicit.
Warnings for implicit function definitions should be errors, since they
can lead to issues down the line when the implicit type rules get things
wrong, especially with variadic functions.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28389.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-werror-28389.patch --]
[-- Type: text/x-diff, Size: 1893 bytes --]

From ca38f428898ca145e30aef8046b51ba535362844 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 1 Feb 2021 12:14:28 -0300
Subject: [PATCH 1/2] environment/hardening: add
 -Werror=implicit-function-declaration.

Warnings for implicit function declarations should be errors, since they
can lead to issues down the line when the implicit type rules get things
wrong, especially with variadic functions.
---
 common/environment/configure/hardening.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/environment/configure/hardening.sh b/common/environment/configure/hardening.sh
index 9e02364f2a1d..c2c4bf5a3598 100644
--- a/common/environment/configure/hardening.sh
+++ b/common/environment/configure/hardening.sh
@@ -28,3 +28,5 @@ else
 	FFLAGS="-fno-PIE ${FFLAGS}"
 	LDFLAGS="-no-pie ${LDFLAGS}"
 fi
+
+CFLAGS+=" -Werror=implicit-function-declaration"

From ddf8b6a8bf97bea3fcdaccfafdeedf4456908e67 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Thu, 10 Jun 2021 13:42:50 -0300
Subject: [PATCH 2/2] build-style/gnu-configure: remove Werror from implicit
 declarations.

Many configure scripts depend on -Werror=implicit-function-declaration
to work correctly, so we can't set it for gnu-configure builds.
---
 common/build-style/gnu-configure.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/build-style/gnu-configure.sh b/common/build-style/gnu-configure.sh
index 8121136cd121..6f7f044fcce1 100644
--- a/common/build-style/gnu-configure.sh
+++ b/common/build-style/gnu-configure.sh
@@ -4,6 +4,8 @@
 do_configure() {
 	: ${configure_script:=./configure}
 
+	export CFLAGS="${CFLAGS/-Werror=implicit-function-declaration/}"
+	echo $CFLAGS
 	export lt_cv_sys_lib_dlsearch_path_spec="/usr/lib64 /usr/lib32 /usr/lib /lib /usr/local/lib"
 	${configure_script} ${configure_args}
 }

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC] environment/configure/hardening: add -Werror=implicit.
  2021-02-01 15:16 [PR PATCH] [RFC] environment/configure/hardening: add -Werror=implicit ericonr
                   ` (6 preceding siblings ...)
  2021-06-10 16:44 ` [PR PATCH] [Updated] " ericonr
@ 2021-06-10 17:20 ` ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-06-10 17:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28389#issuecomment-858807686

Comment:
I think the patching done in at least `ucspi-tcp` means we have a huge amount of errors caused by this PR. So it can't be merged as is because it will break the build of already broken packages.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-06-10 17:20 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 15:16 [PR PATCH] [RFC] environment/configure/hardening: add -Werror=implicit ericonr
2021-02-01 15:24 ` [PR REVIEW] " sgn
2021-02-01 15:30 ` ericonr
2021-02-02 20:14 ` [PR PATCH] [Updated] " ericonr
2021-03-24  3:55 ` ericonr
2021-03-24 23:52 ` sgn
2021-03-25  0:03 ` ericonr
2021-06-10 16:44 ` [PR PATCH] [Updated] " ericonr
2021-06-10 17:20 ` ericonr

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git