[PR PATCH] Samba

[ahesford <ahesford@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]

There is a new pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages samba
https://github.com/void-linux/void-packages/pull/28527

Samba
Relatively minor update, but I'd appreciate a bit of testing, especially from @Anachron and @wangp who had some issues on `armv7l` or `aarch64`.

There is a caveat: I tried building this update while running the `smbd` and `nmbd` services from the current `samba-4.13.3_1` package. The resulting 4.13.4_1 package produced a broken `smbd` which died on startup with the error
```
svcctl_init_winreg: Could not open SYSTEM\CurrentControlSet\Services - NT_STATUS_INVALID_HANDLE
regdb_close: decrementing refcount (1->0)
dcesrv_init_ep_server: Failed to init endpoint server 'svcctl': NT_STATUS_UNSUCCESSFUL
dcesrv_init: Failed to init DCE/RPC endpoint servers: NT_STATUS_UNSUCCESSFUL
main: Failed to setup RPC server: NT_STATUS_UNSUCCESSFUL
exit_daemon: daemon failed to start: Samba cannot setup ep pipe, error code 13
```
Code 13 looks like `EACCES`, but this is a [hard-coded number](https://gitlab.com/samba-team/samba/-/blob/master/source3/smbd/server.c#L2104) that is independent of the actual reason for failure.

After removing `samba`, `smbclient` and `samba-libs` (which also required removing `cifs-utils` and `vlc` on my system) and rebuilding the package, `smbd` worked as expected. I tried a third rebuild with `samba`, `smbclient` and `samba-libs` installed but the services not active. This also seemed to produce a working package.

It seems that the build process allows the host configuration to leak through some how, and when the old services are running, something causes `smbd` to break. If you have similar troubles, I recommend first stopping any `nmbd` and `smbd` and rebuilding; if that still fails, try removing `samba-libs` and any dependants.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me



A patch file from https://github.com/void-linux/void-packages/pull/28527.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-samba-28527.patch --]
[-- Type: text/x-diff, Size: 2132 bytes --]

From 55163c9dca25700a75f516497f765a41117e6b0e Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Fri, 5 Feb 2021 10:02:15 -0500
Subject: [PATCH 1/2] talloc: update to 2.3.2.

---
 srcpkgs/talloc/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/talloc/template b/srcpkgs/talloc/template
index 50f629f3db7..8ad2baf8937 100644
--- a/srcpkgs/talloc/template
+++ b/srcpkgs/talloc/template
@@ -1,7 +1,7 @@
 # Template file for 'talloc'
 pkgname=talloc
-version=2.3.1
-revision=2
+version=2.3.2
+revision=1
 build_style=waf3
 build_helper="qemu"
 configure_script="buildtools/bin/waf"
@@ -15,7 +15,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://talloc.samba.org/"
 distfiles="http://samba.org/ftp/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=ef4822d2fdafd2be8e0cabc3ec3c806ae29b8268e932c5e9a4cd5585f37f9f77
+checksum=27a03ef99e384d779124df755deb229cd1761f945eca6d200e8cfd9bf5297bd7
 
 export PYTHON_CONFIG="${XBPS_CROSS_BASE}/usr/bin/python3-config"
 

From 0579fcd3de5ccfd7f4c33cf83ac35a5da822cea2 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Fri, 5 Feb 2021 11:17:42 -0500
Subject: [PATCH 2/2] samba: update to 4.13.4.

---
 srcpkgs/samba/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/samba/template b/srcpkgs/samba/template
index cb5eaf45376..90be22e5705 100644
--- a/srcpkgs/samba/template
+++ b/srcpkgs/samba/template
@@ -1,6 +1,6 @@
 # Template file for 'samba'
 pkgname=samba
-version=4.13.3
+version=4.13.4
 revision=1
 build_style=waf3
 build_helper="qemu"
@@ -27,7 +27,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="http://www.samba.org"
 distfiles="http://download.samba.org/pub/samba/stable/${pkgname}-${version}.tar.gz"
-checksum=c10585d43f33656fe4e1f9ff8bf40ea57d8d5b653521c1cc198fbf4922756541
+checksum=a1b34c63f7100cc8626902d80f335c7cb0b45d4707dd3c4b010f7a28ed615c78
 lib32disabled=yes
 conf_files="/etc/pam.d/samba /etc/samba/smb.conf"
 make_dirs="/etc/samba/private 0750 root root"