Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] libtool: revbump for the gcc update.
@ 2021-02-08  3:14 ericonr
  2021-02-08  3:15 ` ericonr
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: ericonr @ 2021-02-08  3:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2223 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages lib
https://github.com/void-linux/void-packages/pull/28577

libtool: revbump for the gcc update.
libtool hardcodes some internal gcc paths, which include the GCC version
information. Some applications can fail to build if these paths are
used. Revbumping libtool is enough for the recorded paths to be updated.

A proper solution is importing the fixes Debian applies:
https://salsa.debian.org/metux-guest/libtool/-/blob/ef64614b54a8da38fc4b4424639251fde9d135bf/debian/rules#L115

This is ugly as hell, but I don't want to do the work to import the debian workaround properly right now. But maybe I should :P 

Noticed when building https://sourceforge.net/projects/srecord/files/srecord/1.64/ , reported via IRC.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28577.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lib-28577.patch --]
[-- Type: text/x-diff, Size: 1057 bytes --]

From bd587c453cfa3d44a45de9df71a2e6da8545c4a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 8 Feb 2021 00:09:45 -0300
Subject: [PATCH] libtool: revbump for the gcc update.

libtool hardcodes some internal gcc paths, which include the GCC version
information. Some applications can fail to build if these paths are
used. Revbumping libtool is enough for the recorded paths to be updated.

A proper solution is importing the fixes Debian applies:
https://salsa.debian.org/metux-guest/libtool/-/blob/ef64614b54a8da38fc4b4424639251fde9d135bf/debian/rules#L115
---
 srcpkgs/libtool/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/libtool/template b/srcpkgs/libtool/template
index 1cdc2649b96..d8533aac5b6 100644
--- a/srcpkgs/libtool/template
+++ b/srcpkgs/libtool/template
@@ -1,7 +1,7 @@
 # Template file for 'libtool'
 pkgname=libtool
 version=2.4.6
-revision=4
+revision=5
 build_style=gnu-configure
 hostmakedepends="texinfo perl automake help2man xz"
 depends="tar sed"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: libtool: revbump for the gcc update.
  2021-02-08  3:14 [PR PATCH] libtool: revbump for the gcc update ericonr
@ 2021-02-08  3:15 ` ericonr
  2021-02-10  0:45 ` ericonr
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-02-08  3:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28577#issuecomment-774837467

Comment:
If we go this way, the gcc template should include a comment about revbumping libtool

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: libtool: revbump for the gcc update.
  2021-02-08  3:14 [PR PATCH] libtool: revbump for the gcc update ericonr
  2021-02-08  3:15 ` ericonr
@ 2021-02-10  0:45 ` ericonr
  2021-02-10  0:48 ` [PR PATCH] [Updated] " ericonr
  2021-02-10  0:48 ` [PR PATCH] [Merged]: " ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-02-10  0:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28577#issuecomment-776348807

Comment:
We can postpone the decision to import the patch to later.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] libtool: revbump for the gcc update.
  2021-02-08  3:14 [PR PATCH] libtool: revbump for the gcc update ericonr
  2021-02-08  3:15 ` ericonr
  2021-02-10  0:45 ` ericonr
@ 2021-02-10  0:48 ` ericonr
  2021-02-10  0:48 ` [PR PATCH] [Merged]: " ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-02-10  0:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2228 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages lib
https://github.com/void-linux/void-packages/pull/28577

libtool: revbump for the gcc update.
libtool hardcodes some internal gcc paths, which include the GCC version
information. Some applications can fail to build if these paths are
used. Revbumping libtool is enough for the recorded paths to be updated.

A proper solution is importing the fixes Debian applies:
https://salsa.debian.org/metux-guest/libtool/-/blob/ef64614b54a8da38fc4b4424639251fde9d135bf/debian/rules#L115

This is ugly as hell, but I don't want to do the work to import the debian workaround properly right now. But maybe I should :P 

Noticed when building https://sourceforge.net/projects/srecord/files/srecord/1.64/ , reported via IRC.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28577.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lib-28577.patch --]
[-- Type: text/x-diff, Size: 1526 bytes --]

From 5bf87b99c2a88787d145cb75d8a4b2d3ae21fdd9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 8 Feb 2021 00:09:45 -0300
Subject: [PATCH] libtool: revbump for the gcc update.

libtool hardcodes some internal gcc paths, which include the GCC version
information. Some applications can fail to build if these paths are
used. Revbumping libtool is enough for the recorded paths to be updated.

A proper solution is importing the fixes Debian applies:
https://salsa.debian.org/metux-guest/libtool/-/blob/ef64614b54a8da38fc4b4424639251fde9d135bf/debian/rules#L115

Also add comment to gcc template about the requirement.
---
 srcpkgs/gcc/template     | 2 ++
 srcpkgs/libtool/template | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gcc/template b/srcpkgs/gcc/template
index 5417d8d87bb..c838403941c 100644
--- a/srcpkgs/gcc/template
+++ b/srcpkgs/gcc/template
@@ -1,4 +1,6 @@
 # Template file for 'gcc'
+# Revbump libtool when updating gcc, since it hardcodes some internal compiler paths
+# which use the version number.
 _majorver=10
 _minorver=${_majorver}.2
 _patchver=${_minorver}.1
diff --git a/srcpkgs/libtool/template b/srcpkgs/libtool/template
index 1cdc2649b96..d8533aac5b6 100644
--- a/srcpkgs/libtool/template
+++ b/srcpkgs/libtool/template
@@ -1,7 +1,7 @@
 # Template file for 'libtool'
 pkgname=libtool
 version=2.4.6
-revision=4
+revision=5
 build_style=gnu-configure
 hostmakedepends="texinfo perl automake help2man xz"
 depends="tar sed"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: libtool: revbump for the gcc update.
  2021-02-08  3:14 [PR PATCH] libtool: revbump for the gcc update ericonr
                   ` (2 preceding siblings ...)
  2021-02-10  0:48 ` [PR PATCH] [Updated] " ericonr
@ 2021-02-10  0:48 ` ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-02-10  0:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2076 bytes --]

There's a merged pull request on the void-packages repository

libtool: revbump for the gcc update.
https://github.com/void-linux/void-packages/pull/28577

Description:
libtool hardcodes some internal gcc paths, which include the GCC version
information. Some applications can fail to build if these paths are
used. Revbumping libtool is enough for the recorded paths to be updated.

A proper solution is importing the fixes Debian applies:
https://salsa.debian.org/metux-guest/libtool/-/blob/ef64614b54a8da38fc4b4424639251fde9d135bf/debian/rules#L115

This is ugly as hell, but I don't want to do the work to import the debian workaround properly right now. But maybe I should :P 

Noticed when building https://sourceforge.net/projects/srecord/files/srecord/1.64/ , reported via IRC.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-02-10  0:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08  3:14 [PR PATCH] libtool: revbump for the gcc update ericonr
2021-02-08  3:15 ` ericonr
2021-02-10  0:45 ` ericonr
2021-02-10  0:48 ` [PR PATCH] [Updated] " ericonr
2021-02-10  0:48 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).