Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] nvimpager: update to 0.9
@ 2021-02-09  4:57 adrianisuru
  2021-02-09 19:10 ` [PR REVIEW] " ericonr
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: adrianisuru @ 2021-02-09  4:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

There is a new pull request by adrianisuru against master on the void-packages repository

https://github.com/adrianisuru/void-packages master
https://github.com/void-linux/void-packages/pull/28603

nvimpager: update to 0.9
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28603.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28603.patch --]
[-- Type: text/x-diff, Size: 1785 bytes --]

From da850d44d76f84d0633459f701d85c5daeb1bb58 Mon Sep 17 00:00:00 2001
From: Adrian Herath <adrianisuru@gmail.com>
Date: Mon, 8 Feb 2021 22:44:05 -0600
Subject: [PATCH] nvimpager: update to 0.9

---
 srcpkgs/nvimpager/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/nvimpager/template b/srcpkgs/nvimpager/template
index 5f3050e84a9..0487343c56f 100644
--- a/srcpkgs/nvimpager/template
+++ b/srcpkgs/nvimpager/template
@@ -1,7 +1,7 @@
 # Template file for 'nvimpager'
 pkgname=nvimpager
-version=0.7
-revision=2
+version=0.9
+revision=3
 # In pre_build, date is the date of the last commit in the nvimpager repo.
 # It should be changed when updating to a new version.
 create_wrksrc=true
@@ -10,15 +10,14 @@ build_style=gnu-makefile
 make_build_target="nvimpager.configured"
 make_build_args="PREFIX=/usr"
 hostmakedepends="neovim $(vopt_if man pandoc)"
-depends="neovim>=0.3.0 bash"
+depends="neovim>=0.4.0 bash"
 short_desc="Wrapper to use neovim as a pager to view manpages, diffs, etc"
 maintainer="Adrian Herath <adrianisuru@gmail.com>"
 license="BSD-2-Clause"
 homepage="https://github.com/lucc/nvimpager"
 distfiles="${homepage}/archive/v${version}.tar.gz
  https://www.vim.org/scripts/download_script.php?src_id=14498>AnsiEsc.vba.gz"
-checksum="cb4eee0ef2569412b0528eacd7efd6af960bebc11d8749258d8ba83c975ebf4b
- a80d8c95a2e497e190831f1b580205653c595c6f51b48d4cb89fb33eaea5ed03"
+checksum="ae2d99d59bd43d96e12a07ffa32c3f120636163308c2b6c1da43052bc8bce1a0 a80d8c95a2e497e190831f1b580205653c595c6f51b48d4cb89fb33eaea5ed03"
 
 build_options="man"
 desc_option_man="Use pandoc for manpages"
@@ -31,7 +30,7 @@ pre_build() {
 	cat <<< \
 "---
 footer: Version v${version}
-date: 2020-09-25
+date: 2020-12-13
 ..." \
 	> metadata.yml
 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] nvimpager: update to 0.9
  2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
@ 2021-02-09 19:10 ` ericonr
  2021-02-09 19:11 ` ericonr
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-09 19:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28603#discussion_r573158855

Comment:
You need to set `revision=1` when updating a package.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] nvimpager: update to 0.9
  2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
  2021-02-09 19:10 ` [PR REVIEW] " ericonr
  2021-02-09 19:11 ` ericonr
@ 2021-02-09 19:11 ` ericonr
  2021-02-09 21:21 ` [PR PATCH] [Updated] " adrianisuru
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-09 19:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28603#discussion_r573159400

Comment:
Should we update this at some point?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] nvimpager: update to 0.9
  2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
  2021-02-09 19:10 ` [PR REVIEW] " ericonr
@ 2021-02-09 19:11 ` ericonr
  2021-02-09 19:11 ` ericonr
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-09 19:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28603#discussion_r573159189

Comment:
```suggestion
checksum="ae2d99d59bd43d96e12a07ffa32c3f120636163308c2b6c1da43052bc8bce1a0
 a80d8c95a2e497e190831f1b580205653c595c6f51b48d4cb89fb33eaea5ed03"
```

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] nvimpager: update to 0.9
  2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
                   ` (2 preceding siblings ...)
  2021-02-09 19:11 ` ericonr
@ 2021-02-09 21:21 ` adrianisuru
  2021-02-09 21:27 ` [PR REVIEW] " adrianisuru
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: adrianisuru @ 2021-02-09 21:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

There is an updated pull request by adrianisuru against master on the void-packages repository

https://github.com/adrianisuru/void-packages master
https://github.com/void-linux/void-packages/pull/28603

nvimpager: update to 0.9
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28603.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28603.patch --]
[-- Type: text/x-diff, Size: 1785 bytes --]

From cc9b41865d26acb0cfe5cd002947b61c9b53c5ef Mon Sep 17 00:00:00 2001
From: Adrian Herath <adrianisuru@gmail.com>
Date: Mon, 8 Feb 2021 22:44:05 -0600
Subject: [PATCH] nvimpager: update to 0.9

---
 srcpkgs/nvimpager/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/nvimpager/template b/srcpkgs/nvimpager/template
index 5f3050e84a9..d48a667acdf 100644
--- a/srcpkgs/nvimpager/template
+++ b/srcpkgs/nvimpager/template
@@ -1,7 +1,7 @@
 # Template file for 'nvimpager'
 pkgname=nvimpager
-version=0.7
-revision=2
+version=0.9
+revision=1
 # In pre_build, date is the date of the last commit in the nvimpager repo.
 # It should be changed when updating to a new version.
 create_wrksrc=true
@@ -10,15 +10,14 @@ build_style=gnu-makefile
 make_build_target="nvimpager.configured"
 make_build_args="PREFIX=/usr"
 hostmakedepends="neovim $(vopt_if man pandoc)"
-depends="neovim>=0.3.0 bash"
+depends="neovim>=0.4.0 bash"
 short_desc="Wrapper to use neovim as a pager to view manpages, diffs, etc"
 maintainer="Adrian Herath <adrianisuru@gmail.com>"
 license="BSD-2-Clause"
 homepage="https://github.com/lucc/nvimpager"
 distfiles="${homepage}/archive/v${version}.tar.gz
  https://www.vim.org/scripts/download_script.php?src_id=14498>AnsiEsc.vba.gz"
-checksum="cb4eee0ef2569412b0528eacd7efd6af960bebc11d8749258d8ba83c975ebf4b
- a80d8c95a2e497e190831f1b580205653c595c6f51b48d4cb89fb33eaea5ed03"
+checksum="ae2d99d59bd43d96e12a07ffa32c3f120636163308c2b6c1da43052bc8bce1a0 a80d8c95a2e497e190831f1b580205653c595c6f51b48d4cb89fb33eaea5ed03"
 
 build_options="man"
 desc_option_man="Use pandoc for manpages"
@@ -31,7 +30,7 @@ pre_build() {
 	cat <<< \
 "---
 footer: Version v${version}
-date: 2020-09-25
+date: 2020-12-13
 ..." \
 	> metadata.yml
 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] nvimpager: update to 0.9
  2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
                   ` (3 preceding siblings ...)
  2021-02-09 21:21 ` [PR PATCH] [Updated] " adrianisuru
@ 2021-02-09 21:27 ` adrianisuru
  2021-02-09 21:34 ` ericonr
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: adrianisuru @ 2021-02-09 21:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New review comment by adrianisuru on void-packages repository

https://github.com/void-linux/void-packages/pull/28603#discussion_r573253499

Comment:
Which "this" are you talking about? The depends? Sorry I'm not clear on what you are asking.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] nvimpager: update to 0.9
  2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
                   ` (4 preceding siblings ...)
  2021-02-09 21:27 ` [PR REVIEW] " adrianisuru
@ 2021-02-09 21:34 ` ericonr
  2021-02-10  0:30 ` ericonr
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-09 21:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28603#discussion_r573257524

Comment:
Sorry, I meant `src_id=14498` in the link.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] nvimpager: update to 0.9
  2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
                   ` (5 preceding siblings ...)
  2021-02-09 21:34 ` ericonr
@ 2021-02-10  0:30 ` ericonr
  2021-02-10  0:31 ` ericonr
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-10  0:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28603#discussion_r573352609

Comment:
This still needs to be fixed.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] nvimpager: update to 0.9
  2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
                   ` (6 preceding siblings ...)
  2021-02-10  0:30 ` ericonr
@ 2021-02-10  0:31 ` ericonr
  2021-02-10  0:43 ` ericonr
  2021-02-11  3:50 ` [PR PATCH] [Closed]: " ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-10  0:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28603#discussion_r573353636

Comment:
So, given https://github.com/lucc/nvimpager/blob/develop/makefile , I don't see this file being used anymore? Maybe we should remove from package.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] nvimpager: update to 0.9
  2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
                   ` (7 preceding siblings ...)
  2021-02-10  0:31 ` ericonr
@ 2021-02-10  0:43 ` ericonr
  2021-02-11  3:50 ` [PR PATCH] [Closed]: " ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-10  0:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28603#discussion_r573359220

Comment:
We should definitely remove, they no longer use it.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Closed]: nvimpager: update to 0.9
  2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
                   ` (8 preceding siblings ...)
  2021-02-10  0:43 ` ericonr
@ 2021-02-11  3:50 ` ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-11  3:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

There's a closed pull request on the void-packages repository

nvimpager: update to 0.9
https://github.com/void-linux/void-packages/pull/28603

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-02-11  3:50 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09  4:57 [PR PATCH] nvimpager: update to 0.9 adrianisuru
2021-02-09 19:10 ` [PR REVIEW] " ericonr
2021-02-09 19:11 ` ericonr
2021-02-09 19:11 ` ericonr
2021-02-09 21:21 ` [PR PATCH] [Updated] " adrianisuru
2021-02-09 21:27 ` [PR REVIEW] " adrianisuru
2021-02-09 21:34 ` ericonr
2021-02-10  0:30 ` ericonr
2021-02-10  0:31 ` ericonr
2021-02-10  0:43 ` ericonr
2021-02-11  3:50 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).