Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] rclone: fix builtin version string
@ 2021-02-10 17:21 4ricci
  2021-02-10 17:23 ` [PR REVIEW] " ericonr
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: 4ricci @ 2021-02-10 17:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

There is a new pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages rclone
https://github.com/void-linux/void-packages/pull/28633

rclone: fix builtin version string
Also:
- enable tests
- use official site for distfiles and changelog

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rclone-28633.patch --]
[-- Type: text/x-diff, Size: 1547 bytes --]

From 943270e43919319a50ac0accbfcb7a446fc7bb6d Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 9 Feb 2021 21:59:03 +0100
Subject: [PATCH] rclone: fix builtin version string

Also:
- enable tests
- use official site for distfiles and changelog
---
 srcpkgs/rclone/template | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/rclone/template b/srcpkgs/rclone/template
index 93295ccbd5c..637541fcb2d 100644
--- a/srcpkgs/rclone/template
+++ b/srcpkgs/rclone/template
@@ -1,17 +1,17 @@
 # Template file for 'rclone'
 pkgname=rclone
 version=1.54.0
-revision=1
+revision=2
 wrksrc="rclone-v${version}"
 build_style=go
 go_import_path=github.com/rclone/rclone
-go_ldflags="-extldflags=-fuse-ld=bfd"
+go_ldflags="-extldflags=-fuse-ld=bfd -X github.com/rclone/rclone/fs.Version=v${version}"
 short_desc="Rsync for cloud storage"
 maintainer="Diogo Leal <diogo@diogoleal.com>"
 license="MIT"
 homepage="https://rclone.org/"
-changelog="https://raw.githubusercontent.com/rclone/rclone/master/docs/content/changelog.md"
-distfiles="https://github.com/rclone/rclone/releases/download/v${version}/rclone-v${version}.tar.gz"
+changelog="https://rclone.org/changelog/"
+distfiles="https://downloads.rclone.org/v${version}/rclone-v${version}.tar.gz"
 checksum=95f952dc059b842bd40338458b77657f7b5a1680c4ca837a3adcf83b63c8fda1
 
 pre_build() {
@@ -23,6 +23,10 @@ pre_build() {
 	fi
 }
 
+do_check() {
+	RCLONE_CONFIG="/notfound" go test ./...
+}
+
 post_install() {
 	vlicense COPYING
 	vman rclone.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] rclone: fix builtin version string
  2021-02-10 17:21 [PR PATCH] rclone: fix builtin version string 4ricci
@ 2021-02-10 17:23 ` ericonr
  2021-02-10 17:27 ` [PR PATCH] [Updated] " 4ricci
  2021-02-10 18:04 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-02-10 17:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28633#discussion_r573924097

Comment:
I think we should keep this one... I believe the general preference is for raw text changelogs, when available.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] rclone: fix builtin version string
  2021-02-10 17:21 [PR PATCH] rclone: fix builtin version string 4ricci
  2021-02-10 17:23 ` [PR REVIEW] " ericonr
@ 2021-02-10 17:27 ` 4ricci
  2021-02-10 18:04 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: 4ricci @ 2021-02-10 17:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]

There is an updated pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages rclone
https://github.com/void-linux/void-packages/pull/28633

rclone: fix builtin version string
Also:
- enable tests
- use official site for distfiles and changelog

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rclone-28633.patch --]
[-- Type: text/x-diff, Size: 1488 bytes --]

From f5f7d72b364b39f1d6771eeac868adafe3c1a7b5 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 9 Feb 2021 21:59:03 +0100
Subject: [PATCH] rclone: fix builtin version string

Also:
- enable tests
- use official site for distfiles
---
 srcpkgs/rclone/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/rclone/template b/srcpkgs/rclone/template
index 93295ccbd5c..3c793deb6d1 100644
--- a/srcpkgs/rclone/template
+++ b/srcpkgs/rclone/template
@@ -1,17 +1,17 @@
 # Template file for 'rclone'
 pkgname=rclone
 version=1.54.0
-revision=1
+revision=2
 wrksrc="rclone-v${version}"
 build_style=go
 go_import_path=github.com/rclone/rclone
-go_ldflags="-extldflags=-fuse-ld=bfd"
+go_ldflags="-extldflags=-fuse-ld=bfd -X github.com/rclone/rclone/fs.Version=v${version}"
 short_desc="Rsync for cloud storage"
 maintainer="Diogo Leal <diogo@diogoleal.com>"
 license="MIT"
 homepage="https://rclone.org/"
 changelog="https://raw.githubusercontent.com/rclone/rclone/master/docs/content/changelog.md"
-distfiles="https://github.com/rclone/rclone/releases/download/v${version}/rclone-v${version}.tar.gz"
+distfiles="https://downloads.rclone.org/v${version}/rclone-v${version}.tar.gz"
 checksum=95f952dc059b842bd40338458b77657f7b5a1680c4ca837a3adcf83b63c8fda1
 
 pre_build() {
@@ -23,6 +23,10 @@ pre_build() {
 	fi
 }
 
+do_check() {
+	RCLONE_CONFIG="/notfound" go test ./...
+}
+
 post_install() {
 	vlicense COPYING
 	vman rclone.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: rclone: fix builtin version string
  2021-02-10 17:21 [PR PATCH] rclone: fix builtin version string 4ricci
  2021-02-10 17:23 ` [PR REVIEW] " ericonr
  2021-02-10 17:27 ` [PR PATCH] [Updated] " 4ricci
@ 2021-02-10 18:04 ` ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-02-10 18:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

There's a merged pull request on the void-packages repository

rclone: fix builtin version string
https://github.com/void-linux/void-packages/pull/28633

Description:
Also:
- enable tests
- use official site for distfiles and changelog

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-10 18:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 17:21 [PR PATCH] rclone: fix builtin version string 4ricci
2021-02-10 17:23 ` [PR REVIEW] " ericonr
2021-02-10 17:27 ` [PR PATCH] [Updated] " 4ricci
2021-02-10 18:04 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).