* [PR PATCH] vsed: stop collapsing whitespace
@ 2021-02-17 11:26 sgn
2021-02-21 1:33 ` [PR PATCH] [Merged]: " sgn
0 siblings, 1 reply; 2+ messages in thread
From: sgn @ 2021-02-17 11:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]
There is a new pull request by sgn against master on the void-packages repository
https://github.com/sgn/void-packages fix-vsed-eat-whitespace
https://github.com/void-linux/void-packages/pull/28814
vsed: stop collapsing whitespace
MCVE:
printf '%s %s\n' a b >afile
vsed -i -e '/a b/d' afile
Expect:
- afile should be empty
Actual:
- afile is not empty
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28814.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-vsed-eat-whitespace-28814.patch --]
[-- Type: text/x-diff, Size: 917 bytes --]
From 86f7321ff4729ee1970082e26a13763f8fe23734 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Wed, 17 Feb 2021 18:22:49 +0700
Subject: [PATCH] vsed: stop collapsing whitespace
MCVE:
printf '%s %s\n' a b >afile
vsed -i -e '/a b/d' afile
Expect:
- afile should be empty
Actual:
- afile is not empty
---
common/environment/setup/vsed.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/environment/setup/vsed.sh b/common/environment/setup/vsed.sh
index 092253696cd..5b5bf427c23 100644
--- a/common/environment/setup/vsed.sh
+++ b/common/environment/setup/vsed.sh
@@ -8,7 +8,7 @@
vsed() {
local files=() regexes=() OPTIND OPTSTRING="ie:" has_inline=
- eval set -- $(getopt -s bash "$OPTSTRING" "$@");
+ eval set -- "$(getopt -s bash "$OPTSTRING" "$@")";
while getopts "$OPTSTRING" opt; do
case $opt in
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PR PATCH] [Merged]: vsed: stop collapsing whitespace
2021-02-17 11:26 [PR PATCH] vsed: stop collapsing whitespace sgn
@ 2021-02-21 1:33 ` sgn
0 siblings, 0 replies; 2+ messages in thread
From: sgn @ 2021-02-21 1:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]
There's a merged pull request on the void-packages repository
vsed: stop collapsing whitespace
https://github.com/void-linux/void-packages/pull/28814
Description:
MCVE:
printf '%s %s\n' a b >afile
vsed -i -e '/a b/d' afile
Expect:
- afile should be empty
Actual:
- afile is not empty
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-21 1:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-17 11:26 [PR PATCH] vsed: stop collapsing whitespace sgn
2021-02-21 1:33 ` [PR PATCH] [Merged]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).