Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] wayfire: enable optimized binary
@ 2021-02-19  5:23 travankor
  2021-02-19  5:24 ` [PR PATCH] [Updated] " travankor
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: travankor @ 2021-02-19  5:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

There is a new pull request by travankor against master on the void-packages repository

https://github.com/travankor/void-packages wayfire
https://github.com/void-linux/void-packages/pull/28880

wayfire: enable optimized binary
None

A patch file from https://github.com/void-linux/void-packages/pull/28880.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wayfire-28880.patch --]
[-- Type: text/x-diff, Size: 901 bytes --]

From 8b2c13cb99eea54c1eda52f20eb205f03fbc31a7 Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Thu, 18 Feb 2021 22:22:31 -0700
Subject: [PATCH] wayfire: enable optimized binary

---
 srcpkgs/wayfire/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wayfire/template b/srcpkgs/wayfire/template
index fb3b85aef2c..d14e1ce7205 100644
--- a/srcpkgs/wayfire/template
+++ b/srcpkgs/wayfire/template
@@ -1,10 +1,11 @@
 # Template file for 'wayfire'
 pkgname=wayfire
 version=0.7.0
-revision=1
+revision=2
 _utils_commit=f45641beef46babdc8f1b8d18a924e72beaf8ee6
 _touch_commit=b1075c54a280f913edc26b9757262f4f9d6b62b0
 build_style=meson
+configure_args="--buildstyle=release" #Enables optimizations
 hostmakedepends="pkg-config wayland-devel"
 makedepends="wf-config-devel wlroots-devel cairo-devel
  $(vopt_if image 'libjpeg-turbo-devel libpng-devel')"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] wayfire: enable optimized binary
  2021-02-19  5:23 [PR PATCH] wayfire: enable optimized binary travankor
@ 2021-02-19  5:24 ` travankor
  2021-02-19  5:39 ` ericonr
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: travankor @ 2021-02-19  5:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

There is an updated pull request by travankor against master on the void-packages repository

https://github.com/travankor/void-packages wayfire
https://github.com/void-linux/void-packages/pull/28880

wayfire: enable optimized binary
None

A patch file from https://github.com/void-linux/void-packages/pull/28880.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wayfire-28880.patch --]
[-- Type: text/x-diff, Size: 900 bytes --]

From 85a33958cd782d4f2c3e61023b52288a4cd45931 Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Thu, 18 Feb 2021 22:22:31 -0700
Subject: [PATCH] wayfire: enable optimized binary

---
 srcpkgs/wayfire/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wayfire/template b/srcpkgs/wayfire/template
index fb3b85aef2c..69e6695c62e 100644
--- a/srcpkgs/wayfire/template
+++ b/srcpkgs/wayfire/template
@@ -1,10 +1,11 @@
 # Template file for 'wayfire'
 pkgname=wayfire
 version=0.7.0
-revision=1
+revision=2
 _utils_commit=f45641beef46babdc8f1b8d18a924e72beaf8ee6
 _touch_commit=b1075c54a280f913edc26b9757262f4f9d6b62b0
 build_style=meson
+configure_args="--buildtype=release" #Enables optimizations
 hostmakedepends="pkg-config wayland-devel"
 makedepends="wf-config-devel wlroots-devel cairo-devel
  $(vopt_if image 'libjpeg-turbo-devel libpng-devel')"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: wayfire: enable optimized binary
  2021-02-19  5:23 [PR PATCH] wayfire: enable optimized binary travankor
  2021-02-19  5:24 ` [PR PATCH] [Updated] " travankor
@ 2021-02-19  5:39 ` ericonr
  2021-02-22 13:25 ` [PR PATCH] [Updated] " travankor
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-02-19  5:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28880#issuecomment-781837586

Comment:
You'd have to compare the generated build.ninja for differences, but I don't think this would change much...

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] wayfire: enable optimized binary
  2021-02-19  5:23 [PR PATCH] wayfire: enable optimized binary travankor
  2021-02-19  5:24 ` [PR PATCH] [Updated] " travankor
  2021-02-19  5:39 ` ericonr
@ 2021-02-22 13:25 ` travankor
  2021-02-22 23:27 ` travankor
  2021-02-24  5:09 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: travankor @ 2021-02-22 13:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

There is an updated pull request by travankor against master on the void-packages repository

https://github.com/travankor/void-packages wayfire
https://github.com/void-linux/void-packages/pull/28880

wayfire: enable optimized binary
Lowers CPU use by a few percent.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/28880.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wayfire-28880.patch --]
[-- Type: text/x-diff, Size: 1166 bytes --]

From 43b51b21d08faa6f0a18f92bdeb3317bfdb9fe2b Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Thu, 18 Feb 2021 22:22:31 -0700
Subject: [PATCH] wayfire: enable optimized binary

Recommended by upstream author to improve performance and lower CPU use.
---
 srcpkgs/wayfire/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wayfire/template b/srcpkgs/wayfire/template
index fb3b85aef2c..ab6136b7247 100644
--- a/srcpkgs/wayfire/template
+++ b/srcpkgs/wayfire/template
@@ -1,7 +1,7 @@
 # Template file for 'wayfire'
 pkgname=wayfire
 version=0.7.0
-revision=1
+revision=2
 _utils_commit=f45641beef46babdc8f1b8d18a924e72beaf8ee6
 _touch_commit=b1075c54a280f913edc26b9757262f4f9d6b62b0
 build_style=meson
@@ -20,6 +20,10 @@ checksum="b1a94ad2843db19e78cbd361ceebaade4507647ad893d5b5117a9fc7724ce41c
  d172f8c21e0bac01e4116cd957fb0159c5cb39ddfdce897beb0d9c753796d5f1
  2b22e03d3a522baeff5798f630ffe5aa95899fd3233b291527503af5fd3e30be"
 
+# Optimization for nested STL calls
+CXXFLAGS="-O3"
+LDFLAGS="-Wl,-O1"
+
 build_options="image"
 build_options_default="image"
 desc_option_image="Enable JPEG and PNG support"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: wayfire: enable optimized binary
  2021-02-19  5:23 [PR PATCH] wayfire: enable optimized binary travankor
                   ` (2 preceding siblings ...)
  2021-02-22 13:25 ` [PR PATCH] [Updated] " travankor
@ 2021-02-22 23:27 ` travankor
  2021-02-24  5:09 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: travankor @ 2021-02-22 23:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/28880#issuecomment-783751872

Comment:
I diffed the build.ninja and found two differences. CPU use is reduced for me when wayfire has high CPU use (ie: the screen is updating a lot). It's probably more noticeable on lower end CPUs.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: wayfire: enable optimized binary
  2021-02-19  5:23 [PR PATCH] wayfire: enable optimized binary travankor
                   ` (3 preceding siblings ...)
  2021-02-22 23:27 ` travankor
@ 2021-02-24  5:09 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-02-24  5:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

There's a merged pull request on the void-packages repository

wayfire: enable optimized binary
https://github.com/void-linux/void-packages/pull/28880

Description:
Lowers CPU use by a few percent.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-24  5:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19  5:23 [PR PATCH] wayfire: enable optimized binary travankor
2021-02-19  5:24 ` [PR PATCH] [Updated] " travankor
2021-02-19  5:39 ` ericonr
2021-02-22 13:25 ` [PR PATCH] [Updated] " travankor
2021-02-22 23:27 ` travankor
2021-02-24  5:09 ` [PR PATCH] [Merged]: " ericonr

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git