[PR PATCH] mpd: update to 0.22.6.

[PR PATCH] mpd: update to 0.22.6.

[UsernameRandomlyGenerated]

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

There is a new pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages mpd0226
https://github.com/void-linux/void-packages/pull/28915

mpd: update to 0.22.6.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28915.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpd0226-28915.patch --]
[-- Type: text/x-diff, Size: 1089 bytes --]

From 2e6bdd46cb62d34adaac4712862e9e0d1bfaf8c8 Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Sat, 20 Feb 2021 11:10:35 +0100
Subject: [PATCH] mpd: update to 0.22.6.

---
 srcpkgs/mpd/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/mpd/template b/srcpkgs/mpd/template
index d03c063a324..5ca4ce8154b 100644
--- a/srcpkgs/mpd/template
+++ b/srcpkgs/mpd/template
@@ -1,6 +1,6 @@
 # Template file for 'mpd'
 pkgname=mpd
-version=0.22.4
+version=0.22.6
 revision=1
 build_style=meson
 configure_args="-Dopus=enabled -Dmikmod=enabled -Dneighbor=true
@@ -37,7 +37,7 @@ license="GPL-2.0-or-later"
 homepage="https://www.musicpd.org/"
 changelog="https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/v${version}/NEWS"
 distfiles="https://www.musicpd.org/download/mpd/${version%.*}/mpd-${version}.tar.xz"
-checksum=891ea993a539246fa8f670346e5aa6c8cc85ce4be739ff12261712b0b3149dd0
+checksum=2be149a4895c3cb613477f8cf1193593e3d8a1d38a75ffa7d32da8c8316a4d5e
 LDFLAGS+=" -Wl,-z,stack-size=1048576"
 patch_args="-Np1"
 

Re: [PR REVIEW] mpd: update to 0.22.6.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28915#discussion_r579741366

Comment:
```suggestion
changelog="https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/master/NEWS"
```

Re: [PR REVIEW] mpd: update to 0.22.6.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/28915#discussion_r582966712

Comment:
I think it's because musl strptime does not support the `%F` field descriptor

Re: [PR REVIEW] mpd: update to 0.22.6.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/28915#discussion_r582966712

Comment:
I think it's because musl strptime does not support the `%F` field descriptor

Re: mpd: update to 0.22.6.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/28915#issuecomment-786020330

Comment:
> Have you looked at the test failure for musl? It was present on 0.22.4 already, so no reason to hold the update on it, but would be nice to get fixed one way or another.

I think it's because musl strptime does not support the `%F` field descriptor

Re: mpd: update to 0.22.6.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28915#issuecomment-786037886

Comment:
Nice find! I will try to write up a patch.

Re: mpd: update to 0.22.6.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28915#issuecomment-786054869

Comment:
Pull in https://github.com/MusicPlayerDaemon/MPD/pull/1110

Re: mpd: update to 0.22.6.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28915#issuecomment-786054869

Comment:
Pull in https://github.com/MusicPlayerDaemon/MPD/pull/1110

Pulling in https://github.com/MusicPlayerDaemon/MPD/pull/1111 doesn't cost anything either :p

Re: [PR PATCH] [Closed]: mpd: update to 0.22.6.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

There's a closed pull request on the void-packages repository

mpd: update to 0.22.6.
https://github.com/void-linux/void-packages/pull/28915

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

[PR PATCH] mpd: update to 0.22.6.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]

There is a new pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages mpd
https://github.com/void-linux/void-packages/pull/29057

mpd: update to 0.22.6.
fix musl tests

closes #28915
@ericonr 

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29057.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpd-29057.patch --]
[-- Type: text/x-diff, Size: 4244 bytes --]

From b16d51f16372e911cc878adcccdddc760b8df7ad Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Thu, 25 Feb 2021 19:52:12 +0100
Subject: [PATCH] mpd: update to 0.22.6.

fix musl tests
---
 .../patches/dont-use-glibc-extension.patch    | 36 +++++++++++++++++++
 srcpkgs/mpd/patches/fix-musl-tests.patch      | 24 +++++++++++++
 srcpkgs/mpd/template                          |  4 +--
 3 files changed, 62 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/mpd/patches/dont-use-glibc-extension.patch
 create mode 100644 srcpkgs/mpd/patches/fix-musl-tests.patch

diff --git a/srcpkgs/mpd/patches/dont-use-glibc-extension.patch b/srcpkgs/mpd/patches/dont-use-glibc-extension.patch
new file mode 100644
index 00000000000..edb22981b3b
--- /dev/null
+++ b/srcpkgs/mpd/patches/dont-use-glibc-extension.patch
@@ -0,0 +1,36 @@
+From 18f6e76a07245b9cc8d87cd9b582d4e7252494d3 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
+Date: Thu, 25 Feb 2021 14:21:36 -0300
+Subject: [PATCH] storage/plugins/CurlStorage: don't use glibc extension in
+ ParseTimePoint.
+
+%Z is a glibc extension to strptime, and is a no-op there, due to the
+mapping between timezone names and their definition (especially when the
+name comes from a different machine) being ambiguous / impossible.  Time
+in HTTP headers is guaranteed to be UTC.
+
+Passing an unknown format to strptime() implementations that don't
+support it will generally cause them to return NULL, which will lead to
+ParseTimePoint throwing an exception and ParseTimeStamp using an
+unnecessary fallback.
+
+Since the timezone name goes at the end of the string, we don't need to
+use %Z to skip it (could be an issue in a different time stamp format),
+so simply removing %Z works best.
+---
+ src/storage/plugins/CurlStorage.cxx | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/storage/plugins/CurlStorage.cxx b/src/storage/plugins/CurlStorage.cxx
+index d05b90a31..9d862eb32 100644
+--- a/src/storage/plugins/CurlStorage.cxx
++++ b/src/storage/plugins/CurlStorage.cxx
+@@ -193,7 +193,7 @@ ParseTimeStamp(const char *s)
+ {
+ 	try {
+ 		// TODO: make this more robust
+-		return ParseTimePoint(s, "%a, %d %b %Y %T %Z");
++		return ParseTimePoint(s, "%a, %d %b %Y %T");
+ 	} catch (...) {
+ 		return std::chrono::system_clock::time_point::min();
+ 	}
diff --git a/srcpkgs/mpd/patches/fix-musl-tests.patch b/srcpkgs/mpd/patches/fix-musl-tests.patch
new file mode 100644
index 00000000000..a1b450988ed
--- /dev/null
+++ b/srcpkgs/mpd/patches/fix-musl-tests.patch
@@ -0,0 +1,24 @@
+From 634bd4798c4dab00f0a0869fed9a4f31bfbd53fa Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
+Date: Thu, 25 Feb 2021 13:53:31 -0300
+Subject: [PATCH] time/ISO8601: don't use glibc extension in strptime.
+
+Per the manual for strptime, %F is equivalent %Y-%m-%d, so use that
+directly.
+---
+ src/time/ISO8601.cxx | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/time/ISO8601.cxx b/src/time/ISO8601.cxx
+index e2197e3ad..be20ee803 100644
+--- a/src/time/ISO8601.cxx
++++ b/src/time/ISO8601.cxx
+@@ -202,7 +202,7 @@ ParseISO8601(const char *s)
+ 	}
+ 
+ 	/* parse the date */
+-	const char *end = strptime(s, "%F", &tm);
++	const char *end = strptime(s, "%Y-%m-%d", &tm);
+ 	if (end == nullptr) {
+ 		/* try without field separators */
+ 		end = strptime(s, "%Y%m%d", &tm);
diff --git a/srcpkgs/mpd/template b/srcpkgs/mpd/template
index 18701cd912a..9fb76d5e0a4 100644
--- a/srcpkgs/mpd/template
+++ b/srcpkgs/mpd/template
@@ -1,6 +1,6 @@
 # Template file for 'mpd'
 pkgname=mpd
-version=0.22.4
+version=0.22.6
 revision=1
 build_style=meson
 configure_args="-Dopus=enabled -Dmikmod=enabled -Dneighbor=true
@@ -37,7 +37,7 @@ license="GPL-2.0-or-later"
 homepage="https://www.musicpd.org/"
 changelog="https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/v${version}/NEWS"
 distfiles="https://www.musicpd.org/download/mpd/${version%.*}/mpd-${version}.tar.xz"
-checksum=891ea993a539246fa8f670346e5aa6c8cc85ce4be739ff12261712b0b3149dd0
+checksum=2be149a4895c3cb613477f8cf1193593e3d8a1d38a75ffa7d32da8c8316a4d5e
 LDFLAGS+=" -Wl,-z,stack-size=1048576"
 patch_args="-Np1"