Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] ffmpeg: build -dbg package properly
@ 2021-02-21 12:19 sgn
  2021-02-22 18:56 ` [PR REVIEW] " ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: sgn @ 2021-02-21 12:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages ffmpeg-dbg
https://github.com/void-linux/void-packages/pull/28954

ffmpeg: build -dbg package properly
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Close #28931 

- [ ] The source file haven't been mapped properly, though.

A patch file from https://github.com/void-linux/void-packages/pull/28954.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffmpeg-dbg-28954.patch --]
[-- Type: text/x-diff, Size: 1312 bytes --]

From e44f7aba5c92006071d0621e569600fad471ac62 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Sun, 21 Feb 2021 19:15:59 +0700
Subject: [PATCH] ffmpeg: build -dbg package properly

---
 srcpkgs/ffmpeg/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ffmpeg/template b/srcpkgs/ffmpeg/template
index 5a79f1292c4..c00cf83e8ac 100644
--- a/srcpkgs/ffmpeg/template
+++ b/srcpkgs/ffmpeg/template
@@ -2,7 +2,7 @@
 # audacity also needs to be bumped when a new ffmpeg version bumps libavformat's soname!
 pkgname=ffmpeg
 version=4.3.1
-revision=6
+revision=7
 short_desc="Decoding, encoding and streaming software"
 maintainer="Johannes <johannes.brechtmann@gmail.com>"
 license="GPL-3.0-or-later"
@@ -78,6 +78,7 @@ do_configure() {
 	esac
 
 	./configure --prefix=/usr --disable-debug --enable-gpl --enable-gnutls \
+		--disable-stripping \
 		--enable-libcdio --enable-version3 --enable-runtime-cpudetect \
 		--enable-libmp3lame --enable-libvorbis --enable-libxvid \
 		--enable-libx264 $(vopt_enable vpx libvpx) --enable-libtheora \
@@ -99,7 +100,6 @@ do_configure() {
 		$(vopt_if webp '--enable-libwebp')
 }
 do_build() {
-	rm ${XBPS_WRAPPERDIR}/strip
 	make ${makejobs}
 	make doc/ff{mpeg,play}.1
 }

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] ffmpeg: build -dbg package properly
  2021-02-21 12:19 [PR PATCH] ffmpeg: build -dbg package properly sgn
@ 2021-02-22 18:56 ` ericonr
  2021-02-22 19:21 ` ericonr
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-02-22 18:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28954#discussion_r580504977

Comment:
This was added in a0d88ba8496402b76ab503a59b3990e441f878ab for unknown reasons >.<

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: ffmpeg: build -dbg package properly
  2021-02-21 12:19 [PR PATCH] ffmpeg: build -dbg package properly sgn
  2021-02-22 18:56 ` [PR REVIEW] " ericonr
@ 2021-02-22 19:21 ` ericonr
  2021-02-22 23:38 ` sgn
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-02-22 19:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28954#issuecomment-783612358

Comment:
Tested with debuginfod, this seems to have fixed it. The i686 failure is due to old `dolphin-emu`, which should probably be cleaned up.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: ffmpeg: build -dbg package properly
  2021-02-21 12:19 [PR PATCH] ffmpeg: build -dbg package properly sgn
  2021-02-22 18:56 ` [PR REVIEW] " ericonr
  2021-02-22 19:21 ` ericonr
@ 2021-02-22 23:38 ` sgn
  2021-02-22 23:51 ` [PR REVIEW] " sgn
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2021-02-22 23:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28954#issuecomment-783757163

Comment:
`--disable-stripping` is enough. That echo come from their Makefile.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] ffmpeg: build -dbg package properly
  2021-02-21 12:19 [PR PATCH] ffmpeg: build -dbg package properly sgn
                   ` (2 preceding siblings ...)
  2021-02-22 23:38 ` sgn
@ 2021-02-22 23:51 ` sgn
  2021-02-22 23:53 ` sgn
  2021-02-22 23:53 ` [PR PATCH] [Merged]: " sgn
  5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2021-02-22 23:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28954#discussion_r580675722

Comment:
W/o that line and `--disable-stripping`, the build will run into failure.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: ffmpeg: build -dbg package properly
  2021-02-21 12:19 [PR PATCH] ffmpeg: build -dbg package properly sgn
                   ` (3 preceding siblings ...)
  2021-02-22 23:51 ` [PR REVIEW] " sgn
@ 2021-02-22 23:53 ` sgn
  2021-02-22 23:53 ` [PR PATCH] [Merged]: " sgn
  5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2021-02-22 23:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28954#issuecomment-783757163

Comment:
`--disable-stripping` is enough. That echo come from their `configure` https://github.com/FFmpeg/FFmpeg/blob/8d5bd5b8df89543f75eadd36f5c1755e4d6d51d4/configure#L7420.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: ffmpeg: build -dbg package properly
  2021-02-21 12:19 [PR PATCH] ffmpeg: build -dbg package properly sgn
                   ` (4 preceding siblings ...)
  2021-02-22 23:53 ` sgn
@ 2021-02-22 23:53 ` sgn
  5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2021-02-22 23:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

There's a merged pull request on the void-packages repository

ffmpeg: build -dbg package properly
https://github.com/void-linux/void-packages/pull/28954

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Close #28931 

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-02-22 23:53 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-21 12:19 [PR PATCH] ffmpeg: build -dbg package properly sgn
2021-02-22 18:56 ` [PR REVIEW] " ericonr
2021-02-22 19:21 ` ericonr
2021-02-22 23:38 ` sgn
2021-02-22 23:51 ` [PR REVIEW] " sgn
2021-02-22 23:53 ` sgn
2021-02-22 23:53 ` [PR PATCH] [Merged]: " sgn

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git