[PR PATCH] htop: enable sensors support

[PR PATCH] htop: enable sensors support

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

There is a new pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages feature/htop/temperature
https://github.com/void-linux/void-packages/pull/28959

htop: enable sensors support
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR


libsensors won't be a runtime dependency, and will only be loaded if detected

A patch file from https://github.com/void-linux/void-packages/pull/28959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/htop/temperature-28959.patch --]
[-- Type: text/x-diff, Size: 922 bytes --]

From d0ef080c420ab5461b070f4b9864f28d2730f246 Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Sun, 21 Feb 2021 17:54:24 +0100
Subject: [PATCH] htop: enable sensors support

---
 srcpkgs/htop/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/htop/template b/srcpkgs/htop/template
index 2693e232c4b..be377849051 100644
--- a/srcpkgs/htop/template
+++ b/srcpkgs/htop/template
@@ -1,11 +1,11 @@
 # Template file for 'htop'
 pkgname=htop
 version=3.0.5
-revision=1
+revision=2
 build_style=gnu-configure
-configure_args="--enable-unicode --enable-cgroup --enable-taskstats"
+configure_args="--enable-unicode --enable-cgroup --enable-taskstats --enable-sensors"
 hostmakedepends="automake"
-makedepends="ncurses-devel"
+makedepends="ncurses-devel libsensors-devel"
 short_desc="Interactive process viewer"
 maintainer="Frank Steinborn <steinex@nognu.de>"
 license="GPL-2.0-only"

Re: htop: enable sensors support

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28959#issuecomment-782901180

Comment:
Oh neat, good find.

Re: htop: enable sensors support

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28959#issuecomment-782903946

Comment:
Ok, `--enable-sensors` is only in git master, this version should be using `--with-sensors`. Or we can wait for an update :)

Re: htop: enable sensors support

[BenBE]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by BenBE on void-packages repository

https://github.com/void-linux/void-packages/pull/28959#issuecomment-782908068

Comment:
Next release will take a few more $UnitsOfTime … ;-)

Re: htop: enable sensors support

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28959#issuecomment-782909221

Comment:
So use `--with-sensors` and leave a comment that next version will be using `--enable-sensors` instead :)

Re: htop: enable sensors support

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New comment by the-eater on void-packages repository

https://github.com/void-linux/void-packages/pull/28959#issuecomment-782912620

Comment:
haha, so default value is `check` so it worked™ anyhow.

also

`configure: WARNING: unrecognized options: --enable-cgroup, --enable-taskstats` should I just remove those in that case?

Re: htop: enable sensors support

[BenBE]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

New comment by BenBE on void-packages repository

https://github.com/void-linux/void-packages/pull/28959#issuecomment-782918754

Comment:
The options for `configure` have been renamed recently (cf. https://github.com/htop-dev/htop/pull/482) accompanied by changing the defaults to check for the dependencies to be present. If you want to get a stable build (ensuring features are actually compiled in) it's best to specify those options explicitly.

Re: [PR PATCH] [Updated] htop: enable sensors support

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

There is an updated pull request by the-eater against master on the void-packages repository

https://github.com/the-eater/neo-void-packages feature/htop/temperature
https://github.com/void-linux/void-packages/pull/28959

htop: enable sensors support
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR


libsensors won't be a runtime dependency, and will only be loaded if detected

A patch file from https://github.com/void-linux/void-packages/pull/28959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/htop/temperature-28959.patch --]
[-- Type: text/x-diff, Size: 949 bytes --]

From 2cce3639cbb4bef06bbe5870f5e998c5052e1049 Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Sun, 21 Feb 2021 17:54:24 +0100
Subject: [PATCH] htop: enable sensors support

---
 srcpkgs/htop/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/htop/template b/srcpkgs/htop/template
index 2693e232c4b..96fd8b5de16 100644
--- a/srcpkgs/htop/template
+++ b/srcpkgs/htop/template
@@ -1,11 +1,12 @@
 # Template file for 'htop'
 pkgname=htop
 version=3.0.5
-revision=1
+revision=2
 build_style=gnu-configure
-configure_args="--enable-unicode --enable-cgroup --enable-taskstats"
+# NOTE: change --with-sensors to --enable-sensors next update
+configure_args="--enable-unicode --with-sensors"
 hostmakedepends="automake"
-makedepends="ncurses-devel"
+makedepends="ncurses-devel libsensors-devel"
 short_desc="Interactive process viewer"
 maintainer="Frank Steinborn <steinex@nognu.de>"
 license="GPL-2.0-only"

Re: htop: enable sensors support

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by the-eater on void-packages repository

https://github.com/void-linux/void-packages/pull/28959#issuecomment-785059974

Comment:
removed `--enable-cgroup --enable-taskstats` since they don't exist

Re: [PR PATCH] [Merged]: htop: enable sensors support

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

There's a merged pull request on the void-packages repository

htop: enable sensors support
https://github.com/void-linux/void-packages/pull/28959

Description:
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR


libsensors won't be a runtime dependency, and will only be loaded if detected

Re: htop: enable sensors support

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/28959#issuecomment-842448507

Comment:
I do not see any temperature in `Available meters`.
Is any further configuration required?

```
$ htop --version
htop 3.0.5
$ xuname
Void 5.11.21_1 x86_64-musl GenuineIntel uptodate hold rrnFFFF
$ xpkg -v | grep sensors
libsensors-3.6.0_1
```

Thanks.

Re: htop: enable sensors support

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New comment by the-eater on void-packages repository

https://github.com/void-linux/void-packages/pull/28959#issuecomment-842531384

Comment:
Display Options -> Also show CPU Tempature

Re: htop: enable sensors support

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/28959#issuecomment-842535654

Comment:
Thanks.