* [PR PATCH] empathy: remove package.
@ 2021-02-21 22:24 ericonr
2021-02-21 22:54 ` Gottox
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: ericonr @ 2021-02-21 22:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2092 bytes --]
There is a new pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages empathy
https://github.com/void-linux/void-packages/pull/28963
empathy: remove package.
Has been abandonware for at least three years, as seen in [1].
This is not great for a network exposed messenger, though it hasn't
received any CVEs as far as I could find.
It is also a blocker for enchant 1.x removal, though this is easy to fix
with the patch from [2]. I decided not to go with this option for the
reason listed above.
[1] https://gitlab.gnome.org/GNOME/empathy/-/commit/37976f61d8dddc950a9b7d3b1417d784b331927f
[2] https://gitlab.gnome.org/GNOME/empathy/-/merge_requests/3
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28963.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-empathy-28963.patch --]
[-- Type: text/x-diff, Size: 3503 bytes --]
From cafa4838dd5c076ba42ec237c6edcd41d721d506 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 21 Feb 2021 19:18:53 -0300
Subject: [PATCH] empathy: remove package.
Has been abandonware for at least three years, as seen in [1].
This is not great for a network exposed messenger, though it hasn't
received any CVEs as far as I could find.
It is also a blocker for enchant 1.x removal, though this is easy to fix
with the patch from [2]. I decided not to go with this option for the
reason listed above.
[1] https://gitlab.gnome.org/GNOME/empathy/-/commit/37976f61d8dddc950a9b7d3b1417d784b331927f
[2] https://gitlab.gnome.org/GNOME/empathy/-/merge_requests/3
---
srcpkgs/empathy/INSTALL.msg | 8 --------
srcpkgs/empathy/template | 31 -------------------------------
srcpkgs/removed-packages/template | 1 +
3 files changed, 1 insertion(+), 39 deletions(-)
delete mode 100644 srcpkgs/empathy/INSTALL.msg
delete mode 100644 srcpkgs/empathy/template
diff --git a/srcpkgs/empathy/INSTALL.msg b/srcpkgs/empathy/INSTALL.msg
deleted file mode 100644
index de8e50ea3da..00000000000
--- a/srcpkgs/empathy/INSTALL.msg
+++ /dev/null
@@ -1,8 +0,0 @@
-Some optional packages must be installed for additional functionality:
-
- - telepathy-butterfly for MSN support
- - telepathy-gabble for XMPP/jabber support
- - telepathy-haze for libpurple support
- - telepathy-idle for IRC support
- - telepathy-rakia for SIP support
- - telepathy-salut for link-local XMPP support
diff --git a/srcpkgs/empathy/template b/srcpkgs/empathy/template
deleted file mode 100644
index 4e01bad39a3..00000000000
--- a/srcpkgs/empathy/template
+++ /dev/null
@@ -1,31 +0,0 @@
-# Template file for 'empathy'
-pkgname=empathy
-version=3.12.14
-revision=2
-build_style=gnu-configure
-configure_args="
- --enable-gst-1.0=yes --enable-gudev=yes --enable-spell=yes
- --disable-schemas-compile --disable-static --enable-goa=no
- --enable-ubuntu-online-accounts=no --enable-geocode=yes
- --enable-location=yes --enable-nautilus-sendto=no --enable-map=yes"
-hostmakedepends="pkg-config intltool itstool glib-devel libxslt geoclue2"
-makedepends="
- libcanberra-devel clutter-gst-devel clutter-gtk-devel
- telepathy-glib-devel telepathy-logger-devel libnotify-devel
- telepathy-farstream-devel telepathy-mission-control-devel
- evolution-data-server-devel geocode-glib-devel folks-devel
- webkit2gtk-devel libgudev-devel pulseaudio-devel cheese-devel
- enchant-devel NetworkManager-devel libchamplain-devel
- gnutls-devel gsettings-desktop-schemas-devel geoclue2-devel iso-codes"
-depends="gsettings-desktop-schemas>=3.12 iso-codes"
-short_desc="GNOME instant messaging client using the Telepathy framework"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2.0-or-later, LGPL-2.1-or-later"
-homepage="http://live.gnome.org/Empathy"
-distfiles="${GNOME_SITE}/$pkgname/${version%.*}/$pkgname-$version.tar.xz"
-checksum=7d86942ce97edd10ade0e6ae6a210d35e4d627fe4d223377d71fd1840bc6e3a3
-disable_parallel_build=yes
-
-pre_configure() {
- CFLAGS+=" -I$wrksrc/telepathy-account-widgets"
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 2d2338a8b9b..512b604f350 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -37,6 +37,7 @@ replaces="
ebtables<=2.0.10.4_8
eclipse-ecj<=4.9_3
electron7<=7.3.3_1
+ empathy<=3.12.14_2
enventor<=1.0.0_2
epstopdf<=2.27_3
fontmatrix<=0.6.0.20171228_2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: empathy: remove package.
2021-02-21 22:24 [PR PATCH] empathy: remove package ericonr
@ 2021-02-21 22:54 ` Gottox
2021-03-22 1:04 ` ericonr
2021-03-22 1:04 ` [PR PATCH] [Closed]: " ericonr
2 siblings, 0 replies; 5+ messages in thread
From: Gottox @ 2021-02-21 22:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 342 bytes --]
New comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/28963#issuecomment-782943265
Comment:
I would keep it for now. I would guess, that there are a bunch of users that are still using it.
Just to get an idea, I set up a twitter poll: https://twitter.com/VoidLinux/status/1363622828457811970
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Closed]: empathy: remove package.
2021-02-21 22:24 [PR PATCH] empathy: remove package ericonr
2021-02-21 22:54 ` Gottox
2021-03-22 1:04 ` ericonr
@ 2021-03-22 1:04 ` ericonr
2 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-03-22 1:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1941 bytes --]
There's a closed pull request on the void-packages repository
empathy: remove package.
https://github.com/void-linux/void-packages/pull/28963
Description:
Has been abandonware for at least three years, as seen in [1].
This is not great for a network exposed messenger, though it hasn't
received any CVEs as far as I could find.
It is also a blocker for enchant 1.x removal, though this is easy to fix
with the patch from [2]. I decided not to go with this option for the
reason listed above.
[1] https://gitlab.gnome.org/GNOME/empathy/-/commit/37976f61d8dddc950a9b7d3b1417d784b331927f
[2] https://gitlab.gnome.org/GNOME/empathy/-/merge_requests/3
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: empathy: remove package.
2021-02-21 22:24 [PR PATCH] empathy: remove package ericonr
2021-02-21 22:54 ` Gottox
@ 2021-03-22 1:04 ` ericonr
2021-03-22 1:04 ` [PR PATCH] [Closed]: " ericonr
2 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-03-22 1:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28963#issuecomment-803698717
Comment:
Closed in #29598
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PR PATCH] empathy: remove package
@ 2022-10-01 13:59 paper42
0 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-10-01 13:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
There is a new pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages remove-empathy
https://github.com/void-linux/void-packages/pull/39588
empathy: remove package
* uses libsoup2, archived upstream
A patch file from https://github.com/void-linux/void-packages/pull/39588.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-remove-empathy-39588.patch --]
[-- Type: text/x-diff, Size: 5883 bytes --]
From 10fab791788034df5f4935f299fe1bb8e31bac5d Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 1 Oct 2022 14:45:54 +0200
Subject: [PATCH] empathy: remove package
* uses libsoup2, archived upstream
---
srcpkgs/empathy/files/README.voidlinux | 6 --
srcpkgs/empathy/patches/enchant-2.patch | 79 -------------------------
srcpkgs/empathy/template | 39 ------------
srcpkgs/removed-packages/template | 1 +
4 files changed, 1 insertion(+), 124 deletions(-)
delete mode 100644 srcpkgs/empathy/files/README.voidlinux
delete mode 100644 srcpkgs/empathy/patches/enchant-2.patch
delete mode 100644 srcpkgs/empathy/template
diff --git a/srcpkgs/empathy/files/README.voidlinux b/srcpkgs/empathy/files/README.voidlinux
deleted file mode 100644
index 090705a4075f..000000000000
--- a/srcpkgs/empathy/files/README.voidlinux
+++ /dev/null
@@ -1,6 +0,0 @@
-Some optional packages must be installed for additional functionality:
-
- - telepathy-gabble for XMPP/jabber support
- - telepathy-haze for libpurple support
- - telepathy-idle for IRC support
- - telepathy-salut for link-local XMPP support
diff --git a/srcpkgs/empathy/patches/enchant-2.patch b/srcpkgs/empathy/patches/enchant-2.patch
deleted file mode 100644
index c2b3a50c038f..000000000000
--- a/srcpkgs/empathy/patches/enchant-2.patch
+++ /dev/null
@@ -1,79 +0,0 @@
-Source: https://gitlab.gnome.org/GNOME/empathy/-/merge_requests/3
-Upstream: no, because upstream is completely abandoned
-
-From f42c415154c797a1b3fbddde60ad8fedb2eda988 Mon Sep 17 00:00:00 2001
-From: Laurent Bigonville <bigon@bigon.be>
-Date: Tue, 7 Jan 2020 11:09:26 +0100
-Subject: [PATCH 1/2] libempathy-gtk: Stop using deprecated enchant function
-
-Replace enchant_dict_add_to_pwl() by enchant_dict_add() and bump minimal
-version accordingly
----
- configure.ac | 2 +-
- libempathy-gtk/empathy-spell.c | 2 +-
- 2 files changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/configure.ac b/configure.ac
-index 7aeb6b31c..4bf2d4d0c 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -72,7 +72,7 @@ WEBKIT_REQUIRED=2.10.0
- GOA_REQUIRED=3.5.1
-
- # Optional deps
--ENCHANT_REQUIRED=1.2.0
-+ENCHANT_REQUIRED=1.4.0
- GEOCLUE_REQUIRED=2.1.0
- GEOCODE_GLIB_REQUIRED=0.99.1
- ISO_CODES_REQUIRED=0.35
-diff --git a/libempathy-gtk/empathy-spell.c b/libempathy-gtk/empathy-spell.c
-index 27f27f902..bb0159fd8 100644
---- a/libempathy-gtk/empathy-spell.c
-+++ b/libempathy-gtk/empathy-spell.c
-@@ -424,7 +424,7 @@ empathy_spell_add_to_dictionary (const gchar *code,
- if (lang == NULL)
- return;
-
-- enchant_dict_add_to_pwl (lang->speller, word, strlen (word));
-+ enchant_dict_add (lang->speller, word, strlen (word));
- }
-
- #else /* not HAVE_ENCHANT */
---
-GitLab
-
-
-From 6c12a411274acf86e494b36704abb8e18b56642e Mon Sep 17 00:00:00 2001
-From: Laurent Bigonville <bigon@bigon.be>
-Date: Tue, 7 Jan 2020 11:38:13 +0100
-Subject: [PATCH 2/2] configure.ac: Switch to enchant-2
-
----
- configure.ac | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/configure.ac b/configure.ac
-index 4bf2d4d0c..14f83c852 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -72,7 +72,7 @@ WEBKIT_REQUIRED=2.10.0
- GOA_REQUIRED=3.5.1
-
- # Optional deps
--ENCHANT_REQUIRED=1.4.0
-+ENCHANT_REQUIRED=2.1.1
- GEOCLUE_REQUIRED=2.1.0
- GEOCODE_GLIB_REQUIRED=0.99.1
- ISO_CODES_REQUIRED=0.35
-@@ -307,7 +307,7 @@ AC_ARG_ENABLE(spell,
- if test "x$enable_spell" != "xno"; then
- PKG_CHECK_MODULES(ENCHANT,
- [
-- enchant >= $ENCHANT_REQUIRED,
-+ enchant-2 >= $ENCHANT_REQUIRED,
- iso-codes >= $ISO_CODES_REQUIRED
- ], have_enchant="yes", have_enchant="no")
-
---
-GitLab
-
diff --git a/srcpkgs/empathy/template b/srcpkgs/empathy/template
deleted file mode 100644
index 34319aa881c6..000000000000
--- a/srcpkgs/empathy/template
+++ /dev/null
@@ -1,39 +0,0 @@
-# Template file for 'empathy'
-pkgname=empathy
-version=3.12.14
-revision=4
-build_style=gnu-configure
-configure_args="
- --enable-gst-1.0=yes --enable-gudev=yes --enable-spell=yes
- --disable-schemas-compile --disable-static --enable-goa=no
- --enable-ubuntu-online-accounts=no --enable-geocode=yes
- --enable-location=yes --enable-nautilus-sendto=no --enable-map=yes"
-hostmakedepends="pkg-config intltool itstool glib-devel libxslt geoclue2
- autoconf automake libtool gettext-devel yelp-tools"
-makedepends="
- libcanberra-devel clutter-gst-devel clutter-gtk-devel
- telepathy-glib-devel telepathy-logger-devel libnotify-devel
- telepathy-farstream-devel telepathy-mission-control-devel
- evolution-data-server-devel geocode-glib-devel folks-devel
- webkit2gtk-devel libgudev-devel pulseaudio-devel cheese-devel
- enchant2-devel NetworkManager-devel libchamplain-devel
- gnutls-devel gsettings-desktop-schemas-devel geoclue2-devel iso-codes"
-depends="gsettings-desktop-schemas>=3.12 iso-codes"
-short_desc="GNOME instant messaging client using the Telepathy framework"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2.0-or-later, LGPL-2.1-or-later"
-homepage="http://live.gnome.org/Empathy"
-distfiles="${GNOME_SITE}/$pkgname/${version%.*}/$pkgname-$version.tar.xz"
-checksum=7d86942ce97edd10ade0e6ae6a210d35e4d627fe4d223377d71fd1840bc6e3a3
-disable_parallel_build=yes
-# Disable checks, the only work with an irc server in place.
-make_check=no
-
-pre_configure() {
- CFLAGS+=" -I$wrksrc/telepathy-account-widgets"
- autoreconf -fi
-}
-
-post_install() {
- vdoc $FILESDIR/README.voidlinux
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 574d278136fb..bbd204314d5b 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -85,6 +85,7 @@ replaces="
electron7<=7.3.3_1
electron9<=9.4.1_1
emacs-gtk2<=27.2_1
+ empathy<=3.12.14_4
enventor<=1.0.0_2
epstopdf<=2.27_3
flickcurl-devel<=1.26_4
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-01 13:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-21 22:24 [PR PATCH] empathy: remove package ericonr
2021-02-21 22:54 ` Gottox
2021-03-22 1:04 ` ericonr
2021-03-22 1:04 ` [PR PATCH] [Closed]: " ericonr
2022-10-01 13:59 [PR PATCH] " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).