From: abenson <abenson@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] New package: spotify-qt-3.4
Date: Mon, 22 Feb 2021 18:11:34 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28978@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]
There is a new pull request by abenson against master on the void-packages repository
https://github.com/abenson/void-packages np_spotifyqt
https://github.com/void-linux/void-packages/pull/28978
New package: spotify-qt-3.4
<!-- Mark items with [x] where applicable -->
#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28978.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-np_spotifyqt-28978.patch --]
[-- Type: text/x-diff, Size: 2307 bytes --]
From b7c29f312adc0aee85df5f3e72b9e0e47de0d515 Mon Sep 17 00:00:00 2001
From: Andrew Benson <abenson+void@gmail.com>
Date: Mon, 22 Feb 2021 11:11:07 -0600
Subject: [PATCH] New package: spotify-qt-3.4
---
.../patches/fix-darkmode-toggle.patch | 26 +++++++++++++++++++
srcpkgs/spotify-qt/template | 13 ++++++++++
2 files changed, 39 insertions(+)
create mode 100644 srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
create mode 100644 srcpkgs/spotify-qt/template
diff --git a/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch b/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
new file mode 100644
index 00000000000..dd63a2d4a45
--- /dev/null
+++ b/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
@@ -0,0 +1,26 @@
+https://github.com/kraxarn/spotify-qt/commit/fe916f8976cca3983030e24d02d65e62893ad88d.patch
+
+From fe916f8976cca3983030e24d02d65e62893ad88d Mon Sep 17 00:00:00 2001
+From: kraxarn <me@kraxarn.com>
+Date: Sun, 7 Feb 2021 22:02:21 +0100
+Subject: [PATCH] Fix crash when toggling dark theme
+
+---
+ src/settingspage/interfacepage.cpp | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git src/settingspage/interfacepage.cpp src/settingspage/interfacepage.cpp
+index d809730..be16455 100644
+--- src/settingspage/interfacepage.cpp
++++ src/settingspage/interfacepage.cpp
+@@ -215,7 +215,9 @@ void InterfacePage::darkThemeToggle(bool checked)
+ if (checked)
+ {
+ itfStyle->setCurrentText("Fusion");
+- itfIcFallback->setChecked(true);
++
++ if (itfIcFallback != nullptr)
++ itfIcFallback->setChecked(true);
+ }
+ else
+ {
diff --git a/srcpkgs/spotify-qt/template b/srcpkgs/spotify-qt/template
new file mode 100644
index 00000000000..001b427caf4
--- /dev/null
+++ b/srcpkgs/spotify-qt/template
@@ -0,0 +1,13 @@
+# Template file for 'spotify-qt'
+pkgname=spotify-qt
+version=3.4
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt5-devel"
+makedepends="qt5-devel qt5-svg-devel"
+short_desc="Lightweight Spotify client using Qt"
+maintainer="Andrew Benson <abenson+void@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/kraxarn/spotify-qt"
+distfiles="https://github.com/kraxarn/spotify-qt/archive/v${version}.tar.gz"
+checksum=ceae5dec3aa31a3fbf6754a2c481dfc1b32b9f5e131007ec176f64a87a6e516e
next reply other threads:[~2021-02-22 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 17:11 abenson [this message]
2021-02-22 17:45 ` [PR PATCH] [Updated] " abenson
2021-02-22 18:43 ` [PR PATCH] [Merged]: " abenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28978@inbox.vuxu.org \
--to=abenson@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).