Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: spotify-qt-3.4
@ 2021-02-22 17:11 abenson
  2021-02-22 17:45 ` [PR PATCH] [Updated] " abenson
  2021-02-22 18:43 ` [PR PATCH] [Merged]: " abenson
  0 siblings, 2 replies; 3+ messages in thread
From: abenson @ 2021-02-22 17:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

There is a new pull request by abenson against master on the void-packages repository

https://github.com/abenson/void-packages np_spotifyqt
https://github.com/void-linux/void-packages/pull/28978

New package: spotify-qt-3.4
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28978.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-np_spotifyqt-28978.patch --]
[-- Type: text/x-diff, Size: 2307 bytes --]

From b7c29f312adc0aee85df5f3e72b9e0e47de0d515 Mon Sep 17 00:00:00 2001
From: Andrew Benson <abenson+void@gmail.com>
Date: Mon, 22 Feb 2021 11:11:07 -0600
Subject: [PATCH] New package: spotify-qt-3.4

---
 .../patches/fix-darkmode-toggle.patch         | 26 +++++++++++++++++++
 srcpkgs/spotify-qt/template                   | 13 ++++++++++
 2 files changed, 39 insertions(+)
 create mode 100644 srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
 create mode 100644 srcpkgs/spotify-qt/template

diff --git a/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch b/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
new file mode 100644
index 00000000000..dd63a2d4a45
--- /dev/null
+++ b/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
@@ -0,0 +1,26 @@
+https://github.com/kraxarn/spotify-qt/commit/fe916f8976cca3983030e24d02d65e62893ad88d.patch
+
+From fe916f8976cca3983030e24d02d65e62893ad88d Mon Sep 17 00:00:00 2001
+From: kraxarn <me@kraxarn.com>
+Date: Sun, 7 Feb 2021 22:02:21 +0100
+Subject: [PATCH] Fix crash when toggling dark theme
+
+---
+ src/settingspage/interfacepage.cpp | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git src/settingspage/interfacepage.cpp src/settingspage/interfacepage.cpp
+index d809730..be16455 100644
+--- src/settingspage/interfacepage.cpp
++++ src/settingspage/interfacepage.cpp
+@@ -215,7 +215,9 @@ void InterfacePage::darkThemeToggle(bool checked)
+ 	if (checked)
+ 	{
+ 		itfStyle->setCurrentText("Fusion");
+-		itfIcFallback->setChecked(true);
++
++		if (itfIcFallback != nullptr)
++			itfIcFallback->setChecked(true);
+ 	}
+ 	else
+ 	{
diff --git a/srcpkgs/spotify-qt/template b/srcpkgs/spotify-qt/template
new file mode 100644
index 00000000000..001b427caf4
--- /dev/null
+++ b/srcpkgs/spotify-qt/template
@@ -0,0 +1,13 @@
+# Template file for 'spotify-qt'
+pkgname=spotify-qt
+version=3.4
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt5-devel"
+makedepends="qt5-devel qt5-svg-devel"
+short_desc="Lightweight Spotify client using Qt"
+maintainer="Andrew Benson <abenson+void@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/kraxarn/spotify-qt"
+distfiles="https://github.com/kraxarn/spotify-qt/archive/v${version}.tar.gz"
+checksum=ceae5dec3aa31a3fbf6754a2c481dfc1b32b9f5e131007ec176f64a87a6e516e

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Updated] New package: spotify-qt-3.4
  2021-02-22 17:11 [PR PATCH] New package: spotify-qt-3.4 abenson
@ 2021-02-22 17:45 ` abenson
  2021-02-22 18:43 ` [PR PATCH] [Merged]: " abenson
  1 sibling, 0 replies; 3+ messages in thread
From: abenson @ 2021-02-22 17:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

There is an updated pull request by abenson against master on the void-packages repository

https://github.com/abenson/void-packages np_spotifyqt
https://github.com/void-linux/void-packages/pull/28978

New package: spotify-qt-3.4
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28978.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-np_spotifyqt-28978.patch --]
[-- Type: text/x-diff, Size: 2281 bytes --]

From b6afeaf7ff299e1b5c40f80556c4e90e6fe38036 Mon Sep 17 00:00:00 2001
From: Andrew Benson <abenson+void@gmail.com>
Date: Mon, 22 Feb 2021 11:11:07 -0600
Subject: [PATCH] New package: spotify-qt-3.4

---
 .../patches/fix-darkmode-toggle.patch         | 26 +++++++++++++++++++
 srcpkgs/spotify-qt/template                   | 13 ++++++++++
 2 files changed, 39 insertions(+)
 create mode 100644 srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
 create mode 100644 srcpkgs/spotify-qt/template

diff --git a/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch b/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
new file mode 100644
index 00000000000..dd63a2d4a45
--- /dev/null
+++ b/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
@@ -0,0 +1,26 @@
+https://github.com/kraxarn/spotify-qt/commit/fe916f8976cca3983030e24d02d65e62893ad88d.patch
+
+From fe916f8976cca3983030e24d02d65e62893ad88d Mon Sep 17 00:00:00 2001
+From: kraxarn <me@kraxarn.com>
+Date: Sun, 7 Feb 2021 22:02:21 +0100
+Subject: [PATCH] Fix crash when toggling dark theme
+
+---
+ src/settingspage/interfacepage.cpp | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git src/settingspage/interfacepage.cpp src/settingspage/interfacepage.cpp
+index d809730..be16455 100644
+--- src/settingspage/interfacepage.cpp
++++ src/settingspage/interfacepage.cpp
+@@ -215,7 +215,9 @@ void InterfacePage::darkThemeToggle(bool checked)
+ 	if (checked)
+ 	{
+ 		itfStyle->setCurrentText("Fusion");
+-		itfIcFallback->setChecked(true);
++
++		if (itfIcFallback != nullptr)
++			itfIcFallback->setChecked(true);
+ 	}
+ 	else
+ 	{
diff --git a/srcpkgs/spotify-qt/template b/srcpkgs/spotify-qt/template
new file mode 100644
index 00000000000..ce964a0b71a
--- /dev/null
+++ b/srcpkgs/spotify-qt/template
@@ -0,0 +1,13 @@
+# Template file for 'spotify-qt'
+pkgname=spotify-qt
+version=3.4
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config qt5-devel"
+makedepends="qt5-devel qt5-svg-devel"
+short_desc="Lightweight Spotify client using Qt"
+maintainer="Andrew Benson <abenson+void@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/kraxarn/spotify-qt"
+distfiles="${homepage}/archive/v${version}.tar.gz"
+checksum=ceae5dec3aa31a3fbf6754a2c481dfc1b32b9f5e131007ec176f64a87a6e516e

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: New package: spotify-qt-3.4
  2021-02-22 17:11 [PR PATCH] New package: spotify-qt-3.4 abenson
  2021-02-22 17:45 ` [PR PATCH] [Updated] " abenson
@ 2021-02-22 18:43 ` abenson
  1 sibling, 0 replies; 3+ messages in thread
From: abenson @ 2021-02-22 18:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

There's a merged pull request on the void-packages repository

New package: spotify-qt-3.4
https://github.com/void-linux/void-packages/pull/28978

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [X] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-22 18:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 17:11 [PR PATCH] New package: spotify-qt-3.4 abenson
2021-02-22 17:45 ` [PR PATCH] [Updated] " abenson
2021-02-22 18:43 ` [PR PATCH] [Merged]: " abenson

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git