Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] giac does not support arbitrary precision floating point
@ 2021-02-23  3:45 tornaria
  2021-02-23  4:02 ` ericonr
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: tornaria @ 2021-02-23  3:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

New issue by tornaria on void-packages repository

https://github.com/void-linux/void-packages/issues/28989

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname:  Void 5.4.99_1 x86_64 GenuineIntel uptodate FF
* package:  giac-1.5.0.87_3

### Expected behavior
Can choose arbitrary floating point precision:
```
$ giac
[...]
0>> Digits:=30
30
// Time 0
1>> evalf(pi)
3.14159265358979323846264338328
// Time 0
2>>
```

### Actual behavior
Floating point precision is capped at 13 (i.e. double precision, 53 bits)
```
$ giac
[...]
0>> Digits:=30
13
// Time 0
1>> evalf(pi)
3.14159265359
// Time 0
```

### Proposed fix

Add `libmpfr-devel` to `makedepends`.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: giac does not support arbitrary precision floating point
  2021-02-23  3:45 [ISSUE] giac does not support arbitrary precision floating point tornaria
@ 2021-02-23  4:02 ` ericonr
  2021-02-23 15:20 ` tornaria
  2021-02-24 10:07 ` dkwo
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-02-23  4:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/28989#issuecomment-783861255

Comment:
Hi! That sounds like a reasonable change! Would you like to make a PR for it?


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: giac does not support arbitrary precision floating point
  2021-02-23  3:45 [ISSUE] giac does not support arbitrary precision floating point tornaria
  2021-02-23  4:02 ` ericonr
@ 2021-02-23 15:20 ` tornaria
  2021-02-24 10:07 ` dkwo
  2 siblings, 0 replies; 4+ messages in thread
From: tornaria @ 2021-02-23 15:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/issues/28989#issuecomment-784277765

Comment:
While doing that I run `xbps-src check` and found that several tests fail, revealing that other dependencies are missing:
- in the current version: 12 tests fail
- adding `mpfr-devel` to `makedepends`: 9 tests fail
- adding also `pari-devel`: 2 tests fail
- adding a patch found in [`sagemath`](https://trac.sagemath.org/ticket/25567#comment:41): 1 tests fail
I wasn't able to get rid of the last fail (a segmentation fault).

Should I do all of that in a single PR, or split?

Comments:
- For the remaining test failure, I will open another issue. I should point out that `sagemath` compiles giac (I think the same version as in void) and that one does NOT have the segfault so this might be worth looking into.
- There are more (optional?) dependencies for giac, some of them are available in void, namely: `libao-devel libsamplerate-devel libcurl-devel libICE-devel glpk-devel gmpxx-devel ecm-devel`. If adding them to `makedepends`, they are found by configure, but they don't affect tests. I'm not sure if I should also add those dependencies or not. In case of doubt, I'll stick to the changes described above (mpfr and pari)
- For the record, other (optional?) dependencies not available in void are `mpfi ntl CoCoA nauty`
- I'm not a direct user of `giac`, but I would like to package `sagemath` or at least make it easy to compile with as many system packages as possible. The original issue was caught by running sage tests.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: giac does not support arbitrary precision floating point
  2021-02-23  3:45 [ISSUE] giac does not support arbitrary precision floating point tornaria
  2021-02-23  4:02 ` ericonr
  2021-02-23 15:20 ` tornaria
@ 2021-02-24 10:07 ` dkwo
  2 siblings, 0 replies; 4+ messages in thread
From: dkwo @ 2021-02-24 10:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/issues/28989#issuecomment-784962036

Comment:
@tornaria I'm interested in helping with sage/giac, see also #19090 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-24 10:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23  3:45 [ISSUE] giac does not support arbitrary precision floating point tornaria
2021-02-23  4:02 ` ericonr
2021-02-23 15:20 ` tornaria
2021-02-24 10:07 ` dkwo

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git