Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pari: add to checkdepends and common/shlibs
@ 2021-03-01 13:33 tornaria
  2021-03-01 13:50 ` Duncaen
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: tornaria @ 2021-03-01 13:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1780 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages pari
https://github.com/void-linux/void-packages/pull/29159

pari: add to checkdepends and common/shlibs
- Some tests depend on data packages, add them to checkdepends.
- libpari-gmp.so.7 was missing in common/shlibs

No revbump since these changes don't affect compilation.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29159.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pari-29159.patch --]
[-- Type: text/x-diff, Size: 1352 bytes --]

From 140f8af3bc22ec23f905bba47ed4c063bcf7cb96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 1 Mar 2021 10:25:33 -0300
Subject: [PATCH] pari: add to checkdepends and common/shlibs

- Some tests depend on data packages, add them to checkdepends.
- libpari-gmp.so.7 was missing in common/shlibs

No revbump since these changes don't affect compilation.
---
 common/shlibs         | 1 +
 srcpkgs/pari/template | 1 +
 2 files changed, 2 insertions(+)

diff --git a/common/shlibs b/common/shlibs
index 858957c29f7..eaaac6341dc 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3924,3 +3924,4 @@ libsimavr.so.1 simavr-1.6_2
 libsimavrparts.so.1 simavr-1.6_2
 libsword-1.8.1.so libsword-1.8.1_6
 libtree-sitter.so.0 tree-sitter-0.18.2_1
+libpari-gmp.so.7 pari-2.13.0_1
diff --git a/srcpkgs/pari/template b/srcpkgs/pari/template
index 8e2a415913b..e448a225fb0 100644
--- a/srcpkgs/pari/template
+++ b/srcpkgs/pari/template
@@ -10,6 +10,7 @@ make_build_target=all
 make_check_target=test-all
 hostmakedepends="perl texlive"
 makedepends="gmp-devel readline-devel $(vopt_if x11 libX11-devel)"
+checkdepends="pari-elldata pari-seadata pari-galdata pari-galpol"
 short_desc="Fast computations library in number theory"
 maintainer="Đoàn Trần Công Danh <congdanhqx@gmail.com>"
 license="GPL-2.0-or-later"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: pari: add to checkdepends and common/shlibs
  2021-03-01 13:33 [PR PATCH] pari: add to checkdepends and common/shlibs tornaria
@ 2021-03-01 13:50 ` Duncaen
  2021-03-01 14:12 ` tornaria
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2021-03-01 13:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/29159#issuecomment-787963341

Comment:
This introduces a cycle when building packages with checks enabled.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: pari: add to checkdepends and common/shlibs
  2021-03-01 13:33 [PR PATCH] pari: add to checkdepends and common/shlibs tornaria
  2021-03-01 13:50 ` Duncaen
@ 2021-03-01 14:12 ` tornaria
  2021-03-01 14:24 ` Duncaen
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: tornaria @ 2021-03-01 14:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/29159#issuecomment-787979344

Comment:
> This introduces a cycle when building packages with checks enabled.

It does? Why?

The data packages do not depend on `pari` to build or check. In fact, the data packages are just (mostly) text files with precomputed data.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: pari: add to checkdepends and common/shlibs
  2021-03-01 13:33 [PR PATCH] pari: add to checkdepends and common/shlibs tornaria
  2021-03-01 13:50 ` Duncaen
  2021-03-01 14:12 ` tornaria
@ 2021-03-01 14:24 ` Duncaen
  2021-03-01 14:27 ` tornaria
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2021-03-01 14:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/29159#issuecomment-787987475

Comment:
They have a runtime dependency on pari, xbps-src requires all dependencies, including runtime dependencies to be build before building the package (this simplifies the build process, each package that has been build is installable).

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: pari: add to checkdepends and common/shlibs
  2021-03-01 13:33 [PR PATCH] pari: add to checkdepends and common/shlibs tornaria
                   ` (2 preceding siblings ...)
  2021-03-01 14:24 ` Duncaen
@ 2021-03-01 14:27 ` tornaria
  2021-03-01 14:33 ` Duncaen
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: tornaria @ 2021-03-01 14:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/29159#issuecomment-787989385

Comment:
I see what happens: runtime dependencies are built by xbps-src _before_ the package is built.

Would it make sense to change this so that _runtime_ dependencies are built _after_ the package?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: pari: add to checkdepends and common/shlibs
  2021-03-01 13:33 [PR PATCH] pari: add to checkdepends and common/shlibs tornaria
                   ` (3 preceding siblings ...)
  2021-03-01 14:27 ` tornaria
@ 2021-03-01 14:33 ` Duncaen
  2021-03-01 14:34 ` Duncaen
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2021-03-01 14:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/29159#issuecomment-787994425

Comment:
You would end up with packages in the repository that can not be installed in case the runtime dependency failed to build after the package depending on it and you would have to build a mechanism to avoid that by i.e. holding back the package from adding it to the repository and adding it later, which gets pretty complicated if have long dependency chains.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: pari: add to checkdepends and common/shlibs
  2021-03-01 13:33 [PR PATCH] pari: add to checkdepends and common/shlibs tornaria
                   ` (4 preceding siblings ...)
  2021-03-01 14:33 ` Duncaen
@ 2021-03-01 14:34 ` Duncaen
  2021-03-01 15:02 ` sgn
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2021-03-01 14:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/29159#issuecomment-787994425

Comment:
You would end up with packages in the repository that can not be installed in case the runtime dependency failed to build after the package depending on it and you would have to build a mechanism to avoid that by i.e. holding back the packages with missing dependency from being added to the repository and then adding it later, which gets pretty complicated if have long dependency chains.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: pari: add to checkdepends and common/shlibs
  2021-03-01 13:33 [PR PATCH] pari: add to checkdepends and common/shlibs tornaria
                   ` (5 preceding siblings ...)
  2021-03-01 14:34 ` Duncaen
@ 2021-03-01 15:02 ` sgn
  2021-03-01 16:43 ` dkwo
  2021-04-07  2:00 ` [PR PATCH] [Closed]: " tornaria
  8 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2021-03-01 15:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29159#issuecomment-788016646

Comment:
> libpari-gmp.so.7 was missing in common/shlibs

Nothing requires it hence it was omitted.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: pari: add to checkdepends and common/shlibs
  2021-03-01 13:33 [PR PATCH] pari: add to checkdepends and common/shlibs tornaria
                   ` (6 preceding siblings ...)
  2021-03-01 15:02 ` sgn
@ 2021-03-01 16:43 ` dkwo
  2021-04-07  2:00 ` [PR PATCH] [Closed]: " tornaria
  8 siblings, 0 replies; 10+ messages in thread
From: dkwo @ 2021-03-01 16:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/29159#issuecomment-788095183

Comment:
For this specific case, would it make sense then to remove `depends="pari"` from the packages mentioned, considering they are just sets of data?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Closed]: pari: add to checkdepends and common/shlibs
  2021-03-01 13:33 [PR PATCH] pari: add to checkdepends and common/shlibs tornaria
                   ` (7 preceding siblings ...)
  2021-03-01 16:43 ` dkwo
@ 2021-04-07  2:00 ` tornaria
  8 siblings, 0 replies; 10+ messages in thread
From: tornaria @ 2021-04-07  2:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]

There's a closed pull request on the void-packages repository

pari: add to checkdepends and common/shlibs
https://github.com/void-linux/void-packages/pull/29159

Description:
- Some tests depend on data packages, add them to checkdepends.
- libpari-gmp.so.7 was missing in common/shlibs

No revbump since these changes don't affect compilation.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-04-07  2:00 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 13:33 [PR PATCH] pari: add to checkdepends and common/shlibs tornaria
2021-03-01 13:50 ` Duncaen
2021-03-01 14:12 ` tornaria
2021-03-01 14:24 ` Duncaen
2021-03-01 14:27 ` tornaria
2021-03-01 14:33 ` Duncaen
2021-03-01 14:34 ` Duncaen
2021-03-01 15:02 ` sgn
2021-03-01 16:43 ` dkwo
2021-04-07  2:00 ` [PR PATCH] [Closed]: " tornaria

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).