Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] fzf: update and cleanup post_install()
@ 2021-03-05 18:24 m3tav3rse
  2021-03-05 18:33 ` [PR PATCH] [Updated] " m3tav3rse
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: m3tav3rse @ 2021-03-05 18:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

There is a new pull request by m3tav3rse against master on the void-packages repository

https://github.com/m3tav3rse/void-packages fzf-completions
https://github.com/void-linux/void-packages/pull/29259

fzf: update and cleanup post_install()
Added missing manpage for fzf-tmux, removed unused sed line, installed completion by default.

A patch file from https://github.com/void-linux/void-packages/pull/29259.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fzf-completions-29259.patch --]
[-- Type: text/x-diff, Size: 1630 bytes --]

From 6eee1b797b1d95d69a088a0ad90563c0e5eb1a4c Mon Sep 17 00:00:00 2001
From: m3tav3rse <mtvrs@tuta.io>
Date: Fri, 5 Mar 2021 19:04:23 +0100
Subject: [PATCH] fzf: update and cleanup post_install()

---
 srcpkgs/fzf/template | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/fzf/template b/srcpkgs/fzf/template
index b0b841a7a6a..5a33a98e1cb 100644
--- a/srcpkgs/fzf/template
+++ b/srcpkgs/fzf/template
@@ -1,7 +1,7 @@
 # Template file for 'fzf'
 pkgname=fzf
 version=0.25.1
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/junegunn/fzf"
 hostmakedepends="git"
@@ -18,14 +18,19 @@ post_install() {
 	cd ${wrksrc}
 	vbin bin/fzf-tmux
 	vman man/man1/fzf.1
+	vman man/man1/fzf-tmux.1
 	vlicense LICENSE
 
-	sed -i -e 's#source ~/\.fzf\.bash; ##' shell/key-bindings.bash
 	vinstall plugin/fzf.vim 644 usr/share/vim/vimfiles/plugin
+	vinstall doc/fzf.txt 644 usr/share/vim/vimfiles/doc
+
 	vinstall plugin/fzf.vim 644 usr/share/nvim/runtime/plugin
-	vinstall shell/completion.bash 644 usr/share/doc/fzf
-	vinstall shell/completion.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.bash 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.fish 644 usr/share/doc/fzf
+	vinstall doc/fzf.txt 644 usr/share/nvim/runtime/doc
+	
+	vcompletion shell/completion.bash bash
+	vcompletion shell/completion.zsh zsh
+	
+	vinstall shell/key-bindings.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.bash 644 usr/share/fzf
+	vinstall shell/key-bindings.fish 644 usr/share/fish/vendor_functions.d fzf_key_bindings.fish
 }

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] fzf: update and cleanup post_install()
  2021-03-05 18:24 [PR PATCH] fzf: update and cleanup post_install() m3tav3rse
@ 2021-03-05 18:33 ` m3tav3rse
  2021-03-08  3:06 ` ericonr
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: m3tav3rse @ 2021-03-05 18:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

There is an updated pull request by m3tav3rse against master on the void-packages repository

https://github.com/m3tav3rse/void-packages fzf-completions
https://github.com/void-linux/void-packages/pull/29259

fzf: update and cleanup post_install()
Added missing manpage for fzf-tmux, removed unused sed line, installed completion by default.

A patch file from https://github.com/void-linux/void-packages/pull/29259.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fzf-completions-29259.patch --]
[-- Type: text/x-diff, Size: 1628 bytes --]

From ceb85a3a001c98bea2dff0d5f9efc4895b2f40f9 Mon Sep 17 00:00:00 2001
From: m3tav3rse <mtvrs@tuta.io>
Date: Fri, 5 Mar 2021 19:04:23 +0100
Subject: [PATCH] fzf: update and cleanup post_install()

---
 srcpkgs/fzf/template | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/fzf/template b/srcpkgs/fzf/template
index b0b841a7a6a..3c7ee110fdf 100644
--- a/srcpkgs/fzf/template
+++ b/srcpkgs/fzf/template
@@ -1,7 +1,7 @@
 # Template file for 'fzf'
 pkgname=fzf
 version=0.25.1
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/junegunn/fzf"
 hostmakedepends="git"
@@ -18,14 +18,19 @@ post_install() {
 	cd ${wrksrc}
 	vbin bin/fzf-tmux
 	vman man/man1/fzf.1
+	vman man/man1/fzf-tmux.1
 	vlicense LICENSE
 
-	sed -i -e 's#source ~/\.fzf\.bash; ##' shell/key-bindings.bash
 	vinstall plugin/fzf.vim 644 usr/share/vim/vimfiles/plugin
+	vinstall doc/fzf.txt 644 usr/share/vim/vimfiles/doc
+
 	vinstall plugin/fzf.vim 644 usr/share/nvim/runtime/plugin
-	vinstall shell/completion.bash 644 usr/share/doc/fzf
-	vinstall shell/completion.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.bash 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.fish 644 usr/share/doc/fzf
+	vinstall doc/fzf.txt 644 usr/share/nvim/runtime/doc
+
+	vcompletion shell/completion.bash bash
+	vcompletion shell/completion.zsh zsh
+
+	vinstall shell/key-bindings.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.bash 644 usr/share/fzf
+	vinstall shell/key-bindings.fish 644 usr/share/fish/vendor_functions.d fzf_key_bindings.fish
 }

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: fzf: update and cleanup post_install()
  2021-03-05 18:24 [PR PATCH] fzf: update and cleanup post_install() m3tav3rse
  2021-03-05 18:33 ` [PR PATCH] [Updated] " m3tav3rse
@ 2021-03-08  3:06 ` ericonr
  2021-03-08 13:05 ` [PR PATCH] [Updated] fzf: " m3tav3rse
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-03-08  3:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29259#issuecomment-792427925

Comment:
The commit message is a bit misleading, you aren't updating the package.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] fzf: cleanup post_install()
  2021-03-05 18:24 [PR PATCH] fzf: update and cleanup post_install() m3tav3rse
  2021-03-05 18:33 ` [PR PATCH] [Updated] " m3tav3rse
  2021-03-08  3:06 ` ericonr
@ 2021-03-08 13:05 ` m3tav3rse
  2021-03-08 14:01 ` m3tav3rse
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: m3tav3rse @ 2021-03-08 13:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

There is an updated pull request by m3tav3rse against master on the void-packages repository

https://github.com/m3tav3rse/void-packages fzf-completions
https://github.com/void-linux/void-packages/pull/29259

fzf: cleanup post_install()
Added missing manpage for fzf-tmux, removed unused sed line, installed completion by default.

A patch file from https://github.com/void-linux/void-packages/pull/29259.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fzf-completions-29259.patch --]
[-- Type: text/x-diff, Size: 1617 bytes --]

From 104f89a845e2dd64e8c9ac9d883d98ae43bc53cc Mon Sep 17 00:00:00 2001
From: m3tav3rse <mtvrs@tuta.io>
Date: Fri, 5 Mar 2021 19:04:23 +0100
Subject: [PATCH] fzf: cleanup post_install()

---
 srcpkgs/fzf/template | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/fzf/template b/srcpkgs/fzf/template
index b0b841a7a6a..3c7ee110fdf 100644
--- a/srcpkgs/fzf/template
+++ b/srcpkgs/fzf/template
@@ -1,7 +1,7 @@
 # Template file for 'fzf'
 pkgname=fzf
 version=0.25.1
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/junegunn/fzf"
 hostmakedepends="git"
@@ -18,14 +18,19 @@ post_install() {
 	cd ${wrksrc}
 	vbin bin/fzf-tmux
 	vman man/man1/fzf.1
+	vman man/man1/fzf-tmux.1
 	vlicense LICENSE
 
-	sed -i -e 's#source ~/\.fzf\.bash; ##' shell/key-bindings.bash
 	vinstall plugin/fzf.vim 644 usr/share/vim/vimfiles/plugin
+	vinstall doc/fzf.txt 644 usr/share/vim/vimfiles/doc
+
 	vinstall plugin/fzf.vim 644 usr/share/nvim/runtime/plugin
-	vinstall shell/completion.bash 644 usr/share/doc/fzf
-	vinstall shell/completion.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.bash 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.fish 644 usr/share/doc/fzf
+	vinstall doc/fzf.txt 644 usr/share/nvim/runtime/doc
+
+	vcompletion shell/completion.bash bash
+	vcompletion shell/completion.zsh zsh
+
+	vinstall shell/key-bindings.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.bash 644 usr/share/fzf
+	vinstall shell/key-bindings.fish 644 usr/share/fish/vendor_functions.d fzf_key_bindings.fish
 }

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: fzf: cleanup post_install()
  2021-03-05 18:24 [PR PATCH] fzf: update and cleanup post_install() m3tav3rse
                   ` (2 preceding siblings ...)
  2021-03-08 13:05 ` [PR PATCH] [Updated] fzf: " m3tav3rse
@ 2021-03-08 14:01 ` m3tav3rse
  2021-03-15  8:18 ` [PR PATCH] [Updated] " m3tav3rse
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: m3tav3rse @ 2021-03-08 14:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by m3tav3rse on void-packages repository

https://github.com/void-linux/void-packages/pull/29259#issuecomment-792775041

Comment:
I changed the title but I'm bad at naming thins.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] fzf: cleanup post_install()
  2021-03-05 18:24 [PR PATCH] fzf: update and cleanup post_install() m3tav3rse
                   ` (3 preceding siblings ...)
  2021-03-08 14:01 ` m3tav3rse
@ 2021-03-15  8:18 ` m3tav3rse
  2021-04-06 16:36 ` FollieHiyuki
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: m3tav3rse @ 2021-03-15  8:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

There is an updated pull request by m3tav3rse against master on the void-packages repository

https://github.com/m3tav3rse/void-packages fzf-completions
https://github.com/void-linux/void-packages/pull/29259

fzf: cleanup post_install()
Added missing manpage for fzf-tmux, removed unused sed line, installed completion by default.

A patch file from https://github.com/void-linux/void-packages/pull/29259.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fzf-completions-29259.patch --]
[-- Type: text/x-diff, Size: 1619 bytes --]

From 868ab4656a82d5ecb9e8e13127c8f9f8f7f57b1d Mon Sep 17 00:00:00 2001
From: m3tav3rse <mtvrs@tuta.io>
Date: Fri, 5 Mar 2021 19:04:23 +0100
Subject: [PATCH] fzf: cleanup post_install()

---
 srcpkgs/fzf/template | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/fzf/template b/srcpkgs/fzf/template
index a3c30e7a3895..809af43bacd8 100644
--- a/srcpkgs/fzf/template
+++ b/srcpkgs/fzf/template
@@ -1,7 +1,7 @@
 # Template file for 'fzf'
 pkgname=fzf
 version=0.26.0
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/junegunn/fzf"
 hostmakedepends="git"
@@ -18,14 +18,19 @@ post_install() {
 	cd ${wrksrc}
 	vbin bin/fzf-tmux
 	vman man/man1/fzf.1
+	vman man/man1/fzf-tmux.1
 	vlicense LICENSE
 
-	sed -i -e 's#source ~/\.fzf\.bash; ##' shell/key-bindings.bash
 	vinstall plugin/fzf.vim 644 usr/share/vim/vimfiles/plugin
+	vinstall doc/fzf.txt 644 usr/share/vim/vimfiles/doc
+
 	vinstall plugin/fzf.vim 644 usr/share/nvim/runtime/plugin
-	vinstall shell/completion.bash 644 usr/share/doc/fzf
-	vinstall shell/completion.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.bash 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.fish 644 usr/share/doc/fzf
+	vinstall doc/fzf.txt 644 usr/share/nvim/runtime/doc
+
+	vcompletion shell/completion.bash bash
+	vcompletion shell/completion.zsh zsh
+
+	vinstall shell/key-bindings.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.bash 644 usr/share/fzf
+	vinstall shell/key-bindings.fish 644 usr/share/fish/vendor_functions.d fzf_key_bindings.fish
 }

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: fzf: cleanup post_install()
  2021-03-05 18:24 [PR PATCH] fzf: update and cleanup post_install() m3tav3rse
                   ` (4 preceding siblings ...)
  2021-03-15  8:18 ` [PR PATCH] [Updated] " m3tav3rse
@ 2021-04-06 16:36 ` FollieHiyuki
  2021-04-06 16:46 ` FollieHiyuki
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: FollieHiyuki @ 2021-04-06 16:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29259#issuecomment-814264078

Comment:
Just bumped into this PR.
The "completions" should not be installed by default since they collapse some keybindings with shell (at least with `fish` emacs key bindings). And they are not actually command completions, but rather functions bound into key binds.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: fzf: cleanup post_install()
  2021-03-05 18:24 [PR PATCH] fzf: update and cleanup post_install() m3tav3rse
                   ` (5 preceding siblings ...)
  2021-04-06 16:36 ` FollieHiyuki
@ 2021-04-06 16:46 ` FollieHiyuki
  2021-04-06 16:55 ` FollieHiyuki
  2021-04-07 10:10 ` [PR PATCH] [Closed]: " m3tav3rse
  8 siblings, 0 replies; 10+ messages in thread
From: FollieHiyuki @ 2021-04-06 16:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29259#issuecomment-814264078

Comment:
Just bumped into this PR.
The "completions" should not be installed by default. Same go for the key bindings, they collapse with default one of the shells (at least with `fish` emacs key bindings).

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: fzf: cleanup post_install()
  2021-03-05 18:24 [PR PATCH] fzf: update and cleanup post_install() m3tav3rse
                   ` (6 preceding siblings ...)
  2021-04-06 16:46 ` FollieHiyuki
@ 2021-04-06 16:55 ` FollieHiyuki
  2021-04-07 10:10 ` [PR PATCH] [Closed]: " m3tav3rse
  8 siblings, 0 replies; 10+ messages in thread
From: FollieHiyuki @ 2021-04-06 16:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29259#issuecomment-814264078

Comment:
Just bumped into this PR.
The "completions" should not be installed by default. Same go for the key bindings, they collapse with default one of the shells (at least with `fish` emacs key bindings).
I added some of your changes to my updating PR #30050

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Closed]: fzf: cleanup post_install()
  2021-03-05 18:24 [PR PATCH] fzf: update and cleanup post_install() m3tav3rse
                   ` (7 preceding siblings ...)
  2021-04-06 16:55 ` FollieHiyuki
@ 2021-04-07 10:10 ` m3tav3rse
  8 siblings, 0 replies; 10+ messages in thread
From: m3tav3rse @ 2021-04-07 10:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

There's a closed pull request on the void-packages repository

fzf: cleanup post_install()
https://github.com/void-linux/void-packages/pull/29259

Description:
Added missing manpage for fzf-tmux, removed unused sed line, installed completion by default.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-04-07 10:10 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 18:24 [PR PATCH] fzf: update and cleanup post_install() m3tav3rse
2021-03-05 18:33 ` [PR PATCH] [Updated] " m3tav3rse
2021-03-08  3:06 ` ericonr
2021-03-08 13:05 ` [PR PATCH] [Updated] fzf: " m3tav3rse
2021-03-08 14:01 ` m3tav3rse
2021-03-15  8:18 ` [PR PATCH] [Updated] " m3tav3rse
2021-04-06 16:36 ` FollieHiyuki
2021-04-06 16:46 ` FollieHiyuki
2021-04-06 16:55 ` FollieHiyuki
2021-04-07 10:10 ` [PR PATCH] [Closed]: " m3tav3rse

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git