[PR PATCH] nnn: update to 3.6.

[PR PATCH] nnn: update to 3.6.

[UsernameRandomlyGenerated]

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

There is a new pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages nnn36
https://github.com/void-linux/void-packages/pull/29533

nnn: update to 3.6.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29533.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nnn36-29533.patch --]
[-- Type: text/x-diff, Size: 1048 bytes --]

From ddf950106aa80fcf5cee278f838c0f7cf6bee9d5 Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Wed, 17 Mar 2021 15:46:13 +0100
Subject: [PATCH] nnn: update to 3.6.

---
 srcpkgs/nnn/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index ba12cad5ee51..704b749716e6 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -1,6 +1,6 @@
 # Template file for 'nnn'
 pkgname=nnn
-version=3.5
+version=3.6
 revision=1
 build_style=gnu-makefile
 hostmakedepends="pkg-config"
@@ -11,7 +11,7 @@ license="BSD-2-Clause"
 homepage="https://github.com/jarun/nnn"
 changelog="https://raw.githubusercontent.com/jarun/nnn/master/CHANGELOG"
 distfiles="https://github.com/jarun/nnn/archive/v${version}.tar.gz"
-checksum=e636d4035499a112a0ad33f1557838132ed2e39d8857c5b219714fe9f64681f3
+checksum=875094caebcc22ecf53b3722d139b127d25e1d5563a954342f32ded8980978b5
 
 post_install() {
 	vinstall misc/auto-completion/bash/nnn-completion.bash 644 \

Re: nnn: update to 3.6.

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-801154334

Comment:
Would it be possible to split `nnn` into 3 packages to support icons?
Like so: `nnn`, `nnn-nerd` and `nnn-icons`. Just different flags when compiling

Re: nnn: update to 3.6.

[UsernameRandomlyGenerated]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

New comment by UsernameRandomlyGenerated on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-801168159

Comment:
> Would it be possible to split `nnn` into 3 packages to support icons?
> Like so: `nnn`, `nnn-nerd` and `nnn-icons`. Just different flags when compiling

I think it should be up to maintainer, but in my opinion I think enabling icons by default is better than splitting package, as it's just a flag that doesn't require any new dependencies by itself.

Re: nnn: update to 3.6.

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-801175464

Comment:
> I think it should be up to maintainer, but in my opinion I think enabling icons by default is better than splitting package, as it's just a flag that doesn't require any new dependencies by itself.

I suggest we do like those `emacs` packages.

Any way the flags are `O_ICONS=1` (use `icons-in-terminal` dependency) and `O_NERD=1` (need a nerd font). I think they are conflicting, hence icons is not enable in default build.

Re: nnn: update to 3.6.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-801444101

Comment:
>I think it should be up to maintainer

The maintainer isn't maintaining the package :D you can adopt or orphan it

Re: nnn: update to 3.6.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-801445371

Comment:
> Would it be possible to split `nnn` into 3 packages to support icons?
> Like so: `nnn`, `nnn-nerd` and `nnn-icons`. Just different flags when compiling

I would prefer `build_options`

Re: nnn: update to 3.6.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-801518484

Comment:
What happens if ICONS is enabled but not available? If nothing broken, just enable it unconditionally.
Anyway, please disable `-O3` (`CFLAGS_OPTIMIZATION=-O2`)

Re: nnn: update to 3.6.

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-802313626

Comment:
Oh we don't have `icons-in-terminal` in the repo, so just go with the "using Nerd font" option. I will try to see whether enabling the feature without having a patched font works

Re: nnn: update to 3.6.

[UsernameRandomlyGenerated]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by UsernameRandomlyGenerated on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-803300380

Comment:
Please check it if you can, you can also take over updating if you want, I'm on limited data so downloading huge nerd font for tests is impossible for me right now.

Re: nnn: update to 3.6.

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-803324626

Comment:
@UsernameRandomlyGenerated you don't need to download the whole package. Downloading 1 font from their github is enough.
Anyways, if icons is enabled without setting your terminal font to a Nerd font, `nnn` will try to find the glyphs with other fonts, and the icons will look weird.
So if we go with the `build_options`, disable icons by default. I still want a separated package though.

Re: [PR PATCH] [Closed]: nnn: update to 3.6.

[UsernameRandomlyGenerated]

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]

There's a closed pull request on the void-packages repository

nnn: update to 3.6.
https://github.com/void-linux/void-packages/pull/29533

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: nnn: update to 3.6.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-809667351

Comment:
Why hasn't this been merged? The fonts are in no relation to the update...

Re: nnn: update to 3.6.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/29533#issuecomment-809667351

Comment:
Why hasn't this been merged? The fonts are in no relation to the update...

[PR PATCH] nnn: update to 3.6.

[ailiop-git]

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

There is a new pull request by ailiop-git against master on the void-packages repository

https://github.com/ailiop-git/void-packages nnn
https://github.com/void-linux/void-packages/pull/29614

nnn: update to 3.6.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29614.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nnn-29614.patch --]
[-- Type: text/x-diff, Size: 1037 bytes --]

From a954a44e384b086f446b5fedf878ca14fb057382 Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Sat, 20 Mar 2021 13:02:17 +0100
Subject: [PATCH] nnn: update to 3.6.

---
 srcpkgs/nnn/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index ba12cad5ee51..704b749716e6 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -1,6 +1,6 @@
 # Template file for 'nnn'
 pkgname=nnn
-version=3.5
+version=3.6
 revision=1
 build_style=gnu-makefile
 hostmakedepends="pkg-config"
@@ -11,7 +11,7 @@ license="BSD-2-Clause"
 homepage="https://github.com/jarun/nnn"
 changelog="https://raw.githubusercontent.com/jarun/nnn/master/CHANGELOG"
 distfiles="https://github.com/jarun/nnn/archive/v${version}.tar.gz"
-checksum=e636d4035499a112a0ad33f1557838132ed2e39d8857c5b219714fe9f64681f3
+checksum=875094caebcc22ecf53b3722d139b127d25e1d5563a954342f32ded8980978b5
 
 post_install() {
 	vinstall misc/auto-completion/bash/nnn-completion.bash 644 \