Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Manual.md: require revbump of removed-packages
@ 2021-03-18 19:27 Chocimier
  2021-03-19  1:20 ` ericonr
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Chocimier @ 2021-03-18 19:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

There is a new pull request by Chocimier against master on the void-packages repository

https://github.com/Chocimier/void-packages-org revision
https://github.com/void-linux/void-packages/pull/29571

Manual.md: require revbump of removed-packages


A patch file from https://github.com/void-linux/void-packages/pull/29571.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-revision-29571.patch --]
[-- Type: text/x-diff, Size: 953 bytes --]

From 792c41e56a37627f8e31bdbad22fabaa75b594a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Thu, 18 Mar 2021 20:25:44 +0100
Subject: [PATCH] Manual.md: require revbump of removed-packages

---
 Manual.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Manual.md b/Manual.md
index 4439865e1d73..26591c126340 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1662,7 +1662,8 @@ cyclic dependencies. Make sure that the package you're removing is not
 the source of those patches/files.
 - Remove package template.
 - Add `pkgname<=version_revision` to `replaces` variable of `removed-packages`
-template.  All removed subpkgs should be added too.
+template and increase revision of `removed-packages`.
+All removed subpkgs should be added too.
 This will uninstall package from systems where it is installed.
 - Remove the package from the repository index
 or contact a team member that can do so.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Manual.md: require revbump of removed-packages
  2021-03-18 19:27 [PR PATCH] Manual.md: require revbump of removed-packages Chocimier
@ 2021-03-19  1:20 ` ericonr
  2021-03-27 14:51 ` Chocimier
  2021-03-27 14:52 ` [PR PATCH] [Closed]: " Chocimier
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-03-19  1:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29571#issuecomment-802439130

Comment:
I've generally avoided revbumping `removed-packages` when a package removal wasn't urgent, because I knew it would happen soon enough. If you think it's always necessary, could you include a tiny explanation as to why (either in the commit message or Manual)?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Manual.md: require revbump of removed-packages
  2021-03-18 19:27 [PR PATCH] Manual.md: require revbump of removed-packages Chocimier
  2021-03-19  1:20 ` ericonr
@ 2021-03-27 14:51 ` Chocimier
  2021-03-27 14:52 ` [PR PATCH] [Closed]: " Chocimier
  2 siblings, 0 replies; 4+ messages in thread
From: Chocimier @ 2021-03-27 14:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/29571#issuecomment-808744813

Comment:
We can go with _eventual_ revbump too.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: Manual.md: require revbump of removed-packages
  2021-03-18 19:27 [PR PATCH] Manual.md: require revbump of removed-packages Chocimier
  2021-03-19  1:20 ` ericonr
  2021-03-27 14:51 ` Chocimier
@ 2021-03-27 14:52 ` Chocimier
  2 siblings, 0 replies; 4+ messages in thread
From: Chocimier @ 2021-03-27 14:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

There's a closed pull request on the void-packages repository

Manual.md: require revbump of removed-packages
https://github.com/void-linux/void-packages/pull/29571

Description:


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-27 14:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 19:27 [PR PATCH] Manual.md: require revbump of removed-packages Chocimier
2021-03-19  1:20 ` ericonr
2021-03-27 14:51 ` Chocimier
2021-03-27 14:52 ` [PR PATCH] [Closed]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).