[PR PATCH] void-updates: update to 20210324.

[PR PATCH] void-updates: update to 20210324.

[42LoCo42]

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is a new pull request by 42LoCo42 against master on the void-packages repository

https://github.com/42LoCo42/void-packages master
https://github.com/void-linux/void-packages/pull/29717

void-updates: update to 20210324.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29717.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29717.patch --]
[-- Type: text/x-diff, Size: 1417 bytes --]

From b0b37c34e952aae27c96e95584a33f5bf7605bc9 Mon Sep 17 00:00:00 2001
From: 42LoCo42 <leonsch@protonmail.com>
Date: Wed, 24 Mar 2021 14:24:08 +0100
Subject: [PATCH] void-updates: update to 20210324.

---
 srcpkgs/void-updates/template | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/void-updates/template b/srcpkgs/void-updates/template
index ab6cd4a96253..14547301bfb6 100644
--- a/srcpkgs/void-updates/template
+++ b/srcpkgs/void-updates/template
@@ -1,21 +1,17 @@
 # Template file for 'void-updates'
+# vim: set ft=bash:
 pkgname=void-updates
-version=20190330
+version=20210324
 revision=2
 build_style=gnu-makefile
-depends="git curl"
+depends="git"
 short_desc="Void Linux package updates"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="ISC"
-homepage="https://github.com/void-linux/void-updates"
+maintainer="Leon Schumacher <leonsch@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/42LoCo42/void-updates"
 distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=d87d6e3995dd65dabdc1b0bbd96070d78237c443aeff00766096e60263c108df
+checksum=a39a7129e1dc78b5f6d9be904984ed13399078adb8584f1c0c9efb07cb4cf655
 
 system_accounts="voidupdates"
 voidupdates_homedir="/var/cache/void-updates"
-voidupdates_groups="xbuilder"
 make_dirs="/var/cache/void-updates 0755 voidupdates voidupdates"
-
-post_install() {
-	vlicense LICENSE
-}

Re: void-updates: update to 20210324.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/29717#issuecomment-805837375

Comment:
Why do you want to change this to something totally unrelated? Besides scripts like that do not meet the quality requirement for new packages.

Re: [PR PATCH] [Closed]: void-updates: update to 20210324.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

There's a closed pull request on the void-packages repository

void-updates: update to 20210324.
https://github.com/void-linux/void-packages/pull/29717

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: void-updates: update to 20210324.

[42LoCo42]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

New comment by 42LoCo42 on void-packages repository

https://github.com/void-linux/void-packages/pull/29717#issuecomment-805851805

Comment:
I found the old void-updates script to be quite slow and computationally intensive.
Thus I rewrote it with the goal of maximum speed and stability.
My version is significantly faster, taking only a few seconds to generate a list of packages to upgrade.
If that is not the goal of the original script, I'm sorry that I have wasted your time with this PR.
Apart from that, I don't really see why my script would not meet the quality requirements.
Shellcheck reports no warnings and all functions have descriptive names, which eases debugging.

Re: void-updates: update to 20210324.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29717#issuecomment-805854806

Comment:
@42LoCo42 please make a PR to the proper repository and it can be discussed there. Changing upstream of the script is not really an option.

Re: void-updates: update to 20210324.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/29717#issuecomment-805855568

Comment:
I think you didn't quite catch what the old script did. It checked upstream if the version in a template was old. You script checks if a package in your local binary repo is older than the template.

For what you do, take a look at xbps-checkvers (it is probably even faster than your script)

Re: void-updates: update to 20210324.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29717#issuecomment-805855607

Comment:
That is, PR your code changes to void-updates repository.

Re: void-updates: update to 20210324.

[42LoCo42]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by 42LoCo42 on void-packages repository

https://github.com/void-linux/void-packages/pull/29717#issuecomment-805856378

Comment:
Thank you all for enlightening me on this matter!