Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] intel-gmmlib: add comment about -march used in compiler flags.
Date: Wed, 07 Apr 2021 21:33:22 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30074@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages gmmlib
https://github.com/void-linux/void-packages/pull/30074

intel-gmmlib: add comment about -march used in compiler flags.
Reported by sgn
Suggestion for "fix" by tornaria
Closes #29801

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30074.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmmlib-30074.patch --]
[-- Type: text/x-diff, Size: 1324 bytes --]

From 0864c036fcebc810c8d0d398e2df31bbf0c09622 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Wed, 7 Apr 2021 16:31:51 -0300
Subject: [PATCH] intel-gmmlib: add comment about -march used in compiler
 flags.

Reported by sgn
Suggestion for "fix" by tornaria
Closes #29801
---
 srcpkgs/intel-gmmlib/template | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/srcpkgs/intel-gmmlib/template b/srcpkgs/intel-gmmlib/template
index de10b7059d95..ad6ba012fa90 100644
--- a/srcpkgs/intel-gmmlib/template
+++ b/srcpkgs/intel-gmmlib/template
@@ -5,6 +5,14 @@ revision=1
 archs="i686* x86_64*"
 wrksrc=gmmlib-intel-gmmlib-${version}
 build_style=cmake
+# We could add -DGMMLIB_ARCH=generic to make it use -march=generic
+# instead of their default of 'corei7', but it isn't necessary:
+# the baseline of CPUs supported by gmmlib all fit under 'corei7'.
+# They also add many '-msse*' flags, but they are all supported
+# as well. Since this library isn't a dependency for anything but
+# intel-media-driver, which is wholly optional and installed only on
+# systems with supported CPUs, it doesn't make sense to change the
+# compilers flag in use.
 configure_args="-Wno-dev"
 short_desc="Intel Graphics Memory Management Library"
 maintainer="Stefano Ragni <st3r4g@protonmail.com>"

             reply	other threads:[~2021-04-07 19:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 19:33 ericonr [this message]
2021-04-07 20:08 ` ericonr
2021-04-11  2:57 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30074@inbox.vuxu.org \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).