[PR PATCH] New package: rtl8192eu-dkms-20210111

[PR PATCH] New package: rtl8192eu-dkms-20210111

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

There is a new pull request by Phicem against master on the void-packages repository

https://github.com/Phicem/void-packages rtl8192eu-dkms-20210111
https://github.com/void-linux/void-packages/pull/30121

New package: rtl8192eu-dkms-20210111
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30121.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rtl8192eu-dkms-20210111-30121.patch --]
[-- Type: text/x-diff, Size: 1525 bytes --]

From 0e4e06d74791e1f74a1268b02fc2354c58b3579d Mon Sep 17 00:00:00 2001
From: Phicem <phicem@gmx.com>
Date: Sat, 10 Apr 2021 14:58:32 +0200
Subject: [PATCH] New package: rtl8192eu-dkms-20210111

---
 srcpkgs/rtl8192eu-dkms/template | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 srcpkgs/rtl8192eu-dkms/template

diff --git a/srcpkgs/rtl8192eu-dkms/template b/srcpkgs/rtl8192eu-dkms/template
new file mode 100644
index 000000000000..11ff5472d389
--- /dev/null
+++ b/srcpkgs/rtl8192eu-dkms/template
@@ -0,0 +1,28 @@
+# Template file for 'rtl8192eu-dkms'
+pkgname=rtl8192eu-dkms
+version=20210111
+revision=2
+_modver=2021.01.11
+_gitrev=faf68bbf82623335e7997a473f9222751e275927
+archs="*"
+wrksrc="rtl8192eu-linux-driver-${_gitrev}"
+depends="dkms bc"
+short_desc="Realtek 8192EU USB WiFi driver (DKMS)"
+maintainer="Phicem <phicem@gmx.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Mange/rtl8192eu-linux-driver"
+distfiles="https://github.com/Mange/rtl8192eu-linux-driver/archive/${_gitrev}.tar.gz"
+checksum=f6988f1f0a4128cf935c2d09cd45a782f46414dc1a8d7c992c05ed7d565ac922
+dkms_modules="rtl8192eu ${_modver}"
+
+do_install() {
+	local dest=/usr/src/rtl8192eu-${_modver}
+
+	vmkdir ${dest}
+	cp -r dkms.conf Kconfig Makefile platform core hal include os_dep ${DESTDIR}/${dest}
+
+	# modules-load.d(5) file.
+	vmkdir usr/lib/modules-load.d
+	echo "8192eu" > ${DESTDIR}/usr/lib/modules-load.d/${pkgname}.conf
+	chmod 644 ${DESTDIR}/usr/lib/modules-load.d/${pkgname}.conf
+}

Re: [PR PATCH] [Updated] New package: rtl8192eu-dkms-20210111

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by Phicem against master on the void-packages repository

https://github.com/Phicem/void-packages rtl8192eu-dkms-20210111
https://github.com/void-linux/void-packages/pull/30121

New package: rtl8192eu-dkms-20210111
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30121.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rtl8192eu-dkms-20210111-30121.patch --]
[-- Type: text/x-diff, Size: 1525 bytes --]

From a65f386bef946c87308801372fb6e08d82d10cef Mon Sep 17 00:00:00 2001
From: Phicem <phicem@gmx.com>
Date: Sat, 16 Apr 2022 09:45:20 +0200
Subject: [PATCH] New package: rtl8192eu-dkms-20220406

---
 srcpkgs/rtl8192eu-dkms/template | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 srcpkgs/rtl8192eu-dkms/template

diff --git a/srcpkgs/rtl8192eu-dkms/template b/srcpkgs/rtl8192eu-dkms/template
new file mode 100644
index 000000000000..b82f559313e2
--- /dev/null
+++ b/srcpkgs/rtl8192eu-dkms/template
@@ -0,0 +1,28 @@
+# Template file for 'rtl8192eu-dkms'
+pkgname=rtl8192eu-dkms
+version=20220406
+revision=2
+_modver=2022.04.06
+_gitrev=5484fbd00c39826fd91e2d784cce211d55537447
+archs='*'
+wrksrc="rtl8192eu-linux-driver-${_gitrev}"
+depends="dkms bc"
+short_desc="Realtek 8192EU USB WiFi driver (DKMS)"
+maintainer="Phicem <phicem@gmx.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Mange/rtl8192eu-linux-driver"
+distfiles="https://github.com/Mange/rtl8192eu-linux-driver/archive/${_gitrev}.tar.gz"
+checksum=c0d92ba7adf870cacb5f942b373d308fb5a706e9fa6ffb6c2cedd98f04ef9240
+dkms_modules="rtl8192eu ${_modver}"
+
+do_install() {
+	local dest=/usr/src/rtl8192eu-${_modver}
+
+	vmkdir ${dest}
+	cp -r dkms.conf Kconfig Makefile platform core hal include os_dep ${DESTDIR}/${dest}
+
+	# modules-load.d(5) file.
+	vmkdir usr/lib/modules-load.d
+	echo "8192eu" > ${DESTDIR}/usr/lib/modules-load.d/${pkgname}.conf
+	chmod 644 ${DESTDIR}/usr/lib/modules-load.d/${pkgname}.conf
+}

Re: New package: rtl8192eu-dkms-20210111

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by Phicem on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#issuecomment-1100658275

Comment:
Force-pushed on Apr 16, 2022 to update the base branch AND the package itself

Re: New package: rtl8192eu-dkms-20220406

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#issuecomment-1186062373

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: rtl8192eu-dkms-20220406

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by Phicem on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#issuecomment-1197329634

Comment:
I'm bumping this pull request because I believe this package deserves to be in Void.

Re: New package: rtl8192eu-dkms-20220406

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#issuecomment-1292872153

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Updated] New package: rtl8192eu-dkms-20220406

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]

There is an updated pull request by Phicem against master on the void-packages repository

https://github.com/Phicem/void-packages rtl8192eu-dkms-20210111
https://github.com/void-linux/void-packages/pull/30121

New package: rtl8192eu-dkms-20220406
<!-- Mark items with [x] where applicable -->

#### Purpose of this package

This package is necessary for using some versions of TP-Link TL-WN823N (because in-kernel rtl8xxxx module does not work properly for those devices).

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me


<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30121.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rtl8192eu-dkms-20210111-30121.patch --]
[-- Type: text/x-diff, Size: 2808 bytes --]

From bf567653e43f379a2aa4884affecc8482f9e4f38 Mon Sep 17 00:00:00 2001
From: Phicem <phicem@gmx.com>
Date: Sat, 16 Apr 2022 09:45:20 +0200
Subject: [PATCH 1/2] New package: rtl8192eu-dkms-20220406

---
 srcpkgs/rtl8192eu-dkms/template | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 srcpkgs/rtl8192eu-dkms/template

diff --git a/srcpkgs/rtl8192eu-dkms/template b/srcpkgs/rtl8192eu-dkms/template
new file mode 100644
index 000000000000..b82f559313e2
--- /dev/null
+++ b/srcpkgs/rtl8192eu-dkms/template
@@ -0,0 +1,28 @@
+# Template file for 'rtl8192eu-dkms'
+pkgname=rtl8192eu-dkms
+version=20220406
+revision=2
+_modver=2022.04.06
+_gitrev=5484fbd00c39826fd91e2d784cce211d55537447
+archs='*'
+wrksrc="rtl8192eu-linux-driver-${_gitrev}"
+depends="dkms bc"
+short_desc="Realtek 8192EU USB WiFi driver (DKMS)"
+maintainer="Phicem <phicem@gmx.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Mange/rtl8192eu-linux-driver"
+distfiles="https://github.com/Mange/rtl8192eu-linux-driver/archive/${_gitrev}.tar.gz"
+checksum=c0d92ba7adf870cacb5f942b373d308fb5a706e9fa6ffb6c2cedd98f04ef9240
+dkms_modules="rtl8192eu ${_modver}"
+
+do_install() {
+	local dest=/usr/src/rtl8192eu-${_modver}
+
+	vmkdir ${dest}
+	cp -r dkms.conf Kconfig Makefile platform core hal include os_dep ${DESTDIR}/${dest}
+
+	# modules-load.d(5) file.
+	vmkdir usr/lib/modules-load.d
+	echo "8192eu" > ${DESTDIR}/usr/lib/modules-load.d/${pkgname}.conf
+	chmod 644 ${DESTDIR}/usr/lib/modules-load.d/${pkgname}.conf
+}

From bed5f348ccbad32ec2a49ecb05a88c415e0d6217 Mon Sep 17 00:00:00 2001
From: Phicem <phicem@gmx.com>
Date: Sat, 5 Nov 2022 17:39:19 +0100
Subject: [PATCH 2/2] New package: rtl8192eu-dkms-20221031

---
 srcpkgs/rtl8192eu-dkms/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/rtl8192eu-dkms/template b/srcpkgs/rtl8192eu-dkms/template
index b82f559313e2..4bcbdfdd25a0 100644
--- a/srcpkgs/rtl8192eu-dkms/template
+++ b/srcpkgs/rtl8192eu-dkms/template
@@ -1,9 +1,9 @@
 # Template file for 'rtl8192eu-dkms'
 pkgname=rtl8192eu-dkms
-version=20220406
-revision=2
-_modver=2022.04.06
-_gitrev=5484fbd00c39826fd91e2d784cce211d55537447
+version=20221031
+revision=1
+_modver=2022.10.31
+_gitrev=982f7907c478724b9fc4febd476b38c72dd4c1f2
 archs='*'
 wrksrc="rtl8192eu-linux-driver-${_gitrev}"
 depends="dkms bc"
@@ -12,7 +12,7 @@ maintainer="Phicem <phicem@gmx.com>"
 license="GPL-2.0-only"
 homepage="https://github.com/Mange/rtl8192eu-linux-driver"
 distfiles="https://github.com/Mange/rtl8192eu-linux-driver/archive/${_gitrev}.tar.gz"
-checksum=c0d92ba7adf870cacb5f942b373d308fb5a706e9fa6ffb6c2cedd98f04ef9240
+checksum=833bef04c4cff7234069debbb40613170b23a7fb6fdbcadb2dafc12e2012d89c
 dkms_modules="rtl8192eu ${_modver}"
 
 do_install() {

Re: [PR PATCH] [Updated] New package: rtl8192eu-dkms-20220406

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]

There is an updated pull request by Phicem against master on the void-packages repository

https://github.com/Phicem/void-packages rtl8192eu-dkms-20210111
https://github.com/void-linux/void-packages/pull/30121

New package: rtl8192eu-dkms-20220406
<!-- Mark items with [x] where applicable -->

#### Purpose of this package

This package is necessary for using some versions of TP-Link TL-WN823N (because in-kernel rtl8xxxx module does not work properly for those devices).

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me


<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30121.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rtl8192eu-dkms-20210111-30121.patch --]
[-- Type: text/x-diff, Size: 1525 bytes --]

From 56aa4c45d451290ea77fb6460d4cf3d7fd5027b4 Mon Sep 17 00:00:00 2001
From: Phicem <phicem@gmx.com>
Date: Sat, 16 Apr 2022 09:45:20 +0200
Subject: [PATCH] New package: rtl8192eu-dkms-20221031

---
 srcpkgs/rtl8192eu-dkms/template | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 srcpkgs/rtl8192eu-dkms/template

diff --git a/srcpkgs/rtl8192eu-dkms/template b/srcpkgs/rtl8192eu-dkms/template
new file mode 100644
index 000000000000..4bcbdfdd25a0
--- /dev/null
+++ b/srcpkgs/rtl8192eu-dkms/template
@@ -0,0 +1,28 @@
+# Template file for 'rtl8192eu-dkms'
+pkgname=rtl8192eu-dkms
+version=20221031
+revision=1
+_modver=2022.10.31
+_gitrev=982f7907c478724b9fc4febd476b38c72dd4c1f2
+archs='*'
+wrksrc="rtl8192eu-linux-driver-${_gitrev}"
+depends="dkms bc"
+short_desc="Realtek 8192EU USB WiFi driver (DKMS)"
+maintainer="Phicem <phicem@gmx.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Mange/rtl8192eu-linux-driver"
+distfiles="https://github.com/Mange/rtl8192eu-linux-driver/archive/${_gitrev}.tar.gz"
+checksum=833bef04c4cff7234069debbb40613170b23a7fb6fdbcadb2dafc12e2012d89c
+dkms_modules="rtl8192eu ${_modver}"
+
+do_install() {
+	local dest=/usr/src/rtl8192eu-${_modver}
+
+	vmkdir ${dest}
+	cp -r dkms.conf Kconfig Makefile platform core hal include os_dep ${DESTDIR}/${dest}
+
+	# modules-load.d(5) file.
+	vmkdir usr/lib/modules-load.d
+	echo "8192eu" > ${DESTDIR}/usr/lib/modules-load.d/${pkgname}.conf
+	chmod 644 ${DESTDIR}/usr/lib/modules-load.d/${pkgname}.conf
+}

Re: [PR REVIEW] New package: rtl8192eu-dkms-20221031

[paper42]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#discussion_r1014672591

Comment:
if they don't have releases, then this package doesn't really meet our quality requirements

Re: [PR REVIEW] New package: rtl8192eu-dkms-20221031

[paper42]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#discussion_r1014672180

Comment:
remove, this is the default value

Re: [PR REVIEW] New package: rtl8192eu-dkms-20221031

[paper42]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#discussion_r1014672354

Comment:
> The original code is copyrighted, but I don't know by whom. The driver download does not contain license information; please open an issue if you are the copyright holder.

That doesn't look like GPL2

Re: [PR REVIEW] New package: rtl8192eu-dkms-20221031

[paper42]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#discussion_r1014672453

Comment:
why not just use $version directly?

Re: [PR REVIEW] New package: rtl8192eu-dkms-20221031

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 3005 bytes --]

New review comment by Phicem on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#discussion_r1014876537

Comment:
I think it's not as bad as it looks. 

The comment that you quoted above refers to the original code (first commit of the repo), which is downloadable from DLINK website. I tried to get into depth into what was released under GPL and what was not.

### In the original code
- There is no general license information
- the Makefile (and some other trivial config files and trivial scripts) have no author and no license information
- most of the 333 source files (.h and .c) have license information (GPL2), except 39 files
- there are 16 .c files without license information:
    - 2 files have no author information (`./core/rtw_wapi.c` and `./core/rtw_wapi_sms4.c`)
    - 12 files have an author name ("Cosa") (`./hal/OUTSRC-BTCoexist/HalBtc*`)
    - 2 files are Copyright Realtek (`./hal/rtl8192e/Hal8192EPwrSeq.c` and `./os_dep/linux/wifi_regd.c`)
- there are 23 header files without license information.

### In current code
Recent versions of the repo (which would be what would be packaged here) have even less license-less files:
- the Makefile (and some other trivial config files and trivial scripts) still have no author or license information
- all but 4 of the 512 source files (.h and .c) have license information (GPLv2)
- there is 1 .c file without license information:
   - this file is `./hal/btc/halbtc8192e2ant.c`
   - this file mentions an author name ("Cosa") in the history section
   - this file exists in a different form in many other repositories, including the linux kernel itself, with GPL license. What I mean by 'different form' is that the code has undergone many changes, but the mentioned author is the same. See for instance: [in the linux kernel](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c?h=v6.1-rc3&id=f1d2b4d338bf090296f67830025228872fd52513)
- there are 3 header files without author or license information
    - one is a trivial file `./include/rtw_version.h`
    - the second one is `./hal/btc/halbtc8192e2ant.h` and also exists in the linux kernel in another form (many changes in the code but same base)
    - the thirst one is `./hal/phydm/phydm_regtable.h` but is a long list of trivial `#define`

### Conclusion
Apart from the makefile and some trivial scripts and headers, there are only two files that are not explicitely GPLed : `./hal/btc/halbtc8192e2ant.c` and its corresponding header. The fact that modified versions of these files can be found as GPL-released files tends to reassure me, but still, I have no proof that the exact files we use are GPL. Moreover, I have no license information at all about the makefile.

If we say that this is a problem, could we put the package in the `nonfree` repository, with a license field like `license="GPL-2.0-only, custom:unknown"`?

Re: [PR REVIEW] New package: rtl8192eu-dkms-20221031

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

New review comment by Phicem on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#discussion_r1014878012

Comment:
Yes, you are right. I saw some exceptions in existing packages, including other realtek drivers like `rtl8812au-dkms`, `rtl8822bu-dkms`, and `rtl8821cu-dkms`, so I thought it was okay (and I still think that these are legitimate exceptions). But I should not say that the package meets Void quality requirements. I will edit my package presentation.

Re: [PR REVIEW] New package: rtl8192eu-dkms-20221031

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#discussion_r1027161643

Comment:
[this upstream](https://github.com/clnhub/rtl8192eu-linux) has v5 of the driver and at least has branches for versions

Re: New package: rtl8192eu-dkms-20221031

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#issuecomment-1435449533

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Updated] New package: rtl8192eu-dkms-20221031

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]

There is an updated pull request by Phicem against master on the void-packages repository

https://github.com/Phicem/void-packages rtl8192eu-dkms-20210111
https://github.com/void-linux/void-packages/pull/30121

New package: rtl8192eu-dkms-20221031
<!-- Mark items with [x] where applicable -->

#### Purpose of this package

This package is necessary for using some versions of TP-Link TL-WN823N (because in-kernel rtl8xxxx module does not work properly for those devices).

#### Quality requirement
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements)
  --> The source repository does not provide releases

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  On a x86_64 (glibc) system, with TP-Link TL-WN823N v2/v3

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30121.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rtl8192eu-dkms-20210111-30121.patch --]
[-- Type: text/x-diff, Size: 1484 bytes --]

From 346c4336fda14a9933bf6fbce9266e984f0ffcbf Mon Sep 17 00:00:00 2001
From: Phicem <phicem@gmx.com>
Date: Sat, 16 Apr 2022 09:45:20 +0200
Subject: [PATCH] New package: rtl8192eu-dkms-2022.12.29

---
 srcpkgs/rtl8192eu-dkms/template | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 srcpkgs/rtl8192eu-dkms/template

diff --git a/srcpkgs/rtl8192eu-dkms/template b/srcpkgs/rtl8192eu-dkms/template
new file mode 100644
index 000000000000..79f7f8c11ec9
--- /dev/null
+++ b/srcpkgs/rtl8192eu-dkms/template
@@ -0,0 +1,26 @@
+# Template file for 'rtl8192eu-dkms'
+pkgname=rtl8192eu-dkms
+version=2022.12.29
+revision=1
+_gitrev=865656c3a1d1aee8c4ba459ce7608756d17c712f
+wrksrc="rtl8192eu-linux-driver-${_gitrev}"
+depends="dkms bc"
+short_desc="Realtek 8192EU USB WiFi driver (DKMS)"
+maintainer="Phicem <phicem@gmx.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/clnhub/rtl8192eu-linux"
+distfiles="https://github.com/clnhub/rtl8192eu-linux/archive/${_gitrev}.tar.gz"
+checksum=72d1d97c6d2038885e5666f3271609b4dcbe45633c19a5606dc59745ff8ab543
+dkms_modules="rtl8192eu ${version}"
+
+do_install() {
+	local dest=/usr/src/rtl8192eu-${_modver}
+
+	vmkdir ${dest}
+	cp -r dkms.conf Kconfig Makefile platform core hal include os_dep ${DESTDIR}/${dest}
+
+	# modules-load.d(5) file.
+	vmkdir usr/lib/modules-load.d
+	echo "8192eu" > ${DESTDIR}/usr/lib/modules-load.d/${pkgname}.conf
+	chmod 644 ${DESTDIR}/usr/lib/modules-load.d/${pkgname}.conf
+}

Re: [PR REVIEW] New package: rtl8192eu-dkms-20221031

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by Phicem on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#discussion_r1111105621

Comment:
Right, fixed

Re: [PR REVIEW] New package: rtl8192eu-dkms-20221031

[Phicem]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by Phicem on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#discussion_r1111105863

Comment:
I switched to the suggested upstream. It seems to work equally well.

Re: New package: rtl8192eu-dkms-2022.12.29

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/30121#issuecomment-1556061927

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: rtl8192eu-dkms-2022.12.29

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]

There's a closed pull request on the void-packages repository

New package: rtl8192eu-dkms-2022.12.29
https://github.com/void-linux/void-packages/pull/30121

Description:
<!-- Mark items with [x] where applicable -->

#### Purpose of this package

This package is necessary for using some versions of TP-Link TL-WN823N (because in-kernel rtl8xxxx module does not work properly for those devices).

#### Quality requirement
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements)
  --> The source repository does not provide releases

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  On a x86_64 (glibc) system, with TP-Link TL-WN823N v2/v3

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->