From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] [RFC] screen: don't enable multiuser mode by default.
Date: Wed, 14 Apr 2021 22:18:36 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30241@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1663 bytes --]
There is a new pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages screen
https://github.com/void-linux/void-packages/pull/30241
[RFC] screen: don't enable multiuser mode by default.
This requires that the screen binary be suid.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30241.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-screen-30241.patch --]
[-- Type: text/x-diff, Size: 1318 bytes --]
From 341e44c40f798d985135319e46f8a14b35a45bd8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Wed, 14 Apr 2021 17:17:30 -0300
Subject: [PATCH] screen: don't enable multiuser mode by default.
This requires that the screen binary be suid.
---
srcpkgs/screen/template | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/screen/template b/srcpkgs/screen/template
index 613696d9f373..4fcf97e83e91 100644
--- a/srcpkgs/screen/template
+++ b/srcpkgs/screen/template
@@ -1,7 +1,7 @@
# Template file for 'screen'
pkgname=screen
version=4.8.0
-revision=2
+revision=3
build_style=gnu-configure
configure_args="--with-sys-screenrc=/etc/screenrc --enable-pam
--enable-colors256 --enable-rxvt_osc --enable-telnet
@@ -15,10 +15,14 @@ homepage="http://www.gnu.org/s/screen/"
distfiles="${GNU_SITE}/$pkgname/$pkgname-$version.tar.gz"
checksum=6e11b13d8489925fde25dfb0935bf6ed71f9eb47eff233a181e078fde5655aa1
+build_options="multiuser"
+
post_install() {
vinstall etc/etcscreenrc 0644 etc screenrc
vinstall etc/screenrc 0644 etc/skel .screenrc
vinstall ${FILESDIR}/screen 0644 etc/pam.d
- chmod 4755 ${DESTDIR}/usr/bin/screen-${version}
+ if [ "$build_option_multiuser" ]; then
+ chmod 4755 ${DESTDIR}/usr/bin/screen-${version}
+ fi
}
next reply other threads:[~2021-04-14 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 20:18 ericonr [this message]
2021-07-22 19:21 ` [PR PATCH] [Merged]: " ericonr
2021-07-23 17:01 ` tornaria
2021-07-23 17:14 ` ericonr
2021-07-23 17:24 ` ericonr
2021-07-23 17:32 ` tornaria
2021-07-23 17:32 ` ericonr
2021-07-23 17:36 ` ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30241@inbox.vuxu.org \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).