Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] binutils: remove dependency to binutils-doc
@ 2021-05-04 18:16 ailiop-git
  2021-05-04 18:18 ` ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: ailiop-git @ 2021-05-04 18:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1831 bytes --]

There is a new pull request by ailiop-git against master on the void-packages repository

https://github.com/ailiop-git/void-packages binutils
https://github.com/void-linux/void-packages/pull/30678

binutils: remove dependency to binutils-doc
The binutils main package doesn't depend on the info files contained in
the documentation package. Remove it from being a dependency similar to
any other package whose documentation is split off into a subpackage.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30678.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-binutils-30678.patch --]
[-- Type: text/x-diff, Size: 872 bytes --]

From 0ce3cbc66b76646b4b94b02f4d1ea4886436b1fa Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Tue, 4 May 2021 02:22:09 +0200
Subject: [PATCH] binutils: remove dependency to binutils-doc

The binutils main package doesn't depend on the info files contained in
the documentation package. Remove it from being a dependency similar to
any other package whose documentation is split off into a subpackage.
---
 srcpkgs/binutils/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/binutils/template b/srcpkgs/binutils/template
index 7a7966f440aa..bc19d16328f5 100644
--- a/srcpkgs/binutils/template
+++ b/srcpkgs/binutils/template
@@ -17,7 +17,6 @@ if [ "$CHROOT_READY" ]; then
 	hostmakedepends="flex perl texinfo"
 	makedepends+=" elfutils-devel"
 	checkdepends="bc"
-	depends="binutils-doc"
 	subpackages+=" binutils-devel"
 fi
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: binutils: remove dependency to binutils-doc
  2021-05-04 18:16 [PR PATCH] binutils: remove dependency to binutils-doc ailiop-git
@ 2021-05-04 18:18 ` ericonr
  2021-05-04 18:19 ` ericonr
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-05-04 18:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30678#issuecomment-832146163

Comment:
binutils is 26MB, binutils-doc is less than 1MB. IMO it makes more sense to remove the subpackage completely and fold it into `binutils` (add replaces="binutils-doc>=0"` to `binutils`).

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: binutils: remove dependency to binutils-doc
  2021-05-04 18:16 [PR PATCH] binutils: remove dependency to binutils-doc ailiop-git
  2021-05-04 18:18 ` ericonr
@ 2021-05-04 18:19 ` ericonr
  2021-05-04 18:24 ` ericonr
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-05-04 18:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30678#issuecomment-832146163

Comment:
binutils is 26MB, binutils-doc is less than 1MB. IMO it makes more sense to remove the subpackage completely and fold it into `binutils` (add `replaces="binutils-doc>=0"` to `binutils`).

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: binutils: remove dependency to binutils-doc
  2021-05-04 18:16 [PR PATCH] binutils: remove dependency to binutils-doc ailiop-git
  2021-05-04 18:18 ` ericonr
  2021-05-04 18:19 ` ericonr
@ 2021-05-04 18:24 ` ericonr
  2021-05-04 18:46 ` ailiop-git
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-05-04 18:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30678#issuecomment-832150009

Comment:
Ah, it isn't explained properly. It's split off because other packages depend on it: `xbps-query -RX binutils-doc`.

You could add a comment about it to the template instead, maybe.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: binutils: remove dependency to binutils-doc
  2021-05-04 18:16 [PR PATCH] binutils: remove dependency to binutils-doc ailiop-git
                   ` (2 preceding siblings ...)
  2021-05-04 18:24 ` ericonr
@ 2021-05-04 18:46 ` ailiop-git
  2021-05-04 19:32 ` ericonr
  2021-05-04 19:33 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ailiop-git @ 2021-05-04 18:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

New comment by ailiop-git on void-packages repository

https://github.com/void-linux/void-packages/pull/30678#issuecomment-832163568

Comment:
So I agree with folding it into the main package, if we are to follow the manual guideline given that the size of the docs is the deciding factor (we do have other packages with tiny docs split off into a subpkg, e.g. 66, which probably need fixing).

I'm assuming that the original reason was so that the cross binutils can share the doc, but they certainly don't depend on it (so we probably better remove the depends from them). Both cross-arm-none-eabi-binutils and cross-or1k-none-elf-binutils rm the info files at the post_install phase so there should be no conflict.

What do you think?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: binutils: remove dependency to binutils-doc
  2021-05-04 18:16 [PR PATCH] binutils: remove dependency to binutils-doc ailiop-git
                   ` (3 preceding siblings ...)
  2021-05-04 18:46 ` ailiop-git
@ 2021-05-04 19:32 ` ericonr
  2021-05-04 19:33 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-05-04 19:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30678#issuecomment-832190687

Comment:
The idea of the split is that it becomes necessary because we have many `binutils` packages which would otherwise conflict. But `docs` as a split package solve this. In that way, the fact that it's a subpackage could be considered an implementation detail (in order for all the packages to provide the complete deal, including docs) rather than something users should be worrying about, so I would go as far as to say there is nothing to change.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: binutils: remove dependency to binutils-doc
  2021-05-04 18:16 [PR PATCH] binutils: remove dependency to binutils-doc ailiop-git
                   ` (4 preceding siblings ...)
  2021-05-04 19:32 ` ericonr
@ 2021-05-04 19:33 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-05-04 19:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30678#issuecomment-832190953

Comment:
People consciously added `binutils-doc` to depends for the other packages, so I expect there to have been actual demand.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-05-04 19:33 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-04 18:16 [PR PATCH] binutils: remove dependency to binutils-doc ailiop-git
2021-05-04 18:18 ` ericonr
2021-05-04 18:19 ` ericonr
2021-05-04 18:24 ` ericonr
2021-05-04 18:46 ` ailiop-git
2021-05-04 19:32 ` ericonr
2021-05-04 19:33 ` ericonr

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git