[PR PATCH] tor: fix Failing because we run out of file handles

[PR PATCH] tor: fix Failing because we run out of file handles

[steinex]

[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]

There is a new pull request by steinex against master on the void-packages repository

https://github.com/steinex/void-packages tor
https://github.com/void-linux/void-packages/pull/30687

tor: fix Failing because we run out of file handles
```
May  5 00:31:43 Tor[857]: Failing because we have 4063 connections already. Please read doc/TUNING for guidance.
```

Still does not build on musl but works for me, pinging @daniel-eys 


<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30687.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tor-30687.patch --]
[-- Type: text/x-diff, Size: 1028 bytes --]

From 62a99e68c447e56e0c7adc2f1168b13e33a0f43e Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Wed, 5 May 2021 01:57:02 +0200
Subject: [PATCH] tor: fix Failing because we have 4063 connections already.
 Please read doc/TUNING for guidance.

---
 srcpkgs/tor/files/tor/run | 1 +
 srcpkgs/tor/template      | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/tor/files/tor/run b/srcpkgs/tor/files/tor/run
index 66d61c6c1b59..d0d402d25f5a 100755
--- a/srcpkgs/tor/files/tor/run
+++ b/srcpkgs/tor/files/tor/run
@@ -1,3 +1,4 @@
 #!/bin/sh
 [ -r conf ] && . ./conf
+ulimit -n ${MAX_OPEN_FILES:-8192}
 exec tor ${OPTS:=--quiet} --runasdaemon 0 2>&1
diff --git a/srcpkgs/tor/template b/srcpkgs/tor/template
index 564a36ec87ef..cef10708f390 100644
--- a/srcpkgs/tor/template
+++ b/srcpkgs/tor/template
@@ -1,7 +1,7 @@
 # Template file for 'tor'
 pkgname=tor
 version=0.4.5.6
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-zstd"
 hostmakedepends="pkg-config"

Re: [PR REVIEW] tor: fix Failing because we run out of file handles

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30687#discussion_r626193683

Comment:
Is 8192 enough to guarantee the error won't appear again? I think double this would still be fine, file descriptors on linux are pretty cheap nowadays.

Re: [PR REVIEW] tor: fix Failing because we run out of file handles

[steinex]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

New review comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/30687#discussion_r626195426

Comment:
I'd prefer to not push this too far far for now, I will see how it holds up in production. This is not HAProxy and is pretty intensive on CPU resources. I'm open to up this again if this problem will pop up again, but you need some really beefy hardware for that.

Re: [PR REVIEW] tor: fix Failing because we run out of file handles

[steinex]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New review comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/30687#discussion_r626197382

Comment:
Still there is the option to override this via conf if really needed, but I honestly doubt everyone will ever hit that.

Re: [PR PATCH] [Merged]: tor: fix Failing because we run out of file handles

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]

There's a merged pull request on the void-packages repository

tor: fix Failing because we run out of file handles
https://github.com/void-linux/void-packages/pull/30687

Description:
```
May  5 00:31:43 Tor[857]: Failing because we have 4063 connections already. Please read doc/TUNING for guidance.
```

Still does not build on musl but works for me, pinging @daniel-eys 


<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->