Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] MultiMC data dir and binary name
@ 2021-05-23 12:19 F0Xde
  2022-05-20  2:12 ` github-actions
  2022-06-04  2:08 ` [ISSUE] [CLOSED] " github-actions
  0 siblings, 2 replies; 3+ messages in thread
From: F0Xde @ 2021-05-23 12:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

New issue by F0Xde on void-packages repository

https://github.com/void-linux/void-packages/issues/31077

Description:
### System

* xuname:  
  Void 5.11.22_1 x86_64 GenuineIntel uptodate rrFFF
* package:  
  MultiMC-0.6.12_2

### Expected behavior

- MultiMC should use the correct data directory as defined in the XDG Base Directories standard.
- Its binary is according to the standard `CMakeLists.txt` called [multimc](https://github.com/MultiMC/MultiMC5/blob/911074e9669b6399df983a570c734018c2abd139/CMakeLists.txt#L209).

### Actual behavior
- This package installs a [shell script](https://github.com/void-linux/void-packages/blob/9a957dc5003cf0b5c6dd3de07033d9b6136aae91/srcpkgs/MultiMC/files/MultiMC.sh#L2) that launches MultiMC with the `-d ~/.multimc` argument, therefore overriding the expected behaviour.
- Additionally this script also effectively changes the name of the installed binary from `multimc` to `MultiMC`, which may not be the expected behaviour of users and could break compatibility when the standard name is assumed.

### Steps to reproduce the behavior
Run MultiMC

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: MultiMC data dir and binary name
  2021-05-23 12:19 [ISSUE] MultiMC data dir and binary name F0Xde
@ 2022-05-20  2:12 ` github-actions
  2022-06-04  2:08 ` [ISSUE] [CLOSED] " github-actions
  1 sibling, 0 replies; 3+ messages in thread
From: github-actions @ 2022-05-20  2:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/31077#issuecomment-1132374748

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ISSUE] [CLOSED] MultiMC data dir and binary name
  2021-05-23 12:19 [ISSUE] MultiMC data dir and binary name F0Xde
  2022-05-20  2:12 ` github-actions
@ 2022-06-04  2:08 ` github-actions
  1 sibling, 0 replies; 3+ messages in thread
From: github-actions @ 2022-06-04  2:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

Closed issue by F0Xde on void-packages repository

https://github.com/void-linux/void-packages/issues/31077

Description:
### System

* xuname:  
  Void 5.11.22_1 x86_64 GenuineIntel uptodate rrFFF
* package:  
  MultiMC-0.6.12_2

### Expected behavior

- MultiMC should use the correct data directory as defined in the XDG Base Directories standard.
- Its binary is according to the [CMakeLists.txt](https://github.com/MultiMC/MultiMC5/blob/911074e9669b6399df983a570c734018c2abd139/CMakeLists.txt#L209) called `multimc`.

### Actual behavior
- This package installs a [shell script](https://github.com/void-linux/void-packages/blob/9a957dc5003cf0b5c6dd3de07033d9b6136aae91/srcpkgs/MultiMC/files/MultiMC.sh#L2) that launches MultiMC with the `-d ~/.multimc` argument, therefore overriding the expected behaviour.
- Additionally this script also effectively changes the name of the installed binary from `multimc` to `MultiMC`, which may not be what users expect and can break compatibility when the standard name is assumed.

### Steps to reproduce the behavior

Run `MultiMC`

### Proposed fix

Remove the shell script and install the actual binary with its default name.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-04  2:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-23 12:19 [ISSUE] MultiMC data dir and binary name F0Xde
2022-05-20  2:12 ` github-actions
2022-06-04  2:08 ` [ISSUE] [CLOSED] " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).