[PR PATCH] Remove package: certbot-apache

[PR PATCH] Remove package: certbot-apache

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]

There is a new pull request by kartikynwa against master on the void-packages repository

https://github.com/kartikynwa/void-packages remove-certbot-apache
https://github.com/void-linux/void-packages/pull/31342

Remove package: certbot-apache
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

So I added this package a while back but it doesn't work anymore and I don't plan on maintaining it since I don't use Apache.

Really sorry for pushing a package that I wasn't going to maintain. Will be more careful from now on.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31342.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-remove-certbot-apache-31342.patch --]
[-- Type: text/x-diff, Size: 1156 bytes --]

From 246f91fc82dd1f464510dade5922eb23628fabd1 Mon Sep 17 00:00:00 2001
From: Kartik Singh <kartik.ynwa@gmail.com>
Date: Mon, 7 Jun 2021 12:46:11 +0530
Subject: [PATCH] Remove package: certbot-apache

---
 srcpkgs/certbot-apache/template | 14 --------------
 1 file changed, 14 deletions(-)
 delete mode 100644 srcpkgs/certbot-apache/template

diff --git a/srcpkgs/certbot-apache/template b/srcpkgs/certbot-apache/template
deleted file mode 100644
index 17ea9df95947..000000000000
--- a/srcpkgs/certbot-apache/template
+++ /dev/null
@@ -1,14 +0,0 @@
-# Template file for 'certbot-apache'
-pkgname=certbot-apache
-version=1.16.0
-revision=1
-build_style=python3-module
-hostmakedepends="python3-setuptools"
-depends="certbot python3-acme python3-augeas python3-zope.interface"
-checkdepends="python3-pytest $depends"
-short_desc="Let's Encrypt certificate renewal automation utility - Apache plugin"
-maintainer="Kartik S. <kartik.ynwa@gmail.com>"
-license="Apache-2.0"
-homepage="https://certbot.eff.org/"
-distfiles="${PYPI_SITE}/c/certbot-apache/certbot-apache-${version}.tar.gz"
-checksum=26824b812826d22b3f80377dfc2976a6f37f425c414c50efd8f8bd6e7967d579

Re: Remove package: certbot-apache

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/31342#issuecomment-855666252

Comment:
Actually I think it would be better if someone could say whether this works or not. Moving to draft for now. Will test this later today and update or close the PR based on the results.

Re: Remove package: certbot-apache

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/31342#issuecomment-855951941

Comment:
If you remove this package, please also add it to the `removed-packages` template (alphabetically).

Re: Remove package: certbot-apache

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/31342#issuecomment-856079230

Comment:
So I tried this package today and it works. It requires some setup though:

1. Some Apache modules need to be enabled -- ssl, rewrite and maybe one other.
2. It needs to be run with flags `--apache-ctl /usr/bin/apachectl --apache-server-root /etc/apache`. Looks like this cannot be preconfigured while packaging. Unless we ship it as a patch. I can try filing a PR in the certbot repo for an override file like they have for a bunch of distros ([Arch for example](https://github.com/certbot/certbot/blob/master/certbot-apache/certbot_apache/_internal/override_arch.py))

Re: [PR PATCH] [Closed]: Remove package: certbot-apache

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]

There's a closed pull request on the void-packages repository

Remove package: certbot-apache
https://github.com/void-linux/void-packages/pull/31342

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

So I added this package a while back but it doesn't work anymore and I don't plan on maintaining it since I don't use Apache.

Really sorry for pushing a package that I wasn't going to maintain. Will be more careful from now on.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: Remove package: certbot-apache

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/31342#issuecomment-860012310

Comment:
This PR got merged into certbot so after the next release and onwards `certbot --apache` should work almost out of the box.: https://github.com/certbot/certbot/pull/8891

Only caveat is that as a member there notes:

> Otherwise, --apache crashes until you enable the rewrite+ssl+socache modules by hand

Is there anything we can do about this? Feel free to let know if you have any suggestions.