Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] keepassxc: update to 2.6.5.
@ 2021-06-08 19:16 Piraty
  2021-06-08 19:22 ` [PR REVIEW] " Chocimier
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Piraty @ 2021-06-08 19:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

There is a new pull request by Piraty against master on the void-packages repository

https://github.com/Piraty/void-packages keepassxc-2.6.5
https://github.com/void-linux/void-packages/pull/31373

keepassxc: update to 2.6.5.
<!-- Mark items with [x] where applicable -->
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31373.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-keepassxc-2.6.5-31373.patch --]
[-- Type: text/x-diff, Size: 1547 bytes --]

From fb40bd91d1731ea90dd25a8c2c9669203d63d92e Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Tue, 8 Jun 2021 20:49:32 +0200
Subject: [PATCH] keepassxc: update to 2.6.5.

---
 srcpkgs/keepassxc/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/keepassxc/template b/srcpkgs/keepassxc/template
index 54c33553b87f..0e371ac0c24d 100644
--- a/srcpkgs/keepassxc/template
+++ b/srcpkgs/keepassxc/template
@@ -1,6 +1,6 @@
 # Template file for 'keepassxc'
 pkgname=keepassxc
-version=2.6.4
+version=2.6.5
 revision=1
 build_style=cmake
 configure_args="-DWITH_TESTS=ON -DWITH_XC_UPDATECHECK=OFF -DWITH_XC_DOCS=ON
@@ -23,9 +23,9 @@ maintainer="Piraty <piraty1@inbox.ru>"
 license="GPL-3.0-or-later, BSD-3-Clause, CC0-1.0, LGPL-2.0-only, LGPL-2.1-only,
  LGPL-3.0-or-later, Nokia-Qt-exception-1.1, MIT, BSL-1.0"
 homepage="https://keepassxc.org/"
-changelog="https://raw.githubusercontent.com/keepassxreboot/keepassxc/blob/develop/CHANGELOG.md"
+changelog="https://raw.githubusercontent.com/keepassxreboot/keepassxc/${version}/CHANGELOG.md"
 distfiles="https://github.com/keepassxreboot/keepassxc/releases/download/${version}/keepassxc-${version}-src.tar.xz"
-checksum=e536e2a71c90fcf264eb831fb1a8b518ee1b03829828f862eeea748d3310f82b
+checksum=5edceb7f650729a0f272aae5ded463dc31fe2feb1f75d10a78f61f529ff90eb2
 
 # https://github.com/keepassxreboot/keepassxc/blob/a775031fe9471310e50232d1861d4991e2803aff/CMakeLists.txt#L46
 build_options="autotype browser fdosecrets keeshare network sshagent yubikey"

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] keepassxc: update to 2.6.5.
  2021-06-08 19:16 [PR PATCH] keepassxc: update to 2.6.5 Piraty
@ 2021-06-08 19:22 ` Chocimier
  2021-06-08 19:23 ` Chocimier
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2021-06-08 19:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/31373#discussion_r647730658

Comment:
I prefer changelogs from develop so I can look at changes before updating template, and can just paste.
Working one here is https://raw.githubusercontent.com/keepassxreboot/keepassxc/develop/CHANGELOG.md

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] keepassxc: update to 2.6.5.
  2021-06-08 19:16 [PR PATCH] keepassxc: update to 2.6.5 Piraty
  2021-06-08 19:22 ` [PR REVIEW] " Chocimier
@ 2021-06-08 19:23 ` Chocimier
  2021-06-08 19:25 ` Chocimier
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2021-06-08 19:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/31373#discussion_r647731465

Comment:
It's stale, nevermind

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] keepassxc: update to 2.6.5.
  2021-06-08 19:16 [PR PATCH] keepassxc: update to 2.6.5 Piraty
  2021-06-08 19:22 ` [PR REVIEW] " Chocimier
  2021-06-08 19:23 ` Chocimier
@ 2021-06-08 19:25 ` Chocimier
  2021-06-08 19:36 ` Piraty
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2021-06-08 19:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/31373#discussion_r647732689

Comment:
But 2.6.5 is unstable at the moment: https://github.com/keepassxreboot/keepassxc/releases/tag/2.6.5

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] keepassxc: update to 2.6.5.
  2021-06-08 19:16 [PR PATCH] keepassxc: update to 2.6.5 Piraty
                   ` (2 preceding siblings ...)
  2021-06-08 19:25 ` Chocimier
@ 2021-06-08 19:36 ` Piraty
  2021-06-08 19:36 ` Piraty
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Piraty @ 2021-06-08 19:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/31373#discussion_r647739128

Comment:
it's not unstable
```
<phoerious> It's not shipped downstream automatically and not picked up by our update check. If you package for downstream, don't use pre-releases if you rely on binaries. Source code is fine.
<phoerious> If everything is fine and all binaries are uploaded, we will eventually promote it to release.
<phoerious> Until that happens, don't rely on binaries not to change.
```

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] keepassxc: update to 2.6.5.
  2021-06-08 19:16 [PR PATCH] keepassxc: update to 2.6.5 Piraty
                   ` (3 preceding siblings ...)
  2021-06-08 19:36 ` Piraty
@ 2021-06-08 19:36 ` Piraty
  2021-06-08 19:38 ` Chocimier
  2021-06-08 20:21 ` [PR PATCH] [Merged]: " Piraty
  6 siblings, 0 replies; 8+ messages in thread
From: Piraty @ 2021-06-08 19:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/31373#discussion_r647739128

Comment:
it's not unstable (assuming you refer to `pre-release` mark in `/release` page)
```
<phoerious> It's not shipped downstream automatically and not picked up by our update check. If you package for downstream, don't use pre-releases if you rely on binaries. Source code is fine.
<phoerious> If everything is fine and all binaries are uploaded, we will eventually promote it to release.
<phoerious> Until that happens, don't rely on binaries not to change.
```

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] keepassxc: update to 2.6.5.
  2021-06-08 19:16 [PR PATCH] keepassxc: update to 2.6.5 Piraty
                   ` (4 preceding siblings ...)
  2021-06-08 19:36 ` Piraty
@ 2021-06-08 19:38 ` Chocimier
  2021-06-08 20:21 ` [PR PATCH] [Merged]: " Piraty
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2021-06-08 19:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/31373#discussion_r647740784

Comment:
ok

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: keepassxc: update to 2.6.5.
  2021-06-08 19:16 [PR PATCH] keepassxc: update to 2.6.5 Piraty
                   ` (5 preceding siblings ...)
  2021-06-08 19:38 ` Chocimier
@ 2021-06-08 20:21 ` Piraty
  6 siblings, 0 replies; 8+ messages in thread
From: Piraty @ 2021-06-08 20:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

There's a merged pull request on the void-packages repository

keepassxc: update to 2.6.5.
https://github.com/void-linux/void-packages/pull/31373

Description:
<!-- Mark items with [x] where applicable -->
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-06-08 20:21 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 19:16 [PR PATCH] keepassxc: update to 2.6.5 Piraty
2021-06-08 19:22 ` [PR REVIEW] " Chocimier
2021-06-08 19:23 ` Chocimier
2021-06-08 19:25 ` Chocimier
2021-06-08 19:36 ` Piraty
2021-06-08 19:36 ` Piraty
2021-06-08 19:38 ` Chocimier
2021-06-08 20:21 ` [PR PATCH] [Merged]: " Piraty

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).