Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] R: update to 4.1.0.
@ 2021-06-10 13:45 luhann
  2021-06-10 17:30 ` ericonr
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: luhann @ 2021-06-10 13:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

There is a new pull request by luhann against master on the void-packages repository

https://github.com/luhann/void-packages R
https://github.com/void-linux/void-packages/pull/31398

R: update to 4.1.0.
<!-- Mark items with [x] where applicable -->

#### General
Changed the way in which external blas was specified, as of R version 4.0.5 the old configuration no longer worked.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64)



A patch file from https://github.com/void-linux/void-packages/pull/31398.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-R-31398.patch --]
[-- Type: text/x-diff, Size: 1263 bytes --]

From 1a50ba887330797b86a9701207ebecd92abdc1aa Mon Sep 17 00:00:00 2001
From: Luke Hannan <luke@lukehannan.com>
Date: Thu, 10 Jun 2021 15:40:24 +0200
Subject: [PATCH] R: update to 4.1.0.

---
 srcpkgs/R/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/R/template b/srcpkgs/R/template
index 762a6e90e33b..1abe740977aa 100644
--- a/srcpkgs/R/template
+++ b/srcpkgs/R/template
@@ -1,10 +1,10 @@
 # Template file for 'R'
 pkgname=R
-version=4.0.3
-revision=2
+version=4.1.0
+revision=1
 build_style=gnu-configure
 configure_args="--docdir=/usr/share/doc/R rdocdir=/usr/share/doc/R
- --with-blas$(vopt_if openblas '="-lopenblas"') --with-lapack
+ --with-blas$(vopt_if openblas '=openblas') --with-lapack
  --enable-R-shlib --with-tcltk
  --enable-memory-profiling
  LIBnn=lib"
@@ -23,7 +23,7 @@ license="GPL-2.0-or-later"
 homepage="https://www.r-project.org/"
 changelog="https://cran.r-project.org/doc/manuals/r-release/NEWS.html"
 distfiles="https://cran.r-project.org/src/base/R-4/${pkgname}-${version}.tar.gz"
-checksum=09983a8a78d5fb6bc45d27b1c55f9ba5265f78fa54a55c13ae691f87c5bb9e0d
+checksum=e8e68959d7282ca147360fc9644ada9bd161bab781bab14d33b8999a95182781
 nocross=yes
 shlib_provides="libR.so"
 make_check=extended

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: R: update to 4.1.0.
  2021-06-10 13:45 [PR PATCH] R: update to 4.1.0 luhann
@ 2021-06-10 17:30 ` ericonr
  2021-06-11 14:20 ` luhann
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-06-10 17:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31398#issuecomment-858816319

Comment:
Do we need to rebuild the `R-cran-*` packages for this update or are they still working fine?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: R: update to 4.1.0.
  2021-06-10 13:45 [PR PATCH] R: update to 4.1.0 luhann
  2021-06-10 17:30 ` ericonr
@ 2021-06-11 14:20 ` luhann
  2021-06-11 14:44 ` ericonr
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: luhann @ 2021-06-11 14:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

New comment by luhann on void-packages repository

https://github.com/void-linux/void-packages/pull/31398#issuecomment-859615860

Comment:
I haven't tested all of the system `R-cran` packages, but the ones I did test (`data.table`, `ggplot2`, `lifecycle`, `dplyr`) worked without issue. All of the packages in my user library were built with R 4.0.3 and I haven't had any issues.

Rstudio says "In general, there are no issues with subminor version upgrades, like going from 3.3.2 to 3.3.3, **but there can be** compatibility problems when there is a major or minor version upgrade." Looking at the commit history it doesn't look like void has rebuilt all cran packages on minor version upgrades.

So everything should work but it is possible that something breaks, to save resources we could just rebuild the packages that break should anything break.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: R: update to 4.1.0.
  2021-06-10 13:45 [PR PATCH] R: update to 4.1.0 luhann
  2021-06-10 17:30 ` ericonr
  2021-06-11 14:20 ` luhann
@ 2021-06-11 14:44 ` ericonr
  2021-06-11 14:45 ` ericonr
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-06-11 14:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31398#issuecomment-859632304

Comment:
Sounds good to me, thank you for investigating :)

@flor

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: R: update to 4.1.0.
  2021-06-10 13:45 [PR PATCH] R: update to 4.1.0 luhann
                   ` (2 preceding siblings ...)
  2021-06-11 14:44 ` ericonr
@ 2021-06-11 14:45 ` ericonr
  2021-06-11 18:20 ` ericonr
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-06-11 14:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31398#issuecomment-859632304

Comment:
Sounds good to me, thank you for investigating :)

(sorry for accidental mention, flor)

@wagnerflo ok?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: R: update to 4.1.0.
  2021-06-10 13:45 [PR PATCH] R: update to 4.1.0 luhann
                   ` (3 preceding siblings ...)
  2021-06-11 14:45 ` ericonr
@ 2021-06-11 18:20 ` ericonr
  2021-06-11 20:47 ` luhann
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-06-11 18:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31398#issuecomment-859759570

Comment:
@luhann would you be interested in adopting this package? It seems wagnerflo hasn't been active in Void for a long while now.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: R: update to 4.1.0.
  2021-06-10 13:45 [PR PATCH] R: update to 4.1.0 luhann
                   ` (4 preceding siblings ...)
  2021-06-11 18:20 ` ericonr
@ 2021-06-11 20:47 ` luhann
  2021-06-11 21:05 ` [PR PATCH] [Updated] " luhann
  2021-06-12  1:43 ` [PR PATCH] [Merged]: " ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: luhann @ 2021-06-11 20:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by luhann on void-packages repository

https://github.com/void-linux/void-packages/pull/31398#issuecomment-859903109

Comment:
Sure I would be, I had been thinking about adopting it for a while now. I'll update the PR.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] R: update to 4.1.0.
  2021-06-10 13:45 [PR PATCH] R: update to 4.1.0 luhann
                   ` (5 preceding siblings ...)
  2021-06-11 20:47 ` luhann
@ 2021-06-11 21:05 ` luhann
  2021-06-12  1:43 ` [PR PATCH] [Merged]: " ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: luhann @ 2021-06-11 21:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

There is an updated pull request by luhann against master on the void-packages repository

https://github.com/luhann/void-packages R
https://github.com/void-linux/void-packages/pull/31398

R: update to 4.1.0.
<!-- Mark items with [x] where applicable -->

#### General
Changed the way in which external blas was specified, as of R version 4.0.5 the old configuration no longer worked.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64)



A patch file from https://github.com/void-linux/void-packages/pull/31398.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-R-31398.patch --]
[-- Type: text/x-diff, Size: 1567 bytes --]

From 0275cd22b71c8f0df17577cbff99feb579d01a37 Mon Sep 17 00:00:00 2001
From: Luke Hannan <luke@lukehannan.com>
Date: Thu, 10 Jun 2021 15:40:24 +0200
Subject: [PATCH] R: update to 4.1.0, adopt.

---
 srcpkgs/R/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/R/template b/srcpkgs/R/template
index 762a6e90e33b..69f67351e24c 100644
--- a/srcpkgs/R/template
+++ b/srcpkgs/R/template
@@ -1,10 +1,10 @@
 # Template file for 'R'
 pkgname=R
-version=4.0.3
-revision=2
+version=4.1.0
+revision=1
 build_style=gnu-configure
 configure_args="--docdir=/usr/share/doc/R rdocdir=/usr/share/doc/R
- --with-blas$(vopt_if openblas '="-lopenblas"') --with-lapack
+ --with-blas$(vopt_if openblas '=openblas') --with-lapack
  --enable-R-shlib --with-tcltk
  --enable-memory-profiling
  LIBnn=lib"
@@ -18,12 +18,12 @@ makedepends="libgomp-devel readline-devel libXmu-devel libXt-devel
 depends="xdg-utils less which"
 checkdepends="tzdata tar"
 short_desc="System for statistical computation and graphics"
-maintainer="Florian Wagner <florian@wagner-flo.net>"
+maintainer="Luke Hannan <lukehannan@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://www.r-project.org/"
 changelog="https://cran.r-project.org/doc/manuals/r-release/NEWS.html"
 distfiles="https://cran.r-project.org/src/base/R-4/${pkgname}-${version}.tar.gz"
-checksum=09983a8a78d5fb6bc45d27b1c55f9ba5265f78fa54a55c13ae691f87c5bb9e0d
+checksum=e8e68959d7282ca147360fc9644ada9bd161bab781bab14d33b8999a95182781
 nocross=yes
 shlib_provides="libR.so"
 make_check=extended

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Merged]: R: update to 4.1.0.
  2021-06-10 13:45 [PR PATCH] R: update to 4.1.0 luhann
                   ` (6 preceding siblings ...)
  2021-06-11 21:05 ` [PR PATCH] [Updated] " luhann
@ 2021-06-12  1:43 ` ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-06-12  1:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

There's a merged pull request on the void-packages repository

R: update to 4.1.0.
https://github.com/void-linux/void-packages/pull/31398

Description:
<!-- Mark items with [x] where applicable -->

#### General
Changed the way in which external blas was specified, as of R version 4.0.5 the old configuration no longer worked.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64)



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-06-12  1:43 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 13:45 [PR PATCH] R: update to 4.1.0 luhann
2021-06-10 17:30 ` ericonr
2021-06-11 14:20 ` luhann
2021-06-11 14:44 ` ericonr
2021-06-11 14:45 ` ericonr
2021-06-11 18:20 ` ericonr
2021-06-11 20:47 ` luhann
2021-06-11 21:05 ` [PR PATCH] [Updated] " luhann
2021-06-12  1:43 ` [PR PATCH] [Merged]: " ericonr

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git