[PR PATCH] New package: pleaser-0.4.1

[PR PATCH] New package: pleaser-0.4.1

[edneville]

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

There is a new pull request by edneville against master on the void-packages repository

https://github.com/edneville/void-packages pleaser-0.4.1
https://github.com/void-linux/void-packages/pull/31430

New package: pleaser-0.4.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl
-->

This was previously raised in #27037 but has since been reviewed by the SUSE security team.

A patch file from https://github.com/void-linux/void-packages/pull/31430.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pleaser-0.4.1-31430.patch --]
[-- Type: text/x-diff, Size: 1963 bytes --]

From a9c2fe5812844b132518a10a32764ad7600b1c32 Mon Sep 17 00:00:00 2001
From: ed neville <ed@s5h.net>
Date: Fri, 11 Jun 2021 20:33:09 +0000
Subject: [PATCH] New package: pleaser-0.4.1

---
 srcpkgs/pleaser/files/please.pam |  4 ++++
 srcpkgs/pleaser/template         | 31 +++++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+)
 create mode 100644 srcpkgs/pleaser/files/please.pam
 create mode 100644 srcpkgs/pleaser/template

diff --git a/srcpkgs/pleaser/files/please.pam b/srcpkgs/pleaser/files/please.pam
new file mode 100644
index 000000000000..10a4824b56e0
--- /dev/null
+++ b/srcpkgs/pleaser/files/please.pam
@@ -0,0 +1,4 @@
+#%PAM-1.0
+auth   include  system-auth
+account  include  system-auth
+session  include  system-auth
diff --git a/srcpkgs/pleaser/template b/srcpkgs/pleaser/template
new file mode 100644
index 000000000000..c64ef15fa8f1
--- /dev/null
+++ b/srcpkgs/pleaser/template
@@ -0,0 +1,31 @@
+# Template file for 'pleaser'
+pkgname=pleaser
+_binary=please
+version=0.4.1
+revision=1
+wrksrc="${_binary}-v${version}"
+build_style=cargo
+makedepends="cmake llvm clang pam-devel"
+short_desc="Polite and easy to configure regex-first sudo alternative"
+maintainer="Ed Neville <ed@s5h.net>"
+license="GPL-3.0-or-later"
+homepage="https://www.usenix.org.uk/content/please.html"
+distfiles="https://gitlab.com/edneville/${_binary}/-/archive/v${version}/${_binary}-v${version}.tar.gz"
+checksum=0c81449d57a6bbbf1577d6474349f845e9a8c7a074b27fd1a4ef119ccd4f3c64
+
+pre_build() {
+ export CFLAGS_${RUST_BUILD//-/_}="${CFLAGS_host}"
+ export CC_${RUST_BUILD//-/_}="${BUILD_CC}"
+}
+
+post_install() {
+ local manpage
+ vdoc README.md
+ manpage=$(find ${wrksrc} -name please.ini.5)
+ vman ${manpage}
+ manpage=$(find ${wrksrc} -name please.1)
+ vman ${manpage}
+ vinstall ${FILESDIR}/please.pam 644 etc/pam.d please
+ vinstall ${FILESDIR}/please.pam 644 etc/pam.d pleaseedit
+ chmod 4755 $DESTDIR/usr/bin/please $DESTDIR/usr/bin/pleaseedit
+}

Re: [PR REVIEW] New package: pleaser-0.4.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#discussion_r650311274

Comment:
Why not just call it `please`?

Re: [PR REVIEW] New package: pleaser-0.4.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#discussion_r650311302

Comment:
> `cmake llvm clang`

These aren't needed

Re: [PR REVIEW] New package: pleaser-0.4.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#discussion_r650311544

Comment:
I'm not sure these are needed, either.

Re: [PR REVIEW] New package: pleaser-0.4.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#discussion_r650312200

Comment:
I'd prefer it just be `vman man/please.ini.5` instead of using find

Re: [PR REVIEW] New package: pleaser-0.4.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#discussion_r650312455

Comment:
Indent with a tab instead of the space

Re: [PR PATCH] [Updated] New package: pleaser-0.4.1

[edneville]

[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]

There is an updated pull request by edneville against master on the void-packages repository

https://github.com/edneville/void-packages pleaser-0.4.1
https://github.com/void-linux/void-packages/pull/31430

New package: pleaser-0.4.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl
-->

This was previously raised in #27037 but has since been reviewed by the SUSE security team.

A patch file from https://github.com/void-linux/void-packages/pull/31430.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pleaser-0.4.1-31430.patch --]
[-- Type: text/x-diff, Size: 1798 bytes --]

From d9388f43669da70257791bd7251478ddb0800112 Mon Sep 17 00:00:00 2001
From: ed neville <ed@s5h.net>
Date: Fri, 11 Jun 2021 20:33:09 +0000
Subject: [PATCH] New package: please-0.4.1

---
 srcpkgs/please/files/please.pam |  4 ++++
 srcpkgs/please/template         | 28 ++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+)
 create mode 100644 srcpkgs/please/files/please.pam
 create mode 100644 srcpkgs/please/template

diff --git a/srcpkgs/please/files/please.pam b/srcpkgs/please/files/please.pam
new file mode 100644
index 000000000000..10a4824b56e0
--- /dev/null
+++ b/srcpkgs/please/files/please.pam
@@ -0,0 +1,4 @@
+#%PAM-1.0
+auth   include  system-auth
+account  include  system-auth
+session  include  system-auth
diff --git a/srcpkgs/please/template b/srcpkgs/please/template
new file mode 100644
index 000000000000..118b5f7e0afc
--- /dev/null
+++ b/srcpkgs/please/template
@@ -0,0 +1,28 @@
+# Template file for 'pleaser'
+pkgname=please
+_binary=please
+version=0.4.1
+revision=1
+wrksrc="${_binary}-v${version}"
+build_style=cargo
+makedepends="pam-devel"
+short_desc="Polite and easy to configure regex-first sudo alternative "
+maintainer="Ed Neville <ed@s5h.net>"
+license="GPL-3.0-or-later"
+homepage="https://www.usenix.org.uk/content/please.html"
+distfiles="https://gitlab.com/edneville/${_binary}/-/archive/v${version}/${_binary}-v${version}.tar.gz"
+checksum=0c81449d57a6bbbf1577d6474349f845e9a8c7a074b27fd1a4ef119ccd4f3c64
+
+pre_build() {
+	export CC_${RUST_BUILD//-/_}="${BUILD_CC}"
+}
+
+post_install() {
+	local manpage
+	vdoc README.md
+	vman man/please.ini.5
+	vman man/please.1
+	vinstall ${FILESDIR}/please.pam 644 etc/pam.d please
+	vinstall ${FILESDIR}/please.pam 644 etc/pam.d pleaseedit
+	chmod 4755 $DESTDIR/usr/bin/please $DESTDIR/usr/bin/pleaseedit
+}

Re: New package: pleaser-0.4.1

[edneville]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

New comment by edneville on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#issuecomment-860023893

Comment:
On 2021-06-11 16:39-0700, Andrew Benson wrote:
> +pkgname=pleaser
> 
> Why not just call it `please`?

@abenson, I'm happy for it to be named please here, which matches 
upstream naming.

Thanks for reviewing the template so far, I believe I've made the other 
corrections that you pointed out.

Re: [PR REVIEW] New package: pleaser-0.4.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#discussion_r650430057

Comment:
This is redundant now

Re: [PR REVIEW] New package: pleaser-0.4.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#discussion_r650430080

Comment:
I meant the whole pre_build() could go away

Re: [PR PATCH] [Updated] New package: pleaser-0.4.1

[edneville]

[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]

There is an updated pull request by edneville against master on the void-packages repository

https://github.com/edneville/void-packages pleaser-0.4.1
https://github.com/void-linux/void-packages/pull/31430

New package: pleaser-0.4.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl
-->

This was previously raised in #27037 but has since been reviewed by the SUSE security team.

A patch file from https://github.com/void-linux/void-packages/pull/31430.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pleaser-0.4.1-31430.patch --]
[-- Type: text/x-diff, Size: 1694 bytes --]

From c562957f5e51f4a51c92c8bc04327f35643b84a3 Mon Sep 17 00:00:00 2001
From: ed neville <ed@s5h.net>
Date: Fri, 11 Jun 2021 20:33:09 +0000
Subject: [PATCH] New package: please-0.4.1

---
 srcpkgs/please/files/please.pam |  4 ++++
 srcpkgs/please/template         | 22 ++++++++++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 srcpkgs/please/files/please.pam
 create mode 100644 srcpkgs/please/template

diff --git a/srcpkgs/please/files/please.pam b/srcpkgs/please/files/please.pam
new file mode 100644
index 000000000000..10a4824b56e0
--- /dev/null
+++ b/srcpkgs/please/files/please.pam
@@ -0,0 +1,4 @@
+#%PAM-1.0
+auth   include  system-auth
+account  include  system-auth
+session  include  system-auth
diff --git a/srcpkgs/please/template b/srcpkgs/please/template
new file mode 100644
index 000000000000..30eddfcf7be6
--- /dev/null
+++ b/srcpkgs/please/template
@@ -0,0 +1,22 @@
+# Template file for 'please'
+pkgname=please
+version=0.4.1
+revision=1
+wrksrc="${pkgname}-v${version}"
+build_style=cargo
+makedepends="pam-devel"
+short_desc="Polite and easy to configure regex-first sudo alternative "
+maintainer="Ed Neville <ed@s5h.net>"
+license="GPL-3.0-or-later"
+homepage="https://www.usenix.org.uk/content/please.html"
+distfiles="https://gitlab.com/edneville/${pkgname}/-/archive/v${version}/${pkgname}-v${version}.tar.gz"
+checksum=0c81449d57a6bbbf1577d6474349f845e9a8c7a074b27fd1a4ef119ccd4f3c64
+
+post_install() {
+	vdoc README.md
+	vman man/please.ini.5
+	vman man/please.1
+	vinstall ${FILESDIR}/please.pam 644 etc/pam.d please
+	vinstall ${FILESDIR}/please.pam 644 etc/pam.d pleaseedit
+	chmod 4755 $DESTDIR/usr/bin/please $DESTDIR/usr/bin/pleaseedit
+}

Re: New package: pleaser-0.4.1

[edneville]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New comment by edneville on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#issuecomment-860108885

Comment:
> +_binary=please

> +pre_build() {
> +	export CC_${RUST_BUILD//-/_}="${BUILD_CC}"
> +}

> +post_install() {
> +	local manpage

@abenson, I've updated the template, thanks for looking again

Re: New package: pleaser-0.4.1

[edneville]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by edneville on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#issuecomment-870917283

Comment:
Hello @abenson, are you happy to merge this now?

Re: New package: please-0.4.1

[edneville]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by edneville on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#issuecomment-884483126

Comment:
Hello @abenson, are you happy to merge this now?

Re: [PR PATCH] [Closed]: New package: please-0.4.1

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

There's a closed pull request on the void-packages repository

New package: please-0.4.1
https://github.com/void-linux/void-packages/pull/31430

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl
-->

This was previously raised in #27037 but has since been reviewed by the SUSE security team.

Re: New package: please-0.4.1

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/31430#issuecomment-884599534

Comment:
Thank you for your interest in Void Linux.  After significant internal discussion your request for this package has been rejected due to generally duplicated functionality already present in Void's repos, and concerns related to the security critical nature of the software.