Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] scribus: fix plugin loading, more functional support, fix update for 1.5
@ 2021-06-12 14:56 yopito
  2021-06-12 18:18 ` [PR PATCH] [Closed]: " ericonr
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: yopito @ 2021-06-12 14:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]

There is a new pull request by yopito against master on the void-packages repository

https://github.com/yopito/void-packages scribus.issue.31343
https://github.com/void-linux/void-packages/pull/31439

scribus: fix plugin loading, more functional support, fix update for 1.5
partially closes #31343 : some icons path are still invalid.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31439.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-scribus.issue.31343-31439.patch --]
[-- Type: text/x-diff, Size: 2776 bytes --]

From 3d33b1934c640a6a1e682fdc14edec6473f64336 Mon Sep 17 00:00:00 2001
From: yopito <pierre.bourgin@free.fr>
Date: Sat, 12 Jun 2021 16:34:48 +0200
Subject: [PATCH] scribus: fix plugin loading, more functional support, fix
 update for 1.5

partially closes #31343 : some icons path are still invalid.
---
 .../scribus/patches/export-symbols-for-plugins.patch  | 11 +++++++++++
 srcpkgs/scribus/template                              |  9 ++++++---
 srcpkgs/scribus/update                                |  2 +-
 3 files changed, 18 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/scribus/patches/export-symbols-for-plugins.patch

diff --git a/srcpkgs/scribus/patches/export-symbols-for-plugins.patch b/srcpkgs/scribus/patches/export-symbols-for-plugins.patch
new file mode 100644
index 000000000000..beefa78bda0c
--- /dev/null
+++ b/srcpkgs/scribus/patches/export-symbols-for-plugins.patch
@@ -0,0 +1,11 @@
+--- scribus/CMakeLists.txt.ORIG	2021-04-25 22:24:52.000000000 +0200
++++ scribus/CMakeLists.txt	2021-06-12 16:23:22.884229251 +0200
+@@ -757,7 +757,7 @@
+ # Should fix bug 6897 .
+ 	set_target_properties(${EXE_NAME} PROPERTIES LINK_FLAGS -Wl,-E)
+ endif ()
+-if (GCC AND NOT WIN32)
++if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT WIN32)
+ # Use the -E / --export-dynamic flag to ensure that symbols in the Scribus
+ # binary are in the public symbol table for plugins. The symbols must also
+ # be set as SCRIBUS_API if we're building with -fvisibility=hidden .
diff --git a/srcpkgs/scribus/template b/srcpkgs/scribus/template
index 9c7b0bfaa8fa..0898252efc43 100644
--- a/srcpkgs/scribus/template
+++ b/srcpkgs/scribus/template
@@ -1,13 +1,16 @@
 # Template file for 'scribus'
 pkgname=scribus
 version=1.5.7
-revision=2
+revision=3
 build_style=cmake
-configure_args="-DCMAKE_SKIP_RPATH=TRUE -DQT_PREFIX=${XBPS_CROSS_BASE}/usr"
+configure_args="-DCMAKE_SKIP_RPATH=TRUE -DQT_PREFIX=${XBPS_CROSS_BASE}/usr
+ -DWANT_GRAPHICSMAGICK=1"
 hostmakedepends="pkg-config qt5-qmake qt5-host-tools python3"
 makedepends="qt5-devel qt5-tools-devel zlib-devel cairo-devel lcms2-devel
  cups-devel libxml2-devel hyphen-devel ghostscript-devel boost-devel
- hunspell-devel poppler-cpp-devel python3-devel harfbuzz-devel"
+ hunspell-devel poppler-cpp-devel python3-devel harfbuzz-devel
+ libgraphicsmagick-devel libpodofo-devel libpagemaker-devel libqxp-devel
+ libmspub-devel libcdr-devel libfreehand-devel libvisio-devel"
 depends="ghostscript"
 short_desc="Open Source DTP (Desktop Publishing) application"
 maintainer="Enno Boland <gottox@voidlinux.org>"
diff --git a/srcpkgs/scribus/update b/srcpkgs/scribus/update
index ec25a5b370fa..ae3e56bb088a 100644
--- a/srcpkgs/scribus/update
+++ b/srcpkgs/scribus/update
@@ -1 +1 @@
-ignore="?.[13579].*"
+ignore="?.[1379].*"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: scribus: fix plugin loading, more functional support, fix update for 1.5
  2021-06-12 14:56 [PR PATCH] scribus: fix plugin loading, more functional support, fix update for 1.5 yopito
@ 2021-06-12 18:18 ` ericonr
  2021-06-12 18:18 ` ericonr
  2021-06-12 19:13 ` yopito
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-06-12 18:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

There's a closed pull request on the void-packages repository

scribus: fix plugin loading, more functional support, fix update for 1.5
https://github.com/void-linux/void-packages/pull/31439

Description:
partially closes #31343:
* 54 of 54 plugins are loaded
* new document can be saved
* some icons path are still invalid

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: scribus: fix plugin loading, more functional support, fix update for 1.5
  2021-06-12 14:56 [PR PATCH] scribus: fix plugin loading, more functional support, fix update for 1.5 yopito
  2021-06-12 18:18 ` [PR PATCH] [Closed]: " ericonr
@ 2021-06-12 18:18 ` ericonr
  2021-06-12 19:13 ` yopito
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-06-12 18:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31439#issuecomment-860090274

Comment:
I reworded the commit message and pushed, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: scribus: fix plugin loading, more functional support, fix update for 1.5
  2021-06-12 14:56 [PR PATCH] scribus: fix plugin loading, more functional support, fix update for 1.5 yopito
  2021-06-12 18:18 ` [PR PATCH] [Closed]: " ericonr
  2021-06-12 18:18 ` ericonr
@ 2021-06-12 19:13 ` yopito
  2 siblings, 0 replies; 4+ messages in thread
From: yopito @ 2021-06-12 19:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by yopito on void-packages repository

https://github.com/void-linux/void-packages/pull/31439#issuecomment-860096768

Comment:
thanks @ericonr, commit  message is better now.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-12 19:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 14:56 [PR PATCH] scribus: fix plugin loading, more functional support, fix update for 1.5 yopito
2021-06-12 18:18 ` [PR PATCH] [Closed]: " ericonr
2021-06-12 18:18 ` ericonr
2021-06-12 19:13 ` yopito

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).