Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] eid-mw: update to 5.0.23
@ 2021-06-14 10:54 PoroCYon
  2021-06-14 11:26 ` ericonr
  2021-06-14 11:26 ` [PR PATCH] [Merged]: " ericonr
  0 siblings, 2 replies; 3+ messages in thread
From: PoroCYon @ 2021-06-14 10:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2061 bytes --]

There is a new pull request by PoroCYon against master on the void-packages repository

https://github.com/PoroCYon/void-packages eid-mw-5.0.22
https://github.com/void-linux/void-packages/pull/31477

eid-mw: update to 5.0.23
Right after the PR for the 5.0.22 update got merged, I heard [this](https://github.com/Fedict/eid-mw/pull/142#issuecomment-860584295) from the eid-mw maintainer:

> Side note though: 5.0.22 contains a small, but critical, bug in the validation code of the eid-viewer, which means that under certain circumstances, cards with corrupt data may be considered valid eID cards. The bug was fixed in 5.0.23. Please update to that :-)

Sorry for the inconvenience.

-----

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_66-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/31477.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-eid-mw-5.0.22-31477.patch --]
[-- Type: text/x-diff, Size: 3142 bytes --]

From f9494842e28075ce747e3fa56a8768f58ae4b02a Mon Sep 17 00:00:00 2001
From: PoroCYon <porocyon@titandemo.org>
Date: Mon, 14 Jun 2021 12:48:04 +0200
Subject: [PATCH] eid-mw: update to 5.0.23

---
 ...-int8_t-errors-when-compiling-for-aa.patch | 58 -------------------
 srcpkgs/eid-mw/template                       |  4 +-
 2 files changed, 2 insertions(+), 60 deletions(-)
 delete mode 100644 srcpkgs/eid-mw/patches/0001-fix-unknown-type-int8_t-errors-when-compiling-for-aa.patch

diff --git a/srcpkgs/eid-mw/patches/0001-fix-unknown-type-int8_t-errors-when-compiling-for-aa.patch b/srcpkgs/eid-mw/patches/0001-fix-unknown-type-int8_t-errors-when-compiling-for-aa.patch
deleted file mode 100644
index 87a21def3d87..000000000000
--- a/srcpkgs/eid-mw/patches/0001-fix-unknown-type-int8_t-errors-when-compiling-for-aa.patch
+++ /dev/null
@@ -1,58 +0,0 @@
-From 0da930d0d2bf7c3f840cbcdf8d2eb3a411868fae Mon Sep 17 00:00:00 2001
-From: PoroCYon <porocyon@titandemo.org>
-Date: Wed, 2 Jun 2021 13:57:00 +0200
-Subject: [PATCH] fix 'unknown type int8_t' errors when compiling for
- aarch64-musl
-
----
- plugins_tools/eid-viewer/test/testlib.c | 4 ++--
- tests/unit/testlib.c                    | 4 ++--
- 2 files changed, 4 insertions(+), 4 deletions(-)
-
-diff --git plugins_tools/eid-viewer/test/testlib.c plugins_tools/eid-viewer/test/testlib.c
-index 91b381a8..c1794229 100644
---- plugins_tools/eid-viewer/test/testlib.c
-+++ plugins_tools/eid-viewer/test/testlib.c
-@@ -23,8 +23,6 @@
- #pragma pack(push, cryptoki, 1)
- #include "pkcs11.h"
- #pragma pack(pop, cryptoki)
--#include <stdio.h>
--#include <stdint.h>
- #include <tchar.h>
- #else
- #include <unix.h>
-@@ -38,6 +36,8 @@
- #include <stdarg.h>
- #include <stdbool.h>
- #include <errno.h>
-+#include <stdio.h>
-+#include <stdint.h>
- 
- 
- #include "serial_io.h"
-diff --git tests/unit/testlib.c tests/unit/testlib.c
-index 32c77a73..0c1b0fe2 100644
---- tests/unit/testlib.c
-+++ tests/unit/testlib.c
-@@ -23,8 +23,6 @@
- #pragma pack(push, cryptoki, 1)
- #include "pkcs11.h"
- #pragma pack(pop, cryptoki)
--#include <stdio.h>
--#include <stdint.h>
- #include <tchar.h>
- #else
- #include <unix.h>
-@@ -37,6 +35,8 @@
- #include <stdarg.h>
- #include <stdbool.h>
- #include <errno.h>
-+#include <stdio.h>
-+#include <stdint.h>
- 
- #include "testlib.h"
- 
--- 
-2.31.1
-
diff --git a/srcpkgs/eid-mw/template b/srcpkgs/eid-mw/template
index 9c3b471009f3..8a4cd9118f63 100644
--- a/srcpkgs/eid-mw/template
+++ b/srcpkgs/eid-mw/template
@@ -1,6 +1,6 @@
 # Template file for 'eid-mw'
 pkgname=eid-mw
-version=5.0.22
+version=5.0.23
 revision=1
 build_style=gnu-configure
 hostmakedepends="pkg-config automake gettext gettext-devel libtool glib-devel
@@ -13,7 +13,7 @@ maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="LGPL-3.0-or-later"
 homepage="https://eid.belgium.be/en"
 distfiles="https://github.com/Fedict/eid-mw/archive/v${version}.tar.gz"
-checksum=c4ed06a4146de95b10de5056b9c174a85cd71c7a794f2f0faf010d51c8792a59
+checksum=ea33f974ac203414cffb1e65378407e5e17f4cfafc10191727d1e2fcae6735f6
 
 if [ "$XBPS_TARGET_LIBC" = "glibc" ]; then
 	makedepends+=" libbsd-devel"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: eid-mw: update to 5.0.23
  2021-06-14 10:54 [PR PATCH] eid-mw: update to 5.0.23 PoroCYon
@ 2021-06-14 11:26 ` ericonr
  2021-06-14 11:26 ` [PR PATCH] [Merged]: " ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-06-14 11:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31477#issuecomment-860610356

Comment:
No worries, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: eid-mw: update to 5.0.23
  2021-06-14 10:54 [PR PATCH] eid-mw: update to 5.0.23 PoroCYon
  2021-06-14 11:26 ` ericonr
@ 2021-06-14 11:26 ` ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-06-14 11:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]

There's a merged pull request on the void-packages repository

eid-mw: update to 5.0.23
https://github.com/void-linux/void-packages/pull/31477

Description:
Right after the PR for the 5.0.22 update got merged, I heard [this](https://github.com/Fedict/eid-mw/pull/142#issuecomment-860584295) from the eid-mw maintainer:

> Side note though: 5.0.22 contains a small, but critical, bug in the validation code of the eid-viewer, which means that under certain circumstances, cards with corrupt data may be considered valid eID cards. The bug was fixed in 5.0.23. Please update to that :-)

Sorry for the inconvenience.

-----

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-14 11:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-14 10:54 [PR PATCH] eid-mw: update to 5.0.23 PoroCYon
2021-06-14 11:26 ` ericonr
2021-06-14 11:26 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).