Github messages for voidlinux
 help / color / mirror / Atom feed
From: not-chicken <not-chicken@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] gnome-font-viewer: needs gettext in hostmakedepends.
Date: Thu, 01 Jul 2021 10:47:02 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31734@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]

There is a new pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages gfv
https://github.com/void-linux/void-packages/pull/31734

gnome-font-viewer: needs gettext in hostmakedepends.
This also fixes the lack of desktop file, as package installs translated file
which was getting ignored when gettext was not found on the host system:
https://gitlab.gnome.org/GNOME/gnome-font-viewer/-/blob/1e5b/src/meson.build#L42

Fixes #31730

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gfv-31734.patch --]
[-- Type: text/x-diff, Size: 1144 bytes --]

From ca681f067144f657dbae42ce1139b68be5fe5cd9 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Thu, 1 Jul 2021 13:49:09 +0530
Subject: [PATCH] gnome-font-viewer: needs gettext in hostmakedepends.

This also fixes the lack of desktop file, as package installs translated file
which was getting ignored when gettext was not found on the host system:
https://gitlab.gnome.org/GNOME/gnome-font-viewer/-/blob/1e5b/src/meson.build#L42
---
 srcpkgs/gnome-font-viewer/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnome-font-viewer/template b/srcpkgs/gnome-font-viewer/template
index 92748bbb386e..61d1e9cfc756 100644
--- a/srcpkgs/gnome-font-viewer/template
+++ b/srcpkgs/gnome-font-viewer/template
@@ -1,9 +1,9 @@
 # Template file for 'gnome-font-viewer'
 pkgname=gnome-font-viewer
 version=40.0
-revision=1
+revision=2
 build_style=meson
-hostmakedepends="pkg-config glib-devel"
+hostmakedepends="pkg-config glib-devel gettext"
 makedepends="fontconfig-devel freetype-devel glib-devel gtk+3-devel
  gnome-desktop-devel harfbuzz-devel libhandy1-devel"
 depends="desktop-file-utils"

             reply	other threads:[~2021-07-01  8:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  8:47 not-chicken [this message]
2021-07-01 12:48 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31734@inbox.vuxu.org \
    --to=not-chicken@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).