[PR PATCH] python3-mpd2: update to 3.0.4, fix bum

[PR PATCH] python3-mpd2: update to 3.0.4, fix bum

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages python3-mpd2-3
https://github.com/void-linux/void-packages/pull/31911

python3-mpd2: update to 3.0.4, fix bum
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

I tested almost all the dependants:

* sonata 1.7b1 and 1.7.0 - work fine
* mpdevil - works fine
* python3-mpdnotify - works fine
* bum - works with a small patch, then kind of works, but crashes in different places, but that's not related to a python3-mpd2 update
* mpDris2 - crashes for me, apparently that's an upstream bug specific to my configuration, but I think it's safe to assume it works, because alpine packages only one package which depends on python3-mpd2 - mpdris2, so it's probably well tested there. If someone could test this in a non-GNOME environment, that would be nice.

A patch file from https://github.com/void-linux/void-packages/pull/31911.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-mpd2-3-31911.patch --]
[-- Type: text/x-diff, Size: 3014 bytes --]

From 0dbc58e09b50bfa13de96b5597a43de3c6561387 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 11 Jul 2021 20:17:31 +0200
Subject: [PATCH 1/2] python3-mpd2: update to 3.0.4.

---
 srcpkgs/python3-mpd2/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-mpd2/template b/srcpkgs/python3-mpd2/template
index 29ecea48b682..042cd65b6c34 100644
--- a/srcpkgs/python3-mpd2/template
+++ b/srcpkgs/python3-mpd2/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-mpd2'
 pkgname=python3-mpd2
-version=1.0.0
-revision=4
+version=3.0.4
+revision=1
 wrksrc=python-mpd2-$version
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -12,7 +12,7 @@ maintainer="Jens E. Becker <v2px@v2px.de>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/Mic92/python-mpd2"
 distfiles="https://github.com/Mic92/python-mpd2/archive/v${version}.tar.gz"
-checksum=877fa1685a56815107cb0b1eb004e7fe261b620fafd4d38cdaa2b6f3edd35928
+checksum=05ac5d339932f5d0557cb10c43bf4f1df74937f660125cf7fdd0f1691da98278
 
 do_check() {
 	python3 -m unittest mpd.tests

From d0edfe24acabf7fa7f7781e49cfefbc2dcfb406c Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 11 Jul 2021 20:17:41 +0200
Subject: [PATCH 2/2] bum: fix for python3-mpd2 v3

---
 srcpkgs/bum/patches/mpd2-3.patch | 17 +++++++++++++++++
 srcpkgs/bum/template             |  6 +++---
 2 files changed, 20 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/bum/patches/mpd2-3.patch

diff --git a/srcpkgs/bum/patches/mpd2-3.patch b/srcpkgs/bum/patches/mpd2-3.patch
new file mode 100644
index 000000000000..c576bf52cb28
--- /dev/null
+++ b/srcpkgs/bum/patches/mpd2-3.patch
@@ -0,0 +1,17 @@
+based on https://github.com/dylanaraps/bum/pull/24
+--- a/bum/__main__.py
++++ b/bum/__main__.py
+@@ -62,11 +62,8 @@ def main():
+     while True:
+         song.get_art(args.cache_dir, args.size, client)
+         display.launch(disp, args.cache_dir / "current.jpg")
+-        client.send_idle()
+-
+-        if client.fetch_idle(["player"]):
+-            print("album: Received player event from mpd. Swapping cover art.")
+-            continue
++        client.idle("player")
++        print("album: Received player event from mpd. Swapping cover art.")
+ 
+ 
+ if __name__ == "__main__":
diff --git a/srcpkgs/bum/template b/srcpkgs/bum/template
index dd8f302132ff..5f68ece3fd72 100644
--- a/srcpkgs/bum/template
+++ b/srcpkgs/bum/template
@@ -1,11 +1,11 @@
 # Template file for 'bum'
 pkgname=bum
 version=0.1.3
-revision=5
+revision=6
 build_style=python3-module
-pycompile_module="bum"
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-mpd2 python3-musicbrainzngs python3-mpv"
+depends="python3-mpd2 python3-musicbrainzngs python3-mpv"
+checkdepends="python3-pytest python3-mpd2 python3-gobject gtk+3"
 short_desc="Daemon that downloads and displays album arts via MPD events"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"

Re: [PR PATCH] [Updated] python3-mpd2: update to 3.0.4, fix bum

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages python3-mpd2-3
https://github.com/void-linux/void-packages/pull/31911

python3-mpd2: update to 3.0.4, fix bum
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

I tested almost all the dependants:

* sonata 1.7b1 and 1.7.0 - work fine
* mpdevil - works fine
* python3-mpdnotify - works fine
* bum - works with a small patch, then kind of works, but crashes in different places, but that's not related to a python3-mpd2 update
* mpDris2 - crashes for me, apparently that's an upstream bug specific to my configuration, but I think it's safe to assume it works, because alpine packages only one package which depends on python3-mpd2 - mpdris2, so it's probably well tested there. If someone could test this in a non-GNOME environment, that would be nice.

A patch file from https://github.com/void-linux/void-packages/pull/31911.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-mpd2-3-31911.patch --]
[-- Type: text/x-diff, Size: 3320 bytes --]

From 0dbc58e09b50bfa13de96b5597a43de3c6561387 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 11 Jul 2021 20:17:31 +0200
Subject: [PATCH 1/2] python3-mpd2: update to 3.0.4.

---
 srcpkgs/python3-mpd2/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-mpd2/template b/srcpkgs/python3-mpd2/template
index 29ecea48b682..042cd65b6c34 100644
--- a/srcpkgs/python3-mpd2/template
+++ b/srcpkgs/python3-mpd2/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-mpd2'
 pkgname=python3-mpd2
-version=1.0.0
-revision=4
+version=3.0.4
+revision=1
 wrksrc=python-mpd2-$version
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -12,7 +12,7 @@ maintainer="Jens E. Becker <v2px@v2px.de>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/Mic92/python-mpd2"
 distfiles="https://github.com/Mic92/python-mpd2/archive/v${version}.tar.gz"
-checksum=877fa1685a56815107cb0b1eb004e7fe261b620fafd4d38cdaa2b6f3edd35928
+checksum=05ac5d339932f5d0557cb10c43bf4f1df74937f660125cf7fdd0f1691da98278
 
 do_check() {
 	python3 -m unittest mpd.tests

From 58d9a9acbec51fe4dd394ea699a42e400421b907 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 11 Jul 2021 20:17:41 +0200
Subject: [PATCH 2/2] bum: fix for python3-mpd2 v3

---
 srcpkgs/bum/patches/mpd2-3.patch | 17 +++++++++++++++++
 srcpkgs/bum/template             |  7 ++++---
 2 files changed, 21 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/bum/patches/mpd2-3.patch

diff --git a/srcpkgs/bum/patches/mpd2-3.patch b/srcpkgs/bum/patches/mpd2-3.patch
new file mode 100644
index 000000000000..c576bf52cb28
--- /dev/null
+++ b/srcpkgs/bum/patches/mpd2-3.patch
@@ -0,0 +1,17 @@
+based on https://github.com/dylanaraps/bum/pull/24
+--- a/bum/__main__.py
++++ b/bum/__main__.py
+@@ -62,11 +62,8 @@ def main():
+     while True:
+         song.get_art(args.cache_dir, args.size, client)
+         display.launch(disp, args.cache_dir / "current.jpg")
+-        client.send_idle()
+-
+-        if client.fetch_idle(["player"]):
+-            print("album: Received player event from mpd. Swapping cover art.")
+-            continue
++        client.idle("player")
++        print("album: Received player event from mpd. Swapping cover art.")
+ 
+ 
+ if __name__ == "__main__":
diff --git a/srcpkgs/bum/template b/srcpkgs/bum/template
index dd8f302132ff..6782b292b0b6 100644
--- a/srcpkgs/bum/template
+++ b/srcpkgs/bum/template
@@ -1,17 +1,18 @@
 # Template file for 'bum'
 pkgname=bum
 version=0.1.3
-revision=5
+revision=6
 build_style=python3-module
-pycompile_module="bum"
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-mpd2 python3-musicbrainzngs python3-mpv"
+depends="python3-mpd2 python3-musicbrainzngs python3-mpv"
+checkdepends="python3-pytest python3-mpd2 python3-gobject gtk+3"
 short_desc="Daemon that downloads and displays album arts via MPD events"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="https://github.com/dylanaraps/bum"
 distfiles="https://github.com/dylanaraps/bum/archive/${version}.tar.gz"
 checksum=512b64d2fbd0d96b1c242f5e2b916c126671bd16dfbb5c71d164a39b5ebeeebe
+make_check=no # no tests, but check fails with a non-zero exit code
 
 post_install() {
 	vlicense LICENSE.md

Re: [PR REVIEW] python3-mpd2: update to 3.0.4, fix bum

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31911#discussion_r671604442

Comment:
I think we should skip `checkdepends`, then.

Re: [PR PATCH] [Updated] python3-mpd2: update to 3.0.4, fix bum

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages python3-mpd2-3
https://github.com/void-linux/void-packages/pull/31911

python3-mpd2: update to 3.0.4, fix bum
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

I tested almost all the dependants:

* sonata 1.7b1 and 1.7.0 - work fine
* mpdevil - works fine
* python3-mpdnotify - works fine
* bum - works with a small patch, then kind of works, but crashes in different places, but that's not related to a python3-mpd2 update
* mpDris2 - crashes for me, apparently that's an upstream bug specific to my configuration, but I think it's safe to assume it works, because alpine packages only one package which depends on python3-mpd2 - mpdris2, so it's probably well tested there. If someone could test this in a non-GNOME environment, that would be nice.

A patch file from https://github.com/void-linux/void-packages/pull/31911.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-mpd2-3-31911.patch --]
[-- Type: text/x-diff, Size: 3253 bytes --]

From 85465f77e667c682f15bd670c089d3be553cca9f Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 11 Jul 2021 20:17:31 +0200
Subject: [PATCH 1/2] python3-mpd2: update to 3.0.4.

---
 srcpkgs/python3-mpd2/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-mpd2/template b/srcpkgs/python3-mpd2/template
index 29ecea48b682..042cd65b6c34 100644
--- a/srcpkgs/python3-mpd2/template
+++ b/srcpkgs/python3-mpd2/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-mpd2'
 pkgname=python3-mpd2
-version=1.0.0
-revision=4
+version=3.0.4
+revision=1
 wrksrc=python-mpd2-$version
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -12,7 +12,7 @@ maintainer="Jens E. Becker <v2px@v2px.de>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/Mic92/python-mpd2"
 distfiles="https://github.com/Mic92/python-mpd2/archive/v${version}.tar.gz"
-checksum=877fa1685a56815107cb0b1eb004e7fe261b620fafd4d38cdaa2b6f3edd35928
+checksum=05ac5d339932f5d0557cb10c43bf4f1df74937f660125cf7fdd0f1691da98278
 
 do_check() {
 	python3 -m unittest mpd.tests

From 627c24651eb296457423b14fc2b511427acbaef9 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 11 Jul 2021 20:17:41 +0200
Subject: [PATCH 2/2] bum: fix for python3-mpd2 v3

---
 srcpkgs/bum/patches/mpd2-3.patch | 17 +++++++++++++++++
 srcpkgs/bum/template             |  6 +++---
 2 files changed, 20 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/bum/patches/mpd2-3.patch

diff --git a/srcpkgs/bum/patches/mpd2-3.patch b/srcpkgs/bum/patches/mpd2-3.patch
new file mode 100644
index 000000000000..c576bf52cb28
--- /dev/null
+++ b/srcpkgs/bum/patches/mpd2-3.patch
@@ -0,0 +1,17 @@
+based on https://github.com/dylanaraps/bum/pull/24
+--- a/bum/__main__.py
++++ b/bum/__main__.py
+@@ -62,11 +62,8 @@ def main():
+     while True:
+         song.get_art(args.cache_dir, args.size, client)
+         display.launch(disp, args.cache_dir / "current.jpg")
+-        client.send_idle()
+-
+-        if client.fetch_idle(["player"]):
+-            print("album: Received player event from mpd. Swapping cover art.")
+-            continue
++        client.idle("player")
++        print("album: Received player event from mpd. Swapping cover art.")
+ 
+ 
+ if __name__ == "__main__":
diff --git a/srcpkgs/bum/template b/srcpkgs/bum/template
index dd8f302132ff..5d11f493717d 100644
--- a/srcpkgs/bum/template
+++ b/srcpkgs/bum/template
@@ -1,17 +1,17 @@
 # Template file for 'bum'
 pkgname=bum
 version=0.1.3
-revision=5
+revision=6
 build_style=python3-module
-pycompile_module="bum"
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-mpd2 python3-musicbrainzngs python3-mpv"
+depends="python3-mpd2 python3-musicbrainzngs python3-mpv"
 short_desc="Daemon that downloads and displays album arts via MPD events"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="https://github.com/dylanaraps/bum"
 distfiles="https://github.com/dylanaraps/bum/archive/${version}.tar.gz"
 checksum=512b64d2fbd0d96b1c242f5e2b916c126671bd16dfbb5c71d164a39b5ebeeebe
+make_check=no # no tests, but check fails with a non-zero exit code
 
 post_install() {
 	vlicense LICENSE.md

Re: [PR PATCH] [Merged]: python3-mpd2: update to 3.0.4, fix bum

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

There's a merged pull request on the void-packages repository

python3-mpd2: update to 3.0.4, fix bum
https://github.com/void-linux/void-packages/pull/31911

Description:
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

I tested almost all the dependants:

* sonata 1.7b1 and 1.7.0 - work fine
* mpdevil - works fine
* python3-mpdnotify - works fine
* bum - works with a small patch, then kind of works, but crashes in different places, but that's not related to a python3-mpd2 update
* mpDris2 - crashes for me, apparently that's an upstream bug specific to my configuration, but I think it's safe to assume it works, because alpine packages only one package which depends on python3-mpd2 - mpdris2, so it's probably well tested there. If someone could test this in a non-GNOME environment, that would be nice.

Re: python3-mpd2: update to 3.0.4, fix bum

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31911#issuecomment-883630727

Comment:
Last actual commit in `bum` was 40579da7fcbc15bfb701c62fca3a14610fa7f65a, we could consider removal.