[PR PATCH] ffmpeg: split ffplay

[PR PATCH] ffmpeg: split ffplay

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages ffmpeg-split-ffplay
https://github.com/void-linux/void-packages/pull/32170

ffmpeg: split ffplay
ffplay depends on SDL2 which has a lot of dependencies, some systems
like servers may wish to install ffmpeg, but without ffplay to avoid
the SDL2 dependency.

I think it would be nice if ffmpeg didn't depend on ffplay, but that could break for some people. Should I remove the dependency?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/32170.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffmpeg-split-ffplay-32170.patch --]
[-- Type: text/x-diff, Size: 1809 bytes --]

From fa0de6b7cbf24c81c5da128d9abfff9a9f483cfb Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 24 Jul 2021 16:16:08 +0200
Subject: [PATCH] ffmpeg: split ffplay

ffplay depends on SDL2 which has a lot of dependencies, some systems
like servers may wish to install ffmpeg, but without ffplay to avoid
the SDL2 dependency
---
 srcpkgs/ffmpeg/template | 10 +++++++++-
 srcpkgs/ffplay          |  1 +
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/ffplay

diff --git a/srcpkgs/ffmpeg/template b/srcpkgs/ffmpeg/template
index e6667478fe13..94192e9ff1b7 100644
--- a/srcpkgs/ffmpeg/template
+++ b/srcpkgs/ffmpeg/template
@@ -2,7 +2,7 @@
 # audacity also needs to be bumped when a new ffmpeg version bumps libavformat's soname!
 pkgname=ffmpeg
 version=4.3.2
-revision=1
+revision=2
 short_desc="Decoding, encoding and streaming software"
 maintainer="Johannes <johannes.brechtmann@gmail.com>"
 license="GPL-3.0-or-later"
@@ -24,6 +24,7 @@ makedepends="zlib-devel bzip2-devel freetype-devel alsa-lib-devel libXfixes-deve
  $(vopt_if nvenc nv-codec-headers) $(vopt_if sndio sndio-devel)
  $(vopt_if dav1d libdav1d-devel) $(vopt_if zimg zimg-devel)
  $(vopt_if webp libwebp-devel) $(vopt_if sofa libmysofa-devel)"
+depends="ffplay"
 
 build_options="x265 v4l2 vaapi vdpau vpx faac fdk_aac aom nvenc sndio pulseaudio
  dav1d zimg webp sofa"
@@ -183,3 +184,10 @@ ffmpeg-devel_package() {
 		vmove usr/share/man/man3
 	}
 }
+ffplay_package() {
+	short_desc+="FFmpeg video resampling library"
+	pkg_install() {
+		vmove usr/bin/ffplay
+		vmove "usr/share/man/man1/ffplay*"
+	}
+}
diff --git a/srcpkgs/ffplay b/srcpkgs/ffplay
new file mode 120000
index 000000000000..a9f1eea092d5
--- /dev/null
+++ b/srcpkgs/ffplay
@@ -0,0 +1 @@
+ffmpeg
\ No newline at end of file

Re: [PR REVIEW] ffmpeg: split ffplay

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32170#discussion_r676043091

Comment:
So make it possible to `ignorepkg` it, basically? And I think this should use `ffplay>=${version}_${revision}`

Re: [PR PATCH] [Updated] ffmpeg: split ffplay

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages ffmpeg-split-ffplay
https://github.com/void-linux/void-packages/pull/32170

ffmpeg: split ffplay
ffplay depends on SDL2 which has a lot of dependencies, some systems
like servers may wish to install ffmpeg, but without ffplay to avoid
the SDL2 dependency.

I think it would be nice if ffmpeg didn't depend on ffplay, but that could break for some people. Should I remove the dependency?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/32170.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffmpeg-split-ffplay-32170.patch --]
[-- Type: text/x-diff, Size: 1828 bytes --]

From 83565891a2b091fc13a59e22c7b6895df8bb3843 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 24 Jul 2021 16:16:08 +0200
Subject: [PATCH] ffmpeg: split ffplay

ffplay depends on SDL2 which has a lot of dependencies, some systems
like servers may wish to install ffmpeg without ffplay to avoid the
SDL2 dependency
---
 srcpkgs/ffmpeg/template | 10 +++++++++-
 srcpkgs/ffplay          |  1 +
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/ffplay

diff --git a/srcpkgs/ffmpeg/template b/srcpkgs/ffmpeg/template
index e6667478fe13..966c4e3b441b 100644
--- a/srcpkgs/ffmpeg/template
+++ b/srcpkgs/ffmpeg/template
@@ -2,7 +2,7 @@
 # audacity also needs to be bumped when a new ffmpeg version bumps libavformat's soname!
 pkgname=ffmpeg
 version=4.3.2
-revision=1
+revision=2
 short_desc="Decoding, encoding and streaming software"
 maintainer="Johannes <johannes.brechtmann@gmail.com>"
 license="GPL-3.0-or-later"
@@ -24,6 +24,7 @@ makedepends="zlib-devel bzip2-devel freetype-devel alsa-lib-devel libXfixes-deve
  $(vopt_if nvenc nv-codec-headers) $(vopt_if sndio sndio-devel)
  $(vopt_if dav1d libdav1d-devel) $(vopt_if zimg zimg-devel)
  $(vopt_if webp libwebp-devel) $(vopt_if sofa libmysofa-devel)"
+depends="ffplay>=${version}_${revision}"
 
 build_options="x265 v4l2 vaapi vdpau vpx faac fdk_aac aom nvenc sndio pulseaudio
  dav1d zimg webp sofa"
@@ -183,3 +184,10 @@ ffmpeg-devel_package() {
 		vmove usr/share/man/man3
 	}
 }
+ffplay_package() {
+	short_desc+="FFmpeg video resampling library"
+	pkg_install() {
+		vmove usr/bin/ffplay
+		vmove "usr/share/man/man1/ffplay*"
+	}
+}
diff --git a/srcpkgs/ffplay b/srcpkgs/ffplay
new file mode 120000
index 000000000000..a9f1eea092d5
--- /dev/null
+++ b/srcpkgs/ffplay
@@ -0,0 +1 @@
+ffmpeg
\ No newline at end of file

Re: [PR REVIEW] ffmpeg: split ffplay

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32170#discussion_r676884317

Comment:
shortdesc seems wrong, this isn't the library...

Re: [PR PATCH] [Updated] ffmpeg: split ffplay

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages ffmpeg-split-ffplay
https://github.com/void-linux/void-packages/pull/32170

ffmpeg: split ffplay
ffplay depends on SDL2 which has a lot of dependencies, some systems
like servers may wish to install ffmpeg, but without ffplay to avoid
the SDL2 dependency.

I think it would be nice if ffmpeg didn't depend on ffplay, but that could break for some people. Should I remove the dependency?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/32170.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffmpeg-split-ffplay-32170.patch --]
[-- Type: text/x-diff, Size: 1837 bytes --]

From 9283efe93dda34c7955cea44ddefc5e3e3250b90 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 24 Jul 2021 16:16:08 +0200
Subject: [PATCH] ffmpeg: split ffplay

ffplay depends on SDL2 which has a lot of dependencies, some systems
like servers may wish to install ffmpeg without ffplay to avoid the
SDL2 dependency
---
 srcpkgs/ffmpeg/template | 10 +++++++++-
 srcpkgs/ffplay          |  1 +
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/ffplay

diff --git a/srcpkgs/ffmpeg/template b/srcpkgs/ffmpeg/template
index e6667478fe13..6a7510d3adc3 100644
--- a/srcpkgs/ffmpeg/template
+++ b/srcpkgs/ffmpeg/template
@@ -2,7 +2,7 @@
 # audacity also needs to be bumped when a new ffmpeg version bumps libavformat's soname!
 pkgname=ffmpeg
 version=4.3.2
-revision=1
+revision=2
 short_desc="Decoding, encoding and streaming software"
 maintainer="Johannes <johannes.brechtmann@gmail.com>"
 license="GPL-3.0-or-later"
@@ -24,6 +24,7 @@ makedepends="zlib-devel bzip2-devel freetype-devel alsa-lib-devel libXfixes-deve
  $(vopt_if nvenc nv-codec-headers) $(vopt_if sndio sndio-devel)
  $(vopt_if dav1d libdav1d-devel) $(vopt_if zimg zimg-devel)
  $(vopt_if webp libwebp-devel) $(vopt_if sofa libmysofa-devel)"
+depends="ffplay>=${version}_${revision}"
 
 build_options="x265 v4l2 vaapi vdpau vpx faac fdk_aac aom nvenc sndio pulseaudio
  dav1d zimg webp sofa"
@@ -183,3 +184,10 @@ ffmpeg-devel_package() {
 		vmove usr/share/man/man3
 	}
 }
+ffplay_package() {
+	short_desc="Simple video player using FFmpeg and SDL2"
+	pkg_install() {
+		vmove usr/bin/ffplay
+		vmove "usr/share/man/man1/ffplay*"
+	}
+}
diff --git a/srcpkgs/ffplay b/srcpkgs/ffplay
new file mode 120000
index 000000000000..a9f1eea092d5
--- /dev/null
+++ b/srcpkgs/ffplay
@@ -0,0 +1 @@
+ffmpeg
\ No newline at end of file

Re: [PR REVIEW] ffmpeg: split ffplay

[paper42]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32170#discussion_r676939309

Comment:
oops, good catch

Re: [PR PATCH] [Merged]: ffmpeg: split ffplay

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

There's a merged pull request on the void-packages repository

ffmpeg: split ffplay
https://github.com/void-linux/void-packages/pull/32170

Description:
ffplay depends on SDL2 which has a lot of dependencies, some systems
like servers may wish to install ffmpeg, but without ffplay to avoid
the SDL2 dependency.

I think it would be nice if ffmpeg didn't depend on ffplay, but that could break for some people. Should I remove the dependency?

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR