Github messages for voidlinux
 help / color / mirror / Atom feed
From: vokar <vokar@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] protonvpn-cli: add missing dependency
Date: Fri, 06 Aug 2021 21:37:09 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32374@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

There is a new pull request by vokar against master on the void-packages repository

https://github.com/vokar/void-packages protonvpn-cli
https://github.com/void-linux/void-packages/pull/32374

protonvpn-cli: add missing dependency
After updating protonvpn-cli (#32299), I started getting `ModuleNotFoundError: No module named 'distro'`. Turns out it's because `protonvpn-cli` uses the new [`distro`](https://github.com/python-distro/distro) dependency starting from version 2.2.8 (see ProtonVPN/linux-cli-community@117f5972ab09d44b5df07ffb88b120db9392c515).

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/32374.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-protonvpn-cli-32374.patch --]
[-- Type: text/x-diff, Size: 1062 bytes --]

From 42bd94cd916786bf0e1a910e970b77503e5eecc0 Mon Sep 17 00:00:00 2001
From: Vo Kar <vokar97@pm.me>
Date: Fri, 6 Aug 2021 21:27:50 +0300
Subject: [PATCH] protonvpn-cli: add missing dependency

---
 srcpkgs/protonvpn-cli/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/protonvpn-cli/template b/srcpkgs/protonvpn-cli/template
index c9a3c784ace6..329b21026c3e 100644
--- a/srcpkgs/protonvpn-cli/template
+++ b/srcpkgs/protonvpn-cli/template
@@ -1,12 +1,12 @@
 # Template file for 'protonvpn-cli'
 pkgname=protonvpn-cli
 version=2.2.11
-revision=1
+revision=2
 wrksrc="linux-cli-community-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="python3-devel"
-depends="openvpn python3-pythondialog python3-docopt python3-requests python3-Jinja2"
+depends="openvpn python3-pythondialog python3-docopt python3-requests python3-Jinja2 python3-distro"
 short_desc="Linux command-line client for ProtonVPN written in Python"
 maintainer="svenper <svenper@tuta.io>"
 license="GPL-3.0-or-later"

             reply	other threads:[~2021-08-06 19:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06 19:37 vokar [this message]
2021-08-06 19:45 ` [PR REVIEW] " ericonr
2021-08-06 20:37 ` [PR PATCH] [Updated] " vokar
2021-08-06 20:39 ` [PR REVIEW] " vokar
2021-08-06 21:23 ` ericonr
2021-08-06 21:23 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32374@inbox.vuxu.org \
    --to=vokar@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).