Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] protonvpn-cli: add missing dependency
@ 2021-08-06 19:37 vokar
  2021-08-06 19:45 ` [PR REVIEW] " ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: vokar @ 2021-08-06 19:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

There is a new pull request by vokar against master on the void-packages repository

https://github.com/vokar/void-packages protonvpn-cli
https://github.com/void-linux/void-packages/pull/32374

protonvpn-cli: add missing dependency
After updating protonvpn-cli (#32299), I started getting `ModuleNotFoundError: No module named 'distro'`. Turns out it's because `protonvpn-cli` uses the new [`distro`](https://github.com/python-distro/distro) dependency starting from version 2.2.8 (see ProtonVPN/linux-cli-community@117f5972ab09d44b5df07ffb88b120db9392c515).

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/32374.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-protonvpn-cli-32374.patch --]
[-- Type: text/x-diff, Size: 1062 bytes --]

From 42bd94cd916786bf0e1a910e970b77503e5eecc0 Mon Sep 17 00:00:00 2001
From: Vo Kar <vokar97@pm.me>
Date: Fri, 6 Aug 2021 21:27:50 +0300
Subject: [PATCH] protonvpn-cli: add missing dependency

---
 srcpkgs/protonvpn-cli/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/protonvpn-cli/template b/srcpkgs/protonvpn-cli/template
index c9a3c784ace6..329b21026c3e 100644
--- a/srcpkgs/protonvpn-cli/template
+++ b/srcpkgs/protonvpn-cli/template
@@ -1,12 +1,12 @@
 # Template file for 'protonvpn-cli'
 pkgname=protonvpn-cli
 version=2.2.11
-revision=1
+revision=2
 wrksrc="linux-cli-community-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="python3-devel"
-depends="openvpn python3-pythondialog python3-docopt python3-requests python3-Jinja2"
+depends="openvpn python3-pythondialog python3-docopt python3-requests python3-Jinja2 python3-distro"
 short_desc="Linux command-line client for ProtonVPN written in Python"
 maintainer="svenper <svenper@tuta.io>"
 license="GPL-3.0-or-later"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] protonvpn-cli: add missing dependency
  2021-08-06 19:37 [PR PATCH] protonvpn-cli: add missing dependency vokar
@ 2021-08-06 19:45 ` ericonr
  2021-08-06 20:37 ` [PR PATCH] [Updated] " vokar
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-08-06 19:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32374#discussion_r684467971

Comment:
Please break this line so it's less than 80 columns.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] protonvpn-cli: add missing dependency
  2021-08-06 19:37 [PR PATCH] protonvpn-cli: add missing dependency vokar
  2021-08-06 19:45 ` [PR REVIEW] " ericonr
@ 2021-08-06 20:37 ` vokar
  2021-08-06 20:39 ` [PR REVIEW] " vokar
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: vokar @ 2021-08-06 20:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

There is an updated pull request by vokar against master on the void-packages repository

https://github.com/vokar/void-packages protonvpn-cli
https://github.com/void-linux/void-packages/pull/32374

protonvpn-cli: add missing dependency
After updating protonvpn-cli (#32299), I started getting `ModuleNotFoundError: No module named 'distro'`. Turns out it's because `protonvpn-cli` uses the new [`distro`](https://github.com/python-distro/distro) dependency starting from version 2.2.8 (see ProtonVPN/linux-cli-community@117f5972ab09d44b5df07ffb88b120db9392c515).

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/32374.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-protonvpn-cli-32374.patch --]
[-- Type: text/x-diff, Size: 1065 bytes --]

From 85bf358244bcfdbf356bb14aea3c9d59a65a8e44 Mon Sep 17 00:00:00 2001
From: Vo Kar <vokar97@pm.me>
Date: Fri, 6 Aug 2021 21:27:50 +0300
Subject: [PATCH] protonvpn-cli: add missing dependency

---
 srcpkgs/protonvpn-cli/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/protonvpn-cli/template b/srcpkgs/protonvpn-cli/template
index c9a3c784ace6..940585a857d5 100644
--- a/srcpkgs/protonvpn-cli/template
+++ b/srcpkgs/protonvpn-cli/template
@@ -1,12 +1,13 @@
 # Template file for 'protonvpn-cli'
 pkgname=protonvpn-cli
 version=2.2.11
-revision=1
+revision=2
 wrksrc="linux-cli-community-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 makedepends="python3-devel"
-depends="openvpn python3-pythondialog python3-docopt python3-requests python3-Jinja2"
+depends="openvpn python3-pythondialog python3-docopt python3-requests
+ python3-Jinja2 python3-distro"
 short_desc="Linux command-line client for ProtonVPN written in Python"
 maintainer="svenper <svenper@tuta.io>"
 license="GPL-3.0-or-later"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] protonvpn-cli: add missing dependency
  2021-08-06 19:37 [PR PATCH] protonvpn-cli: add missing dependency vokar
  2021-08-06 19:45 ` [PR REVIEW] " ericonr
  2021-08-06 20:37 ` [PR PATCH] [Updated] " vokar
@ 2021-08-06 20:39 ` vokar
  2021-08-06 21:23 ` ericonr
  2021-08-06 21:23 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: vokar @ 2021-08-06 20:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by vokar on void-packages repository

https://github.com/void-linux/void-packages/pull/32374#discussion_r684492687

Comment:
Done:  85bf358

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: protonvpn-cli: add missing dependency
  2021-08-06 19:37 [PR PATCH] protonvpn-cli: add missing dependency vokar
                   ` (2 preceding siblings ...)
  2021-08-06 20:39 ` [PR REVIEW] " vokar
@ 2021-08-06 21:23 ` ericonr
  2021-08-06 21:23 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-08-06 21:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32374#issuecomment-894525645

Comment:
THanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: protonvpn-cli: add missing dependency
  2021-08-06 19:37 [PR PATCH] protonvpn-cli: add missing dependency vokar
                   ` (3 preceding siblings ...)
  2021-08-06 21:23 ` ericonr
@ 2021-08-06 21:23 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-08-06 21:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

There's a merged pull request on the void-packages repository

protonvpn-cli: add missing dependency
https://github.com/void-linux/void-packages/pull/32374

Description:
After updating protonvpn-cli (#32299), I started getting `ModuleNotFoundError: No module named 'distro'`. Turns out it's because `protonvpn-cli` uses the new [`distro`](https://github.com/python-distro/distro) dependency starting from version 2.2.8 (see ProtonVPN/linux-cli-community@117f5972ab09d44b5df07ffb88b120db9392c515).

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-06 21:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 19:37 [PR PATCH] protonvpn-cli: add missing dependency vokar
2021-08-06 19:45 ` [PR REVIEW] " ericonr
2021-08-06 20:37 ` [PR PATCH] [Updated] " vokar
2021-08-06 20:39 ` [PR REVIEW] " vokar
2021-08-06 21:23 ` ericonr
2021-08-06 21:23 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).