Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Komikku: update to 0.30.0.
@ 2021-08-07 13:09 not-chicken
  2021-08-07 20:01 ` [PR REVIEW] " paper42
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: not-chicken @ 2021-08-07 13:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is a new pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages komikku
https://github.com/void-linux/void-packages/pull/32393

Komikku: update to 0.30.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32393.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-komikku-32393.patch --]
[-- Type: text/x-diff, Size: 1475 bytes --]

From a2aabe5c9164579267ec3360e3fd3161ccd91384 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Sat, 7 Aug 2021 18:33:22 +0530
Subject: [PATCH] Komikku: update to 0.30.0.

---
 srcpkgs/Komikku/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/Komikku/template b/srcpkgs/Komikku/template
index a8d21545b64c..883148e17ea5 100644
--- a/srcpkgs/Komikku/template
+++ b/srcpkgs/Komikku/template
@@ -1,7 +1,7 @@
 # Template file for 'Komikku'
 pkgname=Komikku
-version=0.29.2
-revision=2
+version=0.30.0
+revision=1
 wrksrc=Komikku-v${version}
 build_style=meson
 hostmakedepends="gettext glib-devel gobject-introspection pkg-config"
@@ -9,11 +9,11 @@ makedepends="gtk+3-devel libhandy1-devel"
 depends="gtk+3 libhandy1 libnotify libsecret python3-BeautifulSoup4
  python3-Pillow python3-Unidecode python3-cloudscraper python3-dateparser
  python3-gobject python3-keyring python3-lxml python3-magic
- python3-pure-protobuf"
+ python3-natsort python3-pure-protobuf"
 checkdepends="appstream-glib desktop-file-utils"
 short_desc="Online/offline manga reader for GNOME"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/valos/Komikku"
 distfiles="${homepage}/-/archive/v${version}/Komikku-v${version}.tar.gz"
-checksum=20e78e8fbdabc926d9ead44efcc8ec9e16807745fbda8502451de99a4e864ec4
+checksum=07c45f458a485d50220c71028f71ab27e86058fce1bfd9334b9859e601b7f7e6

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
@ 2021-08-07 20:01 ` paper42
  2021-08-07 20:02 ` paper42
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-08-07 20:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32393#discussion_r684671957

Comment:
python3-requests dependency is missing

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
  2021-08-07 20:01 ` [PR REVIEW] " paper42
@ 2021-08-07 20:02 ` paper42
  2021-08-08  2:35 ` [PR PATCH] [Updated] " not-chicken
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-08-07 20:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32393#discussion_r684672027

Comment:
could you remove $homepage?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
  2021-08-07 20:01 ` [PR REVIEW] " paper42
  2021-08-07 20:02 ` paper42
@ 2021-08-08  2:35 ` not-chicken
  2021-08-08  2:36 ` [PR REVIEW] " not-chicken
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: not-chicken @ 2021-08-08  2:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages komikku
https://github.com/void-linux/void-packages/pull/32393

Komikku: update to 0.30.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32393.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-komikku-32393.patch --]
[-- Type: text/x-diff, Size: 1573 bytes --]

From 1f770c62c98ca3a077a0bb055daa0ab9b04e5834 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Sat, 7 Aug 2021 18:33:22 +0530
Subject: [PATCH] Komikku: update to 0.30.0.

---
 srcpkgs/Komikku/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/Komikku/template b/srcpkgs/Komikku/template
index a8d21545b64c..7a612602214d 100644
--- a/srcpkgs/Komikku/template
+++ b/srcpkgs/Komikku/template
@@ -1,7 +1,7 @@
 # Template file for 'Komikku'
 pkgname=Komikku
-version=0.29.2
-revision=2
+version=0.30.0
+revision=1
 wrksrc=Komikku-v${version}
 build_style=meson
 hostmakedepends="gettext glib-devel gobject-introspection pkg-config"
@@ -9,11 +9,11 @@ makedepends="gtk+3-devel libhandy1-devel"
 depends="gtk+3 libhandy1 libnotify libsecret python3-BeautifulSoup4
  python3-Pillow python3-Unidecode python3-cloudscraper python3-dateparser
  python3-gobject python3-keyring python3-lxml python3-magic
- python3-pure-protobuf"
+ python3-natsort python3-pure-protobuf"
 checkdepends="appstream-glib desktop-file-utils"
 short_desc="Online/offline manga reader for GNOME"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/valos/Komikku"
-distfiles="${homepage}/-/archive/v${version}/Komikku-v${version}.tar.gz"
-checksum=20e78e8fbdabc926d9ead44efcc8ec9e16807745fbda8502451de99a4e864ec4
+distfiles="https://gitlab.com/valos/Komikku/-/archive/v${version}/Komikku-v${version}.tar.gz"
+checksum=07c45f458a485d50220c71028f71ab27e86058fce1bfd9334b9859e601b7f7e6

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
                   ` (2 preceding siblings ...)
  2021-08-08  2:35 ` [PR PATCH] [Updated] " not-chicken
@ 2021-08-08  2:36 ` not-chicken
  2021-08-08  2:36 ` not-chicken
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: not-chicken @ 2021-08-08  2:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/32393#discussion_r684703603

Comment:
 It's pulled in via `python3-cloudscraper`

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
                   ` (3 preceding siblings ...)
  2021-08-08  2:36 ` [PR REVIEW] " not-chicken
@ 2021-08-08  2:36 ` not-chicken
  2021-08-08 14:11 ` not-chicken
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: not-chicken @ 2021-08-08  2:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New review comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/32393#discussion_r684703618

Comment:
done

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
                   ` (4 preceding siblings ...)
  2021-08-08  2:36 ` not-chicken
@ 2021-08-08 14:11 ` not-chicken
  2021-08-08 20:51 ` ericonr
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: not-chicken @ 2021-08-08 14:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/32393#issuecomment-894803859

Comment:
An issue was spotted by @paper42, it's not a regression. Reported upstream: https://gitlab.com/valos/Komikku/-/issues/149

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
                   ` (5 preceding siblings ...)
  2021-08-08 14:11 ` not-chicken
@ 2021-08-08 20:51 ` ericonr
  2021-08-08 21:01 ` paper42
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-08-08 20:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32393#issuecomment-894853626

Comment:
@paper42 Ok to merge?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
                   ` (6 preceding siblings ...)
  2021-08-08 20:51 ` ericonr
@ 2021-08-08 21:01 ` paper42
  2021-08-08 21:01 ` [PR PATCH] [Merged]: " paper42
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-08-08 21:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32393#issuecomment-894854686

Comment:
ok, let's merge this

@not-chicken could you watch the issue and submit a fix when we know what's happening?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Merged]: Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
                   ` (7 preceding siblings ...)
  2021-08-08 21:01 ` paper42
@ 2021-08-08 21:01 ` paper42
  2021-08-12 12:47 ` not-chicken
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-08-08 21:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

There's a merged pull request on the void-packages repository

Komikku: update to 0.30.0.
https://github.com/void-linux/void-packages/pull/32393

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
                   ` (8 preceding siblings ...)
  2021-08-08 21:01 ` [PR PATCH] [Merged]: " paper42
@ 2021-08-12 12:47 ` not-chicken
  2021-08-12 16:47 ` paper42
  2021-08-12 17:03 ` not-chicken
  11 siblings, 0 replies; 13+ messages in thread
From: not-chicken @ 2021-08-12 12:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/32393#issuecomment-897610433

Comment:
> @not-chicken could you watch the issue and submit a fix when we know what's happening?

It was [fixed](https://gitlab.com/valos/Komikku/-/commit/35393c0af19b8e55d3be626f430a05a5969ad5dc) upstream! :rocket: 
Should I submit it as patch or wait for new release?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
                   ` (9 preceding siblings ...)
  2021-08-12 12:47 ` not-chicken
@ 2021-08-12 16:47 ` paper42
  2021-08-12 17:03 ` not-chicken
  11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-08-12 16:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32393#issuecomment-897798512

Comment:
> Should I submit it as patch or wait for new release?

I think you can submit a PR with a patch.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Komikku: update to 0.30.0.
  2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
                   ` (10 preceding siblings ...)
  2021-08-12 16:47 ` paper42
@ 2021-08-12 17:03 ` not-chicken
  11 siblings, 0 replies; 13+ messages in thread
From: not-chicken @ 2021-08-12 17:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/32393#issuecomment-897808874

Comment:
#32471

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-08-12 17:03 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-07 13:09 [PR PATCH] Komikku: update to 0.30.0 not-chicken
2021-08-07 20:01 ` [PR REVIEW] " paper42
2021-08-07 20:02 ` paper42
2021-08-08  2:35 ` [PR PATCH] [Updated] " not-chicken
2021-08-08  2:36 ` [PR REVIEW] " not-chicken
2021-08-08  2:36 ` not-chicken
2021-08-08 14:11 ` not-chicken
2021-08-08 20:51 ` ericonr
2021-08-08 21:01 ` paper42
2021-08-08 21:01 ` [PR PATCH] [Merged]: " paper42
2021-08-12 12:47 ` not-chicken
2021-08-12 16:47 ` paper42
2021-08-12 17:03 ` not-chicken

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).