* [PR PATCH] Document changelog variable in Manual.md
@ 2021-08-19 13:52 meator
2021-08-19 18:25 ` [PR REVIEW] " ericonr
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: meator @ 2021-08-19 13:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
There is a new pull request by meator against master on the void-packages repository
https://github.com/meator/void-packages patch-1
https://github.com/void-linux/void-packages/pull/32586
Document changelog variable in Manual.md
None
A patch file from https://github.com/void-linux/void-packages/pull/32586.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-32586.patch --]
[-- Type: text/x-diff, Size: 798 bytes --]
From 16c1065fcf984a26ce0e5c4805b4f76811d12271 Mon Sep 17 00:00:00 2001
From: meator <Coder64@protonmail.com>
Date: Thu, 19 Aug 2021 15:37:31 +0200
Subject: [PATCH] Document changelog variable in Manual.md
---
Manual.md | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Manual.md b/Manual.md
index 4316363f66c4..35f1b0016b4c 100644
--- a/Manual.md
+++ b/Manual.md
@@ -743,6 +743,8 @@ used.
- `fetch_cmd` Executable to be used to fetch URLs in `distfiles` during the `do_fetch` phase.
+- `changelog` A string pointing to the `upstream` changelog.
+
- `archs` Whitespace separated list of architectures that a package can be
built for, available architectures can be found under `common/cross-profiles`.
In general, `archs` should only be set if the upstream software explicitly targets
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] Document changelog variable in Manual.md
2021-08-19 13:52 [PR PATCH] Document changelog variable in Manual.md meator
@ 2021-08-19 18:25 ` ericonr
2021-08-19 21:25 ` paper42
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-08-19 18:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32586#discussion_r692380331
Comment:
Not sure "upstream" should be formatted as code. I think this should also document that raw text files are preferred.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] Document changelog variable in Manual.md
2021-08-19 13:52 [PR PATCH] Document changelog variable in Manual.md meator
2021-08-19 18:25 ` [PR REVIEW] " ericonr
@ 2021-08-19 21:25 ` paper42
2021-08-20 6:46 ` meator
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2021-08-19 21:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/32586#discussion_r692497738
Comment:
Let's also be clear that the string is a URL (not a filename to changelog in the distfiles).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] Document changelog variable in Manual.md
2021-08-19 13:52 [PR PATCH] Document changelog variable in Manual.md meator
2021-08-19 18:25 ` [PR REVIEW] " ericonr
2021-08-19 21:25 ` paper42
@ 2021-08-20 6:46 ` meator
2021-08-20 6:47 ` [PR PATCH] [Updated] " meator
2021-08-23 19:10 ` [PR PATCH] [Merged]: " Chocimier
4 siblings, 0 replies; 6+ messages in thread
From: meator @ 2021-08-20 6:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
New review comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/32586#discussion_r692707125
Comment:
I just copied description for homepage and changed it to changelog. I'll also change homepage to make it consistent.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] Document changelog variable in Manual.md
2021-08-19 13:52 [PR PATCH] Document changelog variable in Manual.md meator
` (2 preceding siblings ...)
2021-08-20 6:46 ` meator
@ 2021-08-20 6:47 ` meator
2021-08-23 19:10 ` [PR PATCH] [Merged]: " Chocimier
4 siblings, 0 replies; 6+ messages in thread
From: meator @ 2021-08-20 6:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
There is an updated pull request by meator against master on the void-packages repository
https://github.com/meator/void-packages patch-1
https://github.com/void-linux/void-packages/pull/32586
Document changelog variable in Manual.md
[ci skip]
A patch file from https://github.com/void-linux/void-packages/pull/32586.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-32586.patch --]
[-- Type: text/x-diff, Size: 1127 bytes --]
From 726239197ac1770167e6527e75f50a4349c74d4a Mon Sep 17 00:00:00 2001
From: meator <Coder64@protonmail.com>
Date: Thu, 19 Aug 2021 15:37:31 +0200
Subject: [PATCH] Manual.md: document changelog and modify homepage
---
Manual.md | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Manual.md b/Manual.md
index 4316363f66c4..33706f20c210 100644
--- a/Manual.md
+++ b/Manual.md
@@ -434,7 +434,7 @@ in this directory such as `${XBPS_BUILDDIR}/${wrksrc}`.
The list of mandatory variables for a template:
-- `homepage` A string pointing to the `upstream` homepage.
+- `homepage` An URL pointing to the upstream homepage.
- <a id="var_license"></a>
@@ -743,6 +743,8 @@ used.
- `fetch_cmd` Executable to be used to fetch URLs in `distfiles` during the `do_fetch` phase.
+- `changelog` An URL pointing to the upstream changelog. Raw text files are preferred.
+
- `archs` Whitespace separated list of architectures that a package can be
built for, available architectures can be found under `common/cross-profiles`.
In general, `archs` should only be set if the upstream software explicitly targets
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: Document changelog variable in Manual.md
2021-08-19 13:52 [PR PATCH] Document changelog variable in Manual.md meator
` (3 preceding siblings ...)
2021-08-20 6:47 ` [PR PATCH] [Updated] " meator
@ 2021-08-23 19:10 ` Chocimier
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2021-08-23 19:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
There's a merged pull request on the void-packages repository
Document changelog variable in Manual.md
https://github.com/void-linux/void-packages/pull/32586
Description:
[ci skip]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-23 19:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 13:52 [PR PATCH] Document changelog variable in Manual.md meator
2021-08-19 18:25 ` [PR REVIEW] " ericonr
2021-08-19 21:25 ` paper42
2021-08-20 6:46 ` meator
2021-08-20 6:47 ` [PR PATCH] [Updated] " meator
2021-08-23 19:10 ` [PR PATCH] [Merged]: " Chocimier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).