[-- Attachment #1: Type: text/plain, Size: 1581 bytes --] There is a new pull request by ifreund against master on the void-packages repository https://github.com/ifreund/void-packages foot https://github.com/void-linux/void-packages/pull/32703 foot: update to 1.9.0. <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [ ] I generally don't use the affected packages but briefly tested this PR <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> <!-- #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [ ] I built this PR locally for my native architecture, (ARCH-LIBC) - [ ] I built this PR locally for these architectures (if supported. mark crossbuilds): - [ ] aarch64-musl - [ ] armv7l - [ ] armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/32703.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-foot-32703.patch --] [-- Type: text/x-diff, Size: 1168 bytes --] From 684bffd0b208750197b9a2c29b0e986f9db06c6a Mon Sep 17 00:00:00 2001 From: Isaac Freund <ifreund@ifreund.xyz> Date: Fri, 27 Aug 2021 14:44:35 +0200 Subject: [PATCH] foot: update to 1.9.0. --- srcpkgs/foot/template | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/srcpkgs/foot/template b/srcpkgs/foot/template index 3dde8c741f24..d254056d476a 100644 --- a/srcpkgs/foot/template +++ b/srcpkgs/foot/template @@ -1,6 +1,6 @@ # Template file for 'foot' pkgname=foot -version=1.8.2 +version=1.9.0 revision=1 wrksrc=$pkgname build_style=meson @@ -15,7 +15,7 @@ license="MIT" homepage="https://codeberg.org/dnkl/foot" changelog="https://codeberg.org/dnkl/foot/src/branch/master/CHANGELOG.md" distfiles="${homepage}/archive/${version}.tar.gz" -checksum=50cf5b9f3cc1ebaafa62255eea22395e8267cce21e119bc6f7ecacf11f15dada +checksum=ddc3f90185ae75badcb2d6abe772d54fd6defebf1ed4111861a9c4afa1c73a4d post_install() { rm -f ${DESTDIR}/usr/share/doc/foot/LICENSE @@ -25,6 +25,6 @@ post_install() { foot-terminfo_package() { short_desc+=" - terminfo data" pkg_install() { - vmove usr/share/terminfo + vmove usr/share/foot/terminfo } }
[-- Attachment #1: Type: text/plain, Size: 632 bytes --] New review comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/32703#discussion_r697452400 Comment: IMO foot gives us hooks in its build system exactly to control such things. We should use `usr/share/terminfo` at least until ncurses makes a release with their version of foot, otherwise installing `foot-terminfo` into a server you ssh into (which is the only reason to have a subpackage at all) won't do anything until you magically know to export TERMINFO somewhere. It also breaks stupid things (I do) like `doas nvi`, unless I update my config to pass TERMINFO through as well.
[-- Attachment #1: Type: text/plain, Size: 261 bytes --] New review comment by ram02z on void-packages repository https://github.com/void-linux/void-packages/pull/32703#discussion_r697992339 Comment: The non standard terminfo location has a bunch of outstanding issues. See https://codeberg.org/dnkl/foot/issues/695
[-- Attachment #1: Type: text/plain, Size: 269 bytes --] New review comment by ifreund on void-packages repository https://github.com/void-linux/void-packages/pull/32703#discussion_r697994544 Comment: Yep, from that issue and dnkl's mail to maintainers it looks like upstream now recommends exactly what @ericonr suggested.
[-- Attachment #1: Type: text/plain, Size: 1586 bytes --] There is an updated pull request by ifreund against master on the void-packages repository https://github.com/ifreund/void-packages foot https://github.com/void-linux/void-packages/pull/32703 foot: update to 1.9.0. <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [ ] I generally don't use the affected packages but briefly tested this PR <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> <!-- #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [ ] I built this PR locally for my native architecture, (ARCH-LIBC) - [ ] I built this PR locally for these architectures (if supported. mark crossbuilds): - [ ] aarch64-musl - [ ] armv7l - [ ] armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/32703.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-foot-32703.patch --] [-- Type: text/x-diff, Size: 1810 bytes --] From 0d0d79709ff0b88a654d0e881a11697e8a7d3618 Mon Sep 17 00:00:00 2001 From: Isaac Freund <ifreund@ifreund.xyz> Date: Fri, 27 Aug 2021 14:44:35 +0200 Subject: [PATCH] foot: update to 1.9.0. --- srcpkgs/foot/template | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/srcpkgs/foot/template b/srcpkgs/foot/template index 3dde8c741f24..5873ca6db29a 100644 --- a/srcpkgs/foot/template +++ b/srcpkgs/foot/template @@ -1,10 +1,12 @@ # Template file for 'foot' pkgname=foot -version=1.8.2 +version=1.9.0 revision=1 wrksrc=$pkgname build_style=meson -configure_args="-Dwerror=false" +# Tell foot not to set TERMINFO as we install the terminfo to the default +# location. +configure_args="-Dwerror=false -Dcustom-terminfo-install-location=no" hostmakedepends="pkg-config scdoc wayland-devel" makedepends="fcft-devel libutf8proc-devel libxkbcommon-devel ncurses-devel tllist wayland-devel wayland-protocols" @@ -15,7 +17,7 @@ license="MIT" homepage="https://codeberg.org/dnkl/foot" changelog="https://codeberg.org/dnkl/foot/src/branch/master/CHANGELOG.md" distfiles="${homepage}/archive/${version}.tar.gz" -checksum=50cf5b9f3cc1ebaafa62255eea22395e8267cce21e119bc6f7ecacf11f15dada +checksum=ddc3f90185ae75badcb2d6abe772d54fd6defebf1ed4111861a9c4afa1c73a4d post_install() { rm -f ${DESTDIR}/usr/share/doc/foot/LICENSE @@ -25,6 +27,11 @@ post_install() { foot-terminfo_package() { short_desc+=" - terminfo data" pkg_install() { - vmove usr/share/terminfo + vmove usr/share/foot/terminfo + + # Install the terminfo to the default location instead. This follows the + # new upstream recommendations: https://codeberg.org/dnkl/foot/issues/695 + vcopy ${PKGDESTDIR}/usr/share/foot/terminfo usr/share/terminfo + rm -r ${PKGDESTDIR}/usr/share/foot/terminfo } }
[-- Attachment #1: Type: text/plain, Size: 193 bytes --] New comment by ram02z on void-packages repository https://github.com/void-linux/void-packages/pull/32703#issuecomment-913009814 Comment: @ericonr sorry for the ping, but can this get merged?
[-- Attachment #1: Type: text/plain, Size: 183 bytes --] New comment by cinerea0 on void-packages repository https://github.com/void-linux/void-packages/pull/32703#issuecomment-917547938 Comment: Agreed, this would be good to get merged.
[-- Attachment #1: Type: text/plain, Size: 265 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/32703#issuecomment-927500726 Comment: Seems to be working here locally, but I was under the impression a packaging fix release would be coming? 1.9.1 or whatever?
[-- Attachment #1: Type: text/plain, Size: 413 bytes --] New comment by stacyharper on void-packages repository https://github.com/void-linux/void-packages/pull/32703#issuecomment-927610626 Comment: For additional info, here a thread with @dnkl, the developer behind foot: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/24357#note_177559 The actual mr that get merged into aports: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/24845
[-- Attachment #1: Type: text/plain, Size: 215 bytes --] New comment by cinerea0 on void-packages repository https://github.com/void-linux/void-packages/pull/32703#issuecomment-931570995 Comment: A packaging fix may be coming, but it doesn't look like it's coming soon.
[-- Attachment #1: Type: text/plain, Size: 249 bytes --] New comment by dnkl on void-packages repository https://github.com/void-linux/void-packages/pull/32703#issuecomment-932301809 Comment: I can do a 1.9.1 release, if that makes it easier for you. I haven't yet, to avoid unnecessary packaging churn.
[-- Attachment #1: Type: text/plain, Size: 194 bytes --] New comment by cinerea0 on void-packages repository https://github.com/void-linux/void-packages/pull/32703#issuecomment-932680918 Comment: @ifreund It looks like 1.9.1 has just been released.
[-- Attachment #1: Type: text/plain, Size: 1586 bytes --] There is an updated pull request by ifreund against master on the void-packages repository https://github.com/ifreund/void-packages foot https://github.com/void-linux/void-packages/pull/32703 foot: update to 1.9.0. <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [ ] I generally don't use the affected packages but briefly tested this PR <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> <!-- #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [ ] I built this PR locally for my native architecture, (ARCH-LIBC) - [ ] I built this PR locally for these architectures (if supported. mark crossbuilds): - [ ] aarch64-musl - [ ] armv7l - [ ] armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/32703.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-foot-32703.patch --] [-- Type: text/x-diff, Size: 985 bytes --] From c1190ee51b7306cd7634100fe271d8b58d6ff0bf Mon Sep 17 00:00:00 2001 From: Isaac Freund <ifreund@ifreund.xyz> Date: Fri, 27 Aug 2021 14:44:35 +0200 Subject: [PATCH] foot: update to 1.9.2. --- srcpkgs/foot/template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/srcpkgs/foot/template b/srcpkgs/foot/template index 3dde8c741f24..fb29953d7d29 100644 --- a/srcpkgs/foot/template +++ b/srcpkgs/foot/template @@ -1,6 +1,6 @@ # Template file for 'foot' pkgname=foot -version=1.8.2 +version=1.9.2 revision=1 wrksrc=$pkgname build_style=meson @@ -15,7 +15,7 @@ license="MIT" homepage="https://codeberg.org/dnkl/foot" changelog="https://codeberg.org/dnkl/foot/src/branch/master/CHANGELOG.md" distfiles="${homepage}/archive/${version}.tar.gz" -checksum=50cf5b9f3cc1ebaafa62255eea22395e8267cce21e119bc6f7ecacf11f15dada +checksum=5859d8d7293da4c7c52f45a9756fc7989edc364057e8b86b4e1fbea7bc2b4009 post_install() { rm -f ${DESTDIR}/usr/share/doc/foot/LICENSE
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --] There's a merged pull request on the void-packages repository foot: update to 1.9.2. https://github.com/void-linux/void-packages/pull/32703 Description: <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [ ] I generally don't use the affected packages but briefly tested this PR <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> <!-- #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [ ] I built this PR locally for my native architecture, (ARCH-LIBC) - [ ] I built this PR locally for these architectures (if supported. mark crossbuilds): - [ ] aarch64-musl - [ ] armv7l - [ ] armv6l-musl -->