From: r-c-f <r-c-f@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] libcdparanoia: byteswap null check
Date: Mon, 13 Sep 2021 21:39:37 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32954@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]
There is a new pull request by r-c-f against master on the void-packages repository
https://github.com/r-c-f/void-packages paranoia-be-fix
https://github.com/void-linux/void-packages/pull/32954
libcdparanoia: byteswap null check
From upstream r15356, fixes a segfault when attempting to read discs
on big-endian systems.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ppc-musl)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [x] armv7l
- [ ] armv6l-musl
A patch file from https://github.com/void-linux/void-packages/pull/32954.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-paranoia-be-fix-32954.patch --]
[-- Type: text/x-diff, Size: 1661 bytes --]
From ca76b24b7dc60a537fd1212a440bdc79ccfbec17 Mon Sep 17 00:00:00 2001
From: Ryan Farley <ryan.farley@gmx.com>
Date: Wed, 21 Jul 2021 19:18:05 -0500
Subject: [PATCH] libcdparanoia: byteswap null check
From upstream r15356, fixes a segfault when attempting to read discs
---
srcpkgs/cdparanoia/patches/byteswap-null-check.diff | 13 +++++++++++++
srcpkgs/cdparanoia/template | 2 +-
2 files changed, 14 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/cdparanoia/patches/byteswap-null-check.diff
diff --git a/srcpkgs/cdparanoia/patches/byteswap-null-check.diff b/srcpkgs/cdparanoia/patches/byteswap-null-check.diff
new file mode 100644
index 000000000000..77f61474a6a6
--- /dev/null
+++ b/srcpkgs/cdparanoia/patches/byteswap-null-check.diff
@@ -0,0 +1,13 @@
+Index: interface/interface.c
+===================================================================
+--- a/interface/interface.c (revision 15338)
++++ b/interface/interface.c (revision 15356)
+@@ -118,7 +118,7 @@
+ if(d->bigendianp==-1) /* not determined yet */
+ d->bigendianp=data_bigendianp(d);
+
+- if(d->bigendianp!=bigendianp()){
++ if(buffer && d->bigendianp!=bigendianp()){
+ int i;
+ u_int16_t *p=(u_int16_t *)buffer;
+ long els=sectors*CD_FRAMESIZE_RAW/2;
diff --git a/srcpkgs/cdparanoia/template b/srcpkgs/cdparanoia/template
index 3cf09587f215..3566b6a62e74 100644
--- a/srcpkgs/cdparanoia/template
+++ b/srcpkgs/cdparanoia/template
@@ -1,7 +1,7 @@
# Template file for 'cdparanoia'
pkgname=cdparanoia
version=10.2
-revision=14
+revision=15
wrksrc="${pkgname}-III-${version}"
build_style=gnu-configure
hostmakedepends="libtool automake"
next reply other threads:[~2021-09-13 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 19:39 r-c-f [this message]
2021-09-13 20:26 ` [PR PATCH] [Merged]: " q66
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32954@inbox.vuxu.org \
--to=r-c-f@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).