Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] common/environment: set debug-prefix-map to prevent ccache cache misses
@ 2021-09-17 19:34 Johnnynator
  2021-12-08 12:06 ` [PR PATCH] [Closed]: " Duncaen
  0 siblings, 1 reply; 2+ messages in thread
From: Johnnynator @ 2021-09-17 19:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages less-ccache-misses
https://github.com/void-linux/void-packages/pull/33002

common/environment: set debug-prefix-map to prevent ccache cache misses
Packages with debug symbols do invalidate their cache with every version
change since $wrksrc does contain the version number and is getting cached

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33002.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-less-ccache-misses-33002.patch --]
[-- Type: text/x-diff, Size: 2765 bytes --]

From 2dc63f8e6f9c2be71238530debc373f1acbcbf5e Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Fri, 17 Sep 2021 21:30:10 +0200
Subject: [PATCH] common/environment: set debug-prefix-map to prevent ccache
 cache misses

Packages with debug symbols do invalidate their cache with every version
change since $wrksrc does contain the version number and is getting cached
---
 common/environment/build/debug-debug-prefix-map.sh     | 1 +
 common/environment/check/debug-debug-prefix-map.sh     | 1 +
 common/environment/configure/debug-debug-prefix-map.sh | 2 ++
 common/environment/install/debug-debug-prefix-map.sh   | 1 +
 common/environment/patch/debug-debug-prefix-map.sh     | 1 +
 5 files changed, 6 insertions(+)
 create mode 120000 common/environment/build/debug-debug-prefix-map.sh
 create mode 120000 common/environment/check/debug-debug-prefix-map.sh
 create mode 100644 common/environment/configure/debug-debug-prefix-map.sh
 create mode 120000 common/environment/install/debug-debug-prefix-map.sh
 create mode 120000 common/environment/patch/debug-debug-prefix-map.sh

diff --git a/common/environment/build/debug-debug-prefix-map.sh b/common/environment/build/debug-debug-prefix-map.sh
new file mode 120000
index 000000000000..98c260a33f36
--- /dev/null
+++ b/common/environment/build/debug-debug-prefix-map.sh
@@ -0,0 +1 @@
+../configure/debug-debug-prefix-map.sh
\ No newline at end of file
diff --git a/common/environment/check/debug-debug-prefix-map.sh b/common/environment/check/debug-debug-prefix-map.sh
new file mode 120000
index 000000000000..98c260a33f36
--- /dev/null
+++ b/common/environment/check/debug-debug-prefix-map.sh
@@ -0,0 +1 @@
+../configure/debug-debug-prefix-map.sh
\ No newline at end of file
diff --git a/common/environment/configure/debug-debug-prefix-map.sh b/common/environment/configure/debug-debug-prefix-map.sh
new file mode 100644
index 000000000000..ca30b61b79ab
--- /dev/null
+++ b/common/environment/configure/debug-debug-prefix-map.sh
@@ -0,0 +1,2 @@
+CFLAGS="${CFLAGS} -fdebug-prefix-map=$wrksrc=."
+CXXFLAGS="${CXXFLAGS} -fdebug-prefix-map=$wrksrc=."
diff --git a/common/environment/install/debug-debug-prefix-map.sh b/common/environment/install/debug-debug-prefix-map.sh
new file mode 120000
index 000000000000..98c260a33f36
--- /dev/null
+++ b/common/environment/install/debug-debug-prefix-map.sh
@@ -0,0 +1 @@
+../configure/debug-debug-prefix-map.sh
\ No newline at end of file
diff --git a/common/environment/patch/debug-debug-prefix-map.sh b/common/environment/patch/debug-debug-prefix-map.sh
new file mode 120000
index 000000000000..98c260a33f36
--- /dev/null
+++ b/common/environment/patch/debug-debug-prefix-map.sh
@@ -0,0 +1 @@
+../configure/debug-debug-prefix-map.sh
\ No newline at end of file

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Closed]: common/environment: set debug-prefix-map to prevent ccache cache misses
  2021-09-17 19:34 [PR PATCH] common/environment: set debug-prefix-map to prevent ccache cache misses Johnnynator
@ 2021-12-08 12:06 ` Duncaen
  0 siblings, 0 replies; 2+ messages in thread
From: Duncaen @ 2021-12-08 12:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]

There's a closed pull request on the void-packages repository

common/environment: set debug-prefix-map to prevent ccache cache misses
https://github.com/void-linux/void-packages/pull/33002

Description:
Packages with debug symbols do invalidate their cache with every version
change since $wrksrc does contain the version number and is getting cached

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-08 12:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17 19:34 [PR PATCH] common/environment: set debug-prefix-map to prevent ccache cache misses Johnnynator
2021-12-08 12:06 ` [PR PATCH] [Closed]: " Duncaen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).