Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: libteam 1.31.git20210222
@ 2021-09-19 16:55 chexum
  2021-09-20  0:57 ` ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: chexum @ 2021-09-19 16:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2144 bytes --]

There is a new pull request by chexum against master on the void-packages repository

https://github.com/chexum/void-packages libteam-1.31.git
https://github.com/void-linux/void-packages/pull/33028

New package: libteam 1.31.git20210222
<!-- Mark items with [x] where applicable -->

libteam, the user-space counterpart of the ethernet teaming/bonding device is the modern tool to provide link aggregation for ethernet devices.  Unfortunately, the most recent proper release misses a few important fixes, so I opted to use the git version instead of providing the patches from github.

It also has some incompatibility with musl, TIPC is always enabled, but it uses a header, sys/queue.h which does not seem to be provided by musl, so I disabled all musl platforms for the time being.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-glibc
  - [ ] aarch64-musl
  - [x] armv7l-glibc
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33028.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libteam-1.31.git-33028.patch --]
[-- Type: text/x-diff, Size: 3115 bytes --]

From 2263c70ecf226a288fa50ae080cb95fdba622367 Mon Sep 17 00:00:00 2001
From: J Farkas <chexum+git@gmail.com>
Date: Sun, 19 Sep 2021 16:45:37 +0000
Subject: [PATCH] New package: libteam 1.31.git20210222

---
 common/shlibs                    |  2 ++
 srcpkgs/libteam/files/teamd.conf | 14 +++++++++++
 srcpkgs/libteam/files/teamd/run  |  4 ++++
 srcpkgs/libteam/template         | 41 ++++++++++++++++++++++++++++++++
 4 files changed, 61 insertions(+)
 create mode 100644 srcpkgs/libteam/files/teamd.conf
 create mode 100644 srcpkgs/libteam/files/teamd/run
 create mode 100644 srcpkgs/libteam/template

diff --git a/common/shlibs b/common/shlibs
index 840fbc0b9a9f..da13724f3b59 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4023,3 +4023,5 @@ libmt32emu.so.2 libmt32emu-2.5.1_1
 libqrtr-glib.so.0 libqrtr-glib-1.0.0_1
 libstemmer.so.2 libstemmer-2.1.0_1
 libdecor-0.so.0 libdecor-0.1.0_1
+libteam.so.5 libteam-1.31.git20210222_0
+libteamdctl.so.0 libteam-1.31.git20210222_0
diff --git a/srcpkgs/libteam/files/teamd.conf b/srcpkgs/libteam/files/teamd.conf
new file mode 100644
index 000000000000..fc799461ca6f
--- /dev/null
+++ b/srcpkgs/libteam/files/teamd.conf
@@ -0,0 +1,14 @@
+{
+    "device": "team0",
+    "ports": {
+        "enp0s0": {
+            "link_watch": {
+                "name": "ethtool"
+            }
+        }
+    },
+    "runner": {
+        "name": "roundrobin"
+    }
+}
+
diff --git a/srcpkgs/libteam/files/teamd/run b/srcpkgs/libteam/files/teamd/run
new file mode 100644
index 000000000000..5e413d91aaa8
--- /dev/null
+++ b/srcpkgs/libteam/files/teamd/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+exec 2>&1
+[ -r conf ] && . ./conf
+exec teamd ${OPTS} -f ${CONF_FILE:-/etc/teamd.conf}
diff --git a/srcpkgs/libteam/template b/srcpkgs/libteam/template
new file mode 100644
index 000000000000..02a466ccf1fe
--- /dev/null
+++ b/srcpkgs/libteam/template
@@ -0,0 +1,41 @@
+# Template file for 'libteam'
+pkgname=libteam
+version=1.31.git20210222
+revision=1
+archs="~*-musl" # always-enabled tipc needs non-musl sys/queue.h
+_githash=69a7494bb77dc10bb27076add07b380dbd778592
+wrksrc=libteam-${_githash}
+build_style=gnu-configure
+configure_args="--with-user=_teamd --with-group=_teamd"
+conf_files="/etc/teamd.conf"
+hostmakedepends="automake pkg-config libtool"
+makedepends="glib-devel libnl3-devel libdaemon-devel jansson-devel dbus-devel libcap-devel"
+short_desc="Ethernet teaming/bonding/aggregation service"
+maintainer="J Farkas <chexum+git@gmail.com>"
+license="LGPL-2.1-or-later"
+homepage="http://libteam.org/"
+distfiles="https://github.com/jpirko/libteam/archive/${_githash}.tar.gz"
+checksum=600005b5233d21914e0e93c8f548b95219ff37eda8e768b69c4e9be32347bf5b
+
+system_groups="_teamd"
+system_accounts="_teamd"
+_teamd_descr="teamd runtime user"
+_teamd_pgroup="_teamd"
+
+pre_configure() {
+	./autogen.sh
+}
+
+do_install() {
+	make ${makejobs} DESTDIR=${DESTDIR} install
+	vinstall teamd/dbus/teamd.conf 644 etc/dbus-1/system.d
+
+	vmkdir usr/share/examples/${pkgname}
+	for f in teamd/example_configs/*conf; do
+		vsconf "${f}"
+	done
+
+	vconf ${FILESDIR}/teamd.conf
+
+	vsv teamd
+}

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: New package: libteam 1.31.git20210222
  2021-09-19 16:55 [PR PATCH] New package: libteam 1.31.git20210222 chexum
@ 2021-09-20  0:57 ` ericonr
  2021-09-20  0:57 ` [PR REVIEW] " ericonr
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-09-20  0:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33028#issuecomment-922573803

Comment:
> It also has some incompatibility with musl, TIPC is always enabled, but it uses a header, sys/queue.h which does not seem to be provided by musl, so I disabled all musl platforms for the time being.

add `musl-legacy-compat` to `makedepends` for `XBPS_TARGET_LIBC = musl`.

> so I opted to use the git version instead of providing the patches from github.

Please try to ask for a new release. I'd be against merging a driver for dealing with network interfaces if upstream is inactive, which means security issues are likely to go unfixed.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] New package: libteam 1.31.git20210222
  2021-09-19 16:55 [PR PATCH] New package: libteam 1.31.git20210222 chexum
  2021-09-20  0:57 ` ericonr
@ 2021-09-20  0:57 ` ericonr
  2021-09-20  0:58 ` ericonr
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-09-20  0:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33028#discussion_r711832534

Comment:
Don't they provide such an example file? Seems wrong for us to provide one.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] New package: libteam 1.31.git20210222
  2021-09-19 16:55 [PR PATCH] New package: libteam 1.31.git20210222 chexum
  2021-09-20  0:57 ` ericonr
  2021-09-20  0:57 ` [PR REVIEW] " ericonr
@ 2021-09-20  0:58 ` ericonr
  2021-09-20 15:46 ` chexum
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-09-20  0:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33028#discussion_r711832591

Comment:
Shouldn't be necessary to add here, I think.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] New package: libteam 1.31.git20210222
  2021-09-19 16:55 [PR PATCH] New package: libteam 1.31.git20210222 chexum
                   ` (2 preceding siblings ...)
  2021-09-20  0:58 ` ericonr
@ 2021-09-20 15:46 ` chexum
  2021-09-20 17:29 ` ericonr
  2022-05-06 13:57 ` [PR PATCH] [Closed]: " chexum
  5 siblings, 0 replies; 7+ messages in thread
From: chexum @ 2021-09-20 15:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New review comment by chexum on void-packages repository

https://github.com/void-linux/void-packages/pull/33028#discussion_r712294651

Comment:
Good point - there are a heap of examples that I'm putting there as vsconf - I just wasn't sure if I need the vconf handling (for upgrades)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] New package: libteam 1.31.git20210222
  2021-09-19 16:55 [PR PATCH] New package: libteam 1.31.git20210222 chexum
                   ` (3 preceding siblings ...)
  2021-09-20 15:46 ` chexum
@ 2021-09-20 17:29 ` ericonr
  2022-05-06 13:57 ` [PR PATCH] [Closed]: " chexum
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-09-20 17:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33028#discussion_r712373063

Comment:
What you want for upgrades, if anything, is a `conf_files` entry. But it isn't necessary if the package doesn't install its own file.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: New package: libteam 1.31.git20210222
  2021-09-19 16:55 [PR PATCH] New package: libteam 1.31.git20210222 chexum
                   ` (4 preceding siblings ...)
  2021-09-20 17:29 ` ericonr
@ 2022-05-06 13:57 ` chexum
  5 siblings, 0 replies; 7+ messages in thread
From: chexum @ 2022-05-06 13:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1986 bytes --]

There's a closed pull request on the void-packages repository

New package: libteam 1.31.git20210222
https://github.com/void-linux/void-packages/pull/33028

Description:
<!-- Mark items with [x] where applicable -->

libteam, the user-space counterpart of the ethernet teaming/bonding device is the modern tool to provide link aggregation for ethernet devices.  Unfortunately, the most recent proper release misses a few important fixes, so I opted to use the git version instead of providing the patches from github.

It also has some incompatibility with musl, TIPC is always enabled, but it uses a header, sys/queue.h which does not seem to be provided by musl, so I disabled all musl platforms for the time being.

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64-glibc)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-glibc
  - [ ] aarch64-musl
  - [x] armv7l-glibc
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-05-06 13:57 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-19 16:55 [PR PATCH] New package: libteam 1.31.git20210222 chexum
2021-09-20  0:57 ` ericonr
2021-09-20  0:57 ` [PR REVIEW] " ericonr
2021-09-20  0:58 ` ericonr
2021-09-20 15:46 ` chexum
2021-09-20 17:29 ` ericonr
2022-05-06 13:57 ` [PR PATCH] [Closed]: " chexum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).