[PR PATCH] neovim: update to 0.5.1

[PR PATCH] neovim: update to 0.5.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

There is a new pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages neovim-update
https://github.com/void-linux/void-packages/pull/33148

neovim: update to 0.5.1
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33148.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-neovim-update-33148.patch --]
[-- Type: text/x-diff, Size: 994 bytes --]

From deeb5461bca3cb793c1112a6547455d8b4f6df8f Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Mon, 27 Sep 2021 15:48:06 +0700
Subject: [PATCH] neovim: update to 0.5.1

---
 srcpkgs/neovim/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/neovim/template b/srcpkgs/neovim/template
index b5f96221a0f4..3ef416657df1 100644
--- a/srcpkgs/neovim/template
+++ b/srcpkgs/neovim/template
@@ -1,6 +1,6 @@
 # Template file for 'neovim'
 pkgname=neovim
-version=0.5.0
+version=0.5.1
 revision=1
 build_style=cmake
 build_helper="qemu"
@@ -14,7 +14,7 @@ maintainer="Steve Prybylski <sa.prybylx@gmail.com>"
 license="Apache-2.0, custom:Vim"
 homepage="https://neovim.io"
 distfiles="https://github.com/neovim/neovim/archive/v${version}.tar.gz"
-checksum=2294caa9d2011996499fbd70e4006e4ef55db75b99b6719154c09262e23764ef
+checksum=aa449795e5cc69bdd2eeed7095f20b9c086c6ecfcde0ab62ab97a9d04243ec84
 
 alternatives="
  vi:vi:/usr/bin/nvim

Re: neovim: update to 0.5.1

[ram02z]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by ram02z on void-packages repository

https://github.com/void-linux/void-packages/pull/33148#issuecomment-927667222

Comment:
`CMAKE_BUILD_TYPE` should be `Release` for releases, `RelWithDebInfo` is reserved for nightlies.

https://github.com/justinmk/neovim/commit/6f965f41dfd6b1927a23b2afa188fbcb88e8b2f3

Re: [PR PATCH] [Updated] neovim: update to 0.5.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages neovim-update
https://github.com/void-linux/void-packages/pull/33148

neovim: update to 0.5.1
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33148.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-neovim-update-33148.patch --]
[-- Type: text/x-diff, Size: 1353 bytes --]

From a61fe8bd5949d292b4c8c6f3f1bd2c7a64600a5d Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Mon, 27 Sep 2021 15:48:06 +0700
Subject: [PATCH] neovim: update to 0.5.1

Use Release build type for our package instead of RelWithDebInfo
---
 srcpkgs/neovim/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/neovim/template b/srcpkgs/neovim/template
index b5f96221a0f4..4e393c2c0b7a 100644
--- a/srcpkgs/neovim/template
+++ b/srcpkgs/neovim/template
@@ -1,10 +1,10 @@
 # Template file for 'neovim'
 pkgname=neovim
-version=0.5.0
+version=0.5.1
 revision=1
 build_style=cmake
 build_helper="qemu"
-configure_args="-DCMAKE_BUILD_TYPE=RelWithDebInfo"
+configure_args="-DCMAKE_BUILD_TYPE=Release"
 hostmakedepends="pkg-config gettext gperf LuaJIT lua51-lpeg lua51-mpack"
 makedepends="libtermkey-devel libuv-devel libvterm-devel msgpack-devel
  LuaJIT-devel libluv-devel tree-sitter-devel"
@@ -14,7 +14,7 @@ maintainer="Steve Prybylski <sa.prybylx@gmail.com>"
 license="Apache-2.0, custom:Vim"
 homepage="https://neovim.io"
 distfiles="https://github.com/neovim/neovim/archive/v${version}.tar.gz"
-checksum=2294caa9d2011996499fbd70e4006e4ef55db75b99b6719154c09262e23764ef
+checksum=aa449795e5cc69bdd2eeed7095f20b9c086c6ecfcde0ab62ab97a9d04243ec84
 
 alternatives="
  vi:vi:/usr/bin/nvim

Re: neovim: update to 0.5.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33148#issuecomment-927914787

Comment:
Ugh, that kinda sucks. I'm pretty sure CMake strips our CFLAGS in `Release` mode, which includes the debug info stuff.

Re: neovim: update to 0.5.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/33148#issuecomment-927989622

Comment:
> Ugh, that kinda sucks. I'm pretty sure CMake strips our CFLAGS in Release mode, which includes the debug info stuff.

That was why I go with RelWithDebInfo when I made the PR for 0.5.0. But personally I can build neovim myself if I need debug symbols so I'm fine with Release.

Re: neovim: update to 0.5.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/33148#issuecomment-927989622

Comment:
> Ugh, that kinda sucks. I'm pretty sure CMake strips our CFLAGS in Release mode, which includes the debug info stuff.

That was why I went with RelWithDebInfo when I made the PR for 0.5.0. But personally I can build neovim myself if I need debug symbols so I'm fine with Release.

Re: [PR PATCH] [Closed]: neovim: update to 0.5.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

There's a closed pull request on the void-packages repository

neovim: update to 0.5.1
https://github.com/void-linux/void-packages/pull/33148

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: neovim: update to 0.5.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33148#issuecomment-928905329

Comment:
Please check my final commit for an idea of a better commit message. *what* is being done can usually be had by looking at the diff. The most important thing is documenting the *why*.

Re: neovim: update to 0.5.1

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/33148#issuecomment-929016731

Comment:
> Please check my final commit for an idea of a better commit message. what is being done can usually be had by looking at the diff. The most important thing is documenting the why.

Thanks @ericonr I'll remember that :)