* [PR PATCH] cargo-crev: update to 0.20.1
@ 2021-10-02 3:39 cinerea0
2021-10-02 19:43 ` ericonr
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: cinerea0 @ 2021-10-02 3:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]
There is a new pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages crev
https://github.com/void-linux/void-packages/pull/33251
cargo-crev: update to 0.20.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33251.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-crev-33251.patch --]
[-- Type: text/x-diff, Size: 1220 bytes --]
From 0ec321f2221b9db0684bcaf90df82c06869a18f8 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Fri, 1 Oct 2021 23:14:06 -0400
Subject: [PATCH] cargo-crev: update to 0.20.1
---
srcpkgs/cargo-crev/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/cargo-crev/template b/srcpkgs/cargo-crev/template
index 4b6121655aff..0a0623dd0d9f 100644
--- a/srcpkgs/cargo-crev/template
+++ b/srcpkgs/cargo-crev/template
@@ -1,6 +1,6 @@
# Template file for 'cargo-crev'
pkgname=cargo-crev
-version=0.19.2
+version=0.20.1
revision=1
build_style=cargo
make_install_args="--path ./cargo-crev"
@@ -10,8 +10,8 @@ short_desc="Cryptographically verifiable code review system for cargo"
maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
license="MPL-2.0, MIT, Apache-2.0"
homepage="https://github.com/crev-dev/cargo-crev"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=d4b1ab0089ce25d73f2516209d80102e7e674dc851cf49f08e34a963d16e97ad
+distfiles="https://github.com/crev-dev/cargo-crev/archive/refs/tags/${version}.tar.gz"
+checksum=c6a62b29ced440eda20bc285d323d709c750bb8a49712af35e7f43d2587875cc
post_install() {
vlicense LICENSE-APACHE
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cargo-crev: update to 0.20.1
2021-10-02 3:39 [PR PATCH] cargo-crev: update to 0.20.1 cinerea0
@ 2021-10-02 19:43 ` ericonr
2021-10-04 1:05 ` cinerea0
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-10-02 19:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33251#issuecomment-932810827
Comment:
Any idea about the failing test?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cargo-crev: update to 0.20.1
2021-10-02 3:39 [PR PATCH] cargo-crev: update to 0.20.1 cinerea0
2021-10-02 19:43 ` ericonr
@ 2021-10-04 1:05 ` cinerea0
2021-10-04 2:12 ` ericonr
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: cinerea0 @ 2021-10-04 1:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/33251#issuecomment-933068231
Comment:
@ericonr No, sorry. Is it alright if I just close this and the other PR with failing Rust tests and leave it for the actual maintainer to update?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cargo-crev: update to 0.20.1
2021-10-02 3:39 [PR PATCH] cargo-crev: update to 0.20.1 cinerea0
2021-10-02 19:43 ` ericonr
2021-10-04 1:05 ` cinerea0
@ 2021-10-04 2:12 ` ericonr
2021-10-04 20:34 ` cinerea0
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-10-04 2:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33251#issuecomment-933089745
Comment:
We can tag him :P @jcgruenhage
And fwiw their tests don't work either https://github.com/crev-dev/cargo-crev/runs/3209853516
Can you run them locally to see if the results match, at least?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cargo-crev: update to 0.20.1
2021-10-02 3:39 [PR PATCH] cargo-crev: update to 0.20.1 cinerea0
` (2 preceding siblings ...)
2021-10-04 2:12 ` ericonr
@ 2021-10-04 20:34 ` cinerea0
2021-10-29 3:47 ` cinerea0
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: cinerea0 @ 2021-10-04 20:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/33251#issuecomment-933834455
Comment:
Running the tests locally results in the same error found in CI here:
```
running 1 test
test creates_new_id_implicitly ... FAILED
failures:
---- creates_new_id_implicitly stdout ----
thread 'creates_new_id_implicitly' panicked at 'assertion failed: c.run(&[\"id\", \"trust\", \"--level=medium\",\n \"FYlr8YoYGVvDwHQxqEIs89reKKDy-oWisoO0qXXEfHE\"], \"\").status.success()', cargo-crev/tests/clitest.rs:11:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
creates_new_id_implicitly
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s
```
What's interesting is the tests you linked show version 0.21.1 of cargo-crev being compiled, but that version doesn't seem to exist yet.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cargo-crev: update to 0.20.1
2021-10-02 3:39 [PR PATCH] cargo-crev: update to 0.20.1 cinerea0
` (3 preceding siblings ...)
2021-10-04 20:34 ` cinerea0
@ 2021-10-29 3:47 ` cinerea0
2021-10-30 18:51 ` ericonr
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: cinerea0 @ 2021-10-29 3:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 270 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/33251#issuecomment-954406851
Comment:
Just an update, I'm waiting for a response to https://github.com/crev-dev/cargo-crev/issues/421 before I'll be able to fix this.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cargo-crev: update to 0.20.1
2021-10-02 3:39 [PR PATCH] cargo-crev: update to 0.20.1 cinerea0
` (4 preceding siblings ...)
2021-10-29 3:47 ` cinerea0
@ 2021-10-30 18:51 ` ericonr
2021-10-30 20:27 ` [PR PATCH] [Updated] " cinerea0
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-10-30 18:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33251#issuecomment-955576688
Comment:
I can't be forced to care about their tests more than they do. Can you update to 0.21.1 and we can merge?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] cargo-crev: update to 0.20.1
2021-10-02 3:39 [PR PATCH] cargo-crev: update to 0.20.1 cinerea0
` (5 preceding siblings ...)
2021-10-30 18:51 ` ericonr
@ 2021-10-30 20:27 ` cinerea0
2021-10-30 23:58 ` cargo-crev: update to 0.21.1 cinerea0
2021-10-31 1:05 ` [PR PATCH] [Merged]: " ericonr
8 siblings, 0 replies; 10+ messages in thread
From: cinerea0 @ 2021-10-30 20:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages crev
https://github.com/void-linux/void-packages/pull/33251
cargo-crev: update to 0.20.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33251.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-crev-33251.patch --]
[-- Type: text/x-diff, Size: 1221 bytes --]
From e6bafa2942b13060efab7db2be3f96f964593ab6 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Sat, 30 Oct 2021 16:26:58 -0400
Subject: [PATCH] cargo-crev: update to 0.21.1
---
srcpkgs/cargo-crev/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/cargo-crev/template b/srcpkgs/cargo-crev/template
index 4b6121655aff..05b0635dcf51 100644
--- a/srcpkgs/cargo-crev/template
+++ b/srcpkgs/cargo-crev/template
@@ -1,6 +1,6 @@
# Template file for 'cargo-crev'
pkgname=cargo-crev
-version=0.19.2
+version=0.21.1
revision=1
build_style=cargo
make_install_args="--path ./cargo-crev"
@@ -10,8 +10,8 @@ short_desc="Cryptographically verifiable code review system for cargo"
maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
license="MPL-2.0, MIT, Apache-2.0"
homepage="https://github.com/crev-dev/cargo-crev"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=d4b1ab0089ce25d73f2516209d80102e7e674dc851cf49f08e34a963d16e97ad
+distfiles="https://github.com/crev-dev/cargo-crev/archive/refs/tags/${version}.tar.gz"
+checksum=223f2603afe739a618275b89c4b79528fc5b766beab70614f22dddfebef3935d
post_install() {
vlicense LICENSE-APACHE
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: cargo-crev: update to 0.21.1
2021-10-02 3:39 [PR PATCH] cargo-crev: update to 0.20.1 cinerea0
` (6 preceding siblings ...)
2021-10-30 20:27 ` [PR PATCH] [Updated] " cinerea0
@ 2021-10-30 23:58 ` cinerea0
2021-10-31 1:05 ` [PR PATCH] [Merged]: " ericonr
8 siblings, 0 replies; 10+ messages in thread
From: cinerea0 @ 2021-10-30 23:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/33251#issuecomment-955609700
Comment:
@ericonr Our tests now fail the same way upstream's do. Does that mean this is okay to merge?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Merged]: cargo-crev: update to 0.21.1
2021-10-02 3:39 [PR PATCH] cargo-crev: update to 0.20.1 cinerea0
` (7 preceding siblings ...)
2021-10-30 23:58 ` cargo-crev: update to 0.21.1 cinerea0
@ 2021-10-31 1:05 ` ericonr
8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-10-31 1:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
There's a merged pull request on the void-packages repository
cargo-crev: update to 0.21.1
https://github.com/void-linux/void-packages/pull/33251
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-10-31 1:05 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-02 3:39 [PR PATCH] cargo-crev: update to 0.20.1 cinerea0
2021-10-02 19:43 ` ericonr
2021-10-04 1:05 ` cinerea0
2021-10-04 2:12 ` ericonr
2021-10-04 20:34 ` cinerea0
2021-10-29 3:47 ` cinerea0
2021-10-30 18:51 ` ericonr
2021-10-30 20:27 ` [PR PATCH] [Updated] " cinerea0
2021-10-30 23:58 ` cargo-crev: update to 0.21.1 cinerea0
2021-10-31 1:05 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).