Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] flatbuffers: update to 2.0.0
@ 2021-10-04 17:09 marmeladema
  2021-10-05 21:16 ` [PR REVIEW] " Piraty
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: marmeladema @ 2021-10-04 17:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

There is a new pull request by marmeladema against master on the void-packages repository

https://github.com/marmeladema/void-packages flatbuffers-2.0.0
https://github.com/void-linux/void-packages/pull/33319

flatbuffers: update to 2.0.0
<!-- Mark items with [x] where applicable -->

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/33319.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-flatbuffers-2.0.0-33319.patch --]
[-- Type: text/x-diff, Size: 1560 bytes --]

From b61a72cb0bd3519d191228f8ec45e65b52df71cd Mon Sep 17 00:00:00 2001
From: Elie ROUDNINSKI <xademax@gmail.com>
Date: Mon, 4 Oct 2021 18:01:45 +0100
Subject: [PATCH] flatbuffers: update to 2.0.0

---
 srcpkgs/flatbuffers/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/flatbuffers/template b/srcpkgs/flatbuffers/template
index 86c89090cc94..6f23a84a56ff 100644
--- a/srcpkgs/flatbuffers/template
+++ b/srcpkgs/flatbuffers/template
@@ -1,6 +1,6 @@
 # Template file for 'flatbuffers'
 pkgname=flatbuffers
-version=1.12.0
+version=2.0.0
 revision=1
 build_style=cmake
 short_desc="Memory efficient serialization library"
@@ -8,7 +8,7 @@ maintainer="Elie ROUDNINSKI <xademax@gmail.com>"
 license="Apache-2.0"
 homepage="https://google.github.io/flatbuffers/"
 distfiles="https://github.com/google/${pkgname}/archive/v${version}.tar.gz"
-checksum=62f2223fb9181d1d6338451375628975775f7522185266cd5296571ac152bc45
+checksum=9ddb9031798f4f8754d00fca2f1a68ecf9d0f83dfac7239af1311e4fd9a565c4
 
 if [ "$CROSS_BUILD" ]; then
 	# Disable tests to prevent executing target binaries on host
@@ -19,7 +19,7 @@ case "$XBPS_TARGET_MACHINE" in
 	*-musl) configure_args+=" -DFLATBUFFERS_LOCALE_INDEPENDENT=0";;
 esac
 
-CXXFLAGS="-Wno-class-memaccess -Wno-stringop-overflow"
+CXXFLAGS="-O"
 
 flatbuffers-devel_package() {
 	short_desc+=" - development files"
@@ -28,5 +28,6 @@ flatbuffers-devel_package() {
 		vmove usr/include
 		vmove usr/lib/cmake
 		vmove usr/lib/libflatbuffers.a
+		vmove usr/lib/pkgconfig/flatbuffers.pc
 	}
 }

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] flatbuffers: update to 2.0.0
  2021-10-04 17:09 [PR PATCH] flatbuffers: update to 2.0.0 marmeladema
@ 2021-10-05 21:16 ` Piraty
  2021-10-05 21:28 ` marmeladema
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Piraty @ 2021-10-05 21:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/33319#discussion_r722713387

Comment:
?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] flatbuffers: update to 2.0.0
  2021-10-04 17:09 [PR PATCH] flatbuffers: update to 2.0.0 marmeladema
  2021-10-05 21:16 ` [PR REVIEW] " Piraty
@ 2021-10-05 21:28 ` marmeladema
  2021-10-06 21:00 ` Piraty
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: marmeladema @ 2021-10-05 21:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

New review comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/33319#discussion_r722720424

Comment:
Fortify source level 2 that is enabled by default by void build scripts requires that code is compiled with optimization enabled.
But maybe there is something that I have misunderstood?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] flatbuffers: update to 2.0.0
  2021-10-04 17:09 [PR PATCH] flatbuffers: update to 2.0.0 marmeladema
  2021-10-05 21:16 ` [PR REVIEW] " Piraty
  2021-10-05 21:28 ` marmeladema
@ 2021-10-06 21:00 ` Piraty
  2021-10-12 19:30 ` ericonr
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Piraty @ 2021-10-06 21:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/33319#discussion_r723672275

Comment:
`-O2` is the default
https://github.com/void-linux/void-packages/blob/541bb0ea7d5480c51b245cae5d44a93da1fd9211/etc/defaults.conf#L31-L32


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] flatbuffers: update to 2.0.0
  2021-10-04 17:09 [PR PATCH] flatbuffers: update to 2.0.0 marmeladema
                   ` (2 preceding siblings ...)
  2021-10-06 21:00 ` Piraty
@ 2021-10-12 19:30 ` ericonr
  2021-10-12 19:30 ` ericonr
  2021-10-15  8:23 ` marmeladema
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-10-12 19:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33319#discussion_r727430913

Comment:
If you're getting warning from headers, you need -O2 in `CPPFLAGS`, possibly.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] flatbuffers: update to 2.0.0
  2021-10-04 17:09 [PR PATCH] flatbuffers: update to 2.0.0 marmeladema
                   ` (3 preceding siblings ...)
  2021-10-12 19:30 ` ericonr
@ 2021-10-12 19:30 ` ericonr
  2021-10-15  8:23 ` marmeladema
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-10-12 19:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33319#discussion_r727430913

Comment:
If you're getting warning from headers, you need -O2 in `CPPFLAGS`, possibly. But you should be fine ignoring said headers.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] flatbuffers: update to 2.0.0
  2021-10-04 17:09 [PR PATCH] flatbuffers: update to 2.0.0 marmeladema
                   ` (4 preceding siblings ...)
  2021-10-12 19:30 ` ericonr
@ 2021-10-15  8:23 ` marmeladema
  5 siblings, 0 replies; 7+ messages in thread
From: marmeladema @ 2021-10-15  8:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/33319#discussion_r729621564

Comment:
I am getting compile *errors*

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-10-15  8:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 17:09 [PR PATCH] flatbuffers: update to 2.0.0 marmeladema
2021-10-05 21:16 ` [PR REVIEW] " Piraty
2021-10-05 21:28 ` marmeladema
2021-10-06 21:00 ` Piraty
2021-10-12 19:30 ` ericonr
2021-10-12 19:30 ` ericonr
2021-10-15  8:23 ` marmeladema

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ https://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git