[PR PATCH] pan: update to 0.147.

[PR PATCH] pan: update to 0.147.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

There is a new pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages pan
https://github.com/void-linux/void-packages/pull/33403

pan: update to 0.147.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33403.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pan-33403.patch --]
[-- Type: text/x-diff, Size: 1875 bytes --]

From 4f19152f5f0df98dbf2b768f757bb7d7e04fd7f9 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Thu, 7 Oct 2021 14:57:08 +0300
Subject: [PATCH] pan: update to 0.147.

---
 srcpkgs/pan/template | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/pan/template b/srcpkgs/pan/template
index 3c7d76534e75..53fbe7ce431d 100644
--- a/srcpkgs/pan/template
+++ b/srcpkgs/pan/template
@@ -1,15 +1,24 @@
 # Template file for 'pan'
 pkgname=pan
-version=0.146
+version=0.147
 revision=1
+wrksrc="pan-PAN_${version/./_}"
 build_style=gnu-configure
 configure_args="--with-gnutls --with-gtk3 --with-gmime30 --enable-libnotify --enable-gkr"
-hostmakedepends="gettext pkg-config yelp-tools"
-makedepends="gmime3-devel gnutls-devel gtk+3-devel libsecret-devel gtkspell3-devel libnotify-devel"
+hostmakedepends="gettext pkg-config yelp-tools autoconf gettext-devel-tools automake"
+makedepends="gmime-devel gmime3-devel gnutls-devel gtk+3-devel libsecret-devel gtkspell3-devel libnotify-devel
+ glib-devel"
 depends="desktop-file-utils hicolor-icon-theme"
 short_desc="Usenet newsreader that's good at both text and binaries"
 maintainer="mobinmob <mobinmob@disroot.org>"
 license="GFDL-1.1-or-later, GPL-2.0-only"
 homepage="http://pan.rebelbase.com"
-distfiles="http://pan.rebelbase.com/download/releases/${version}/source/pan-${version}.tar.bz2"
-checksum=a52c28664652ddbd1639faf99cdb93969c3dd3e0e0ddb9a1b24711ab8f684f9d
+distfiles="https://gitlab.gnome.org/GNOME/pan/-/archive/PAN_${version/./_}/pan-PAN_${version/./_}.tar.bz2"
+checksum=5a219ca229ea7d4f46aec0d7055f082a79fdec0bb5e3d7f32f2b4e9a53e4c952
+
+pre_configure() {
+	vsed -e 's/enchant/enchant-2/g' -i configure.ac
+	vsed -e 's|enchant/enchant.h|enchant-2/enchant.h|' -i pan/gui/group-prefs-dialog.cc
+	vsed -e '/AM_PATH_GTK_2_0/d' -i configure.ac
+	./autogen.sh
+}

Re: [PR REVIEW] pan: update to 0.147.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33403#discussion_r724478405

Comment:
`gmime-devel gmime3-devel`
a bit strange

Re: [PR REVIEW] pan: update to 0.147.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33403#discussion_r724479317

Comment:
> WARNING: I am going to run 'configure' with no arguments.

`NOCONFIGURE=1 ./autogen.sh` sometimes helps for cross build

Re: [PR REVIEW] pan: update to 0.147.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/33403#discussion_r724490195

Comment:
It is!
But configure produces errors if any of them is not present...
```
checking for gmime-2.6 >= 2.6.20... no
configure: error: Package requirements (gmime-2.6 >= 2.6.20) were not met:

No package 'gmime-2.6' found
```

```
checking for gmime-3.0 >= 3.0.0... no
configure: error: Package requirements (gmime-3.0 >= 3.0.0) were not met:

No package 'gmime-3.0' found
```

Re: [PR REVIEW] pan: update to 0.147.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/33403#discussion_r724490948

Comment:
Thank you!
Unfortunately that does not fix cross-build :(  

Re: [PR PATCH] [Updated] pan: update to 0.147.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages pan
https://github.com/void-linux/void-packages/pull/33403

pan: update to 0.147.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33403.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pan-33403.patch --]
[-- Type: text/x-diff, Size: 1949 bytes --]

From 9d4df310768d5ca75c9558b272ad3e07bc9b697d Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Thu, 7 Oct 2021 14:57:08 +0300
Subject: [PATCH] pan: update to 0.148.

---
 srcpkgs/pan/template | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/pan/template b/srcpkgs/pan/template
index 3c7d76534e75..201679524b9e 100644
--- a/srcpkgs/pan/template
+++ b/srcpkgs/pan/template
@@ -1,15 +1,23 @@
 # Template file for 'pan'
 pkgname=pan
-version=0.146
+version=0.148
 revision=1
+wrksrc="pan-v${version}"
 build_style=gnu-configure
-configure_args="--with-gnutls --with-gtk3 --with-gmime30 --enable-libnotify --enable-gkr"
-hostmakedepends="gettext pkg-config yelp-tools"
-makedepends="gmime3-devel gnutls-devel gtk+3-devel libsecret-devel gtkspell3-devel libnotify-devel"
+configure_args="--with-gnutls --with-gtk3 --enable-libnotify --enable-gkr"
+hostmakedepends="gettext pkg-config yelp-tools autoconf gettext-devel-tools automake libtool"
+makedepends="gmime3-devel gnutls-devel gtk+3-devel gtk+-devel libsecret-devel gtkspell3-devel libnotify-devel
+ glib-devel"
 depends="desktop-file-utils hicolor-icon-theme"
 short_desc="Usenet newsreader that's good at both text and binaries"
 maintainer="mobinmob <mobinmob@disroot.org>"
 license="GFDL-1.1-or-later, GPL-2.0-only"
 homepage="http://pan.rebelbase.com"
-distfiles="http://pan.rebelbase.com/download/releases/${version}/source/pan-${version}.tar.bz2"
-checksum=a52c28664652ddbd1639faf99cdb93969c3dd3e0e0ddb9a1b24711ab8f684f9d
+distfiles="https://gitlab.gnome.org/GNOME/pan/-/archive/v${version}/pan-v${version}.tar.bz2"
+checksum=09de1b59407c5c037b01edb11a4611ca702ae250f0d1f30456a103a5f5eb2e85
+
+pre_configure() {
+	vsed -e 's/enchant/enchant-2/g' -i configure.ac
+	vsed -e 's|enchant/enchant.h|enchant-2/enchant.h|' -i pan/gui/group-prefs-dialog.cc
+	ACLOCAL='aclocal -I ${XBPS_CROSS_BASE}/usr/share/aclocal' ./autogen.sh
+}

Re: [PR REVIEW] pan: update to 0.148.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/33403#discussion_r745682908

Comment:
Fixed upstrean on 0.148.

Re: pan: update to 0.148.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/33403#issuecomment-964221391

Comment:
- Rebase on master.
- Update template to version 0.148.
More problems with cross-compiling.

Re: [PR REVIEW] pan: update to 0.148.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33403#discussion_r745887614

Comment:
Can you try again? The script includes that condition.

Re: [PR REVIEW] pan: update to 0.148.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/33403#discussion_r745909355

Comment:
It works, needs some adittional modifications. I am crossbuilding locally to confirm ;)

Re: [PR PATCH] [Updated] pan: update to 0.148.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages pan
https://github.com/void-linux/void-packages/pull/33403

pan: update to 0.148.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33403.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pan-33403.patch --]
[-- Type: text/x-diff, Size: 2145 bytes --]

From a62dea512a36f44863fac730c96258ce6034e918 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Thu, 7 Oct 2021 14:57:08 +0300
Subject: [PATCH] pan: update to 0.148.

Also:
- add changelog.
---
 srcpkgs/pan/template | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/pan/template b/srcpkgs/pan/template
index 3c7d76534e75..fddfb24f78e0 100644
--- a/srcpkgs/pan/template
+++ b/srcpkgs/pan/template
@@ -1,15 +1,29 @@
 # Template file for 'pan'
 pkgname=pan
-version=0.146
+version=0.148
 revision=1
+wrksrc="pan-v${version}"
 build_style=gnu-configure
-configure_args="--with-gnutls --with-gtk3 --with-gmime30 --enable-libnotify --enable-gkr"
-hostmakedepends="gettext pkg-config yelp-tools"
-makedepends="gmime3-devel gnutls-devel gtk+3-devel libsecret-devel gtkspell3-devel libnotify-devel"
+configure_args="--with-gnutls --with-gtk3 --enable-libnotify --enable-gkr"
+hostmakedepends="gettext pkg-config yelp-tools autoconf gettext-devel-tools automake libtool"
+makedepends="gmime3-devel gnutls-devel gtk+3-devel gtk+-devel libsecret-devel gtkspell3-devel libnotify-devel
+ glib-devel"
 depends="desktop-file-utils hicolor-icon-theme"
 short_desc="Usenet newsreader that's good at both text and binaries"
 maintainer="mobinmob <mobinmob@disroot.org>"
 license="GFDL-1.1-or-later, GPL-2.0-only"
 homepage="http://pan.rebelbase.com"
-distfiles="http://pan.rebelbase.com/download/releases/${version}/source/pan-${version}.tar.bz2"
-checksum=a52c28664652ddbd1639faf99cdb93969c3dd3e0e0ddb9a1b24711ab8f684f9d
+changelog="https://gitlab.gnome.org/GNOME/pan/-/raw/master/NEWS"
+distfiles="https://gitlab.gnome.org/GNOME/pan/-/archive/v${version}/pan-v${version}.tar.bz2"
+checksum=09de1b59407c5c037b01edb11a4611ca702ae250f0d1f30456a103a5f5eb2e85
+
+if [ -n "$CROSS_BUILD" ]; then
+		hostmakedepends+=" gdk-pixbuf-devel"
+fi
+
+pre_configure() {
+	vsed -e 's/enchant/enchant-2/g' -i configure.ac
+	vsed -e 's|enchant/enchant.h|enchant-2/enchant.h|' -i pan/gui/group-prefs-dialog.cc
+	export ACLOCAL='aclocal -I ${XBPS_CROSS_BASE}/usr/share/aclocal'
+	NOCONFIGURE=1 ./autogen.sh
+}

Re: [PR REVIEW] pan: update to 0.148.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/33403#discussion_r745928938

Comment:
The export ACLOCAL and gdk-pidbux-devel on hostmakedepends are also needed for cross build. It should compile now - tested locally for aarch64 and aarch64-musl.

Re: [PR PATCH] [Merged]: pan: update to 0.148.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

There's a merged pull request on the void-packages repository

pan: update to 0.148.
https://github.com/void-linux/void-packages/pull/33403

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->