Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] python3-frozendict: update to 2.0.6.
@ 2021-10-12 12:42 TinfoilSubmarine
  2021-10-12 18:28 ` ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: TinfoilSubmarine @ 2021-10-12 12:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2068 bytes --]

There is a new pull request by TinfoilSubmarine against master on the void-packages repository

https://github.com/TinfoilSubmarine/void-packages frozendict
https://github.com/void-linux/void-packages/pull/33495

python3-frozendict: update to 2.0.6.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Bumping to latest version to fix this deprecation error on Python 3.10:
```
----> 1 import frozendict

/usr/lib/python3.10/site-packages/frozendict/__init__.py in <module>
     14 
     15 
---> 16 class frozendict(collections.Mapping):
     17     """
     18     An immutable wrapper around dictionaries that implements the complete :py:class:`collections.Mapping`

AttributeError: module 'collections' has no attribute 'Mapping'
```

A patch file from https://github.com/void-linux/void-packages/pull/33495.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-frozendict-33495.patch --]
[-- Type: text/x-diff, Size: 2261 bytes --]

From 854d360aff9dc86ca30eb408c37a94643cc73ba5 Mon Sep 17 00:00:00 2001
From: Joel Beckmeyer <joel@beckmeyer.us>
Date: Mon, 11 Oct 2021 19:40:40 -0400
Subject: [PATCH] python3-frozendict: update to 2.0.6.

---
 .../python3-frozendict/patches/build-py.patch | 13 +++++++++++
 srcpkgs/python3-frozendict/template           | 22 ++++++++++++-------
 2 files changed, 27 insertions(+), 8 deletions(-)
 create mode 100644 srcpkgs/python3-frozendict/patches/build-py.patch

diff --git a/srcpkgs/python3-frozendict/patches/build-py.patch b/srcpkgs/python3-frozendict/patches/build-py.patch
new file mode 100644
index 000000000000..4ec531e6aa66
--- /dev/null
+++ b/srcpkgs/python3-frozendict/patches/build-py.patch
@@ -0,0 +1,13 @@
+diff --git a/setup.py b/setup.py
+index 462ee99..c287130 100755
+--- a/setup.py
++++ b/setup.py
+@@ -157,7 +157,7 @@ common_setup_args = dict(
+     keywords = keywords,
+ )
+ 
+-custom_arg = None
++custom_arg = "py"
+ 
+ if len(argv) > 1 and (argv[1] == "py" or argv[1] == "c_debug"):
+     custom_arg = argv[1]
diff --git a/srcpkgs/python3-frozendict/template b/srcpkgs/python3-frozendict/template
index 274f14db49f9..479b6b47a656 100644
--- a/srcpkgs/python3-frozendict/template
+++ b/srcpkgs/python3-frozendict/template
@@ -1,19 +1,25 @@
 # Template file for 'python3-frozendict'
 pkgname=python3-frozendict
-version=1.2
-revision=4
+version=2.0.6
+revision=1
 wrksrc="frozendict-${version}"
 build_style=python3-module
-pycompile_module="frozendict"
 hostmakedepends="python3-setuptools"
 depends="python3"
+checkdepends="python3-pytest"
 short_desc="Immutable mapping for Python3"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="MIT"
-homepage="https://github.com/slezica/python-frozendict"
+license="LGPL-3.0-only"
+homepage="https://github.com/Marco-Sulla/python-frozendict"
 distfiles="${PYPI_SITE}/f/frozendict/frozendict-${version}.tar.gz"
-checksum=774179f22db2ef8a106e9c38d4d1f8503864603db08de2e33be5b778230f6e45
+checksum=3f00de72805cf4c9e81b334f3f04809278b967d2fed84552313a0fcce511beb1
 
-post_install() {
-	vlicense LICENSE.txt
+pre_patch() {
+	# remove c implementation tests
+	cd test
+	rm c_only.py
+	rm test_frozendict_c.py
+	rm test_frozendict_c_subclass.py
+	rm test_coold.py
+	rm test_coold_subclass.py
 }

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: python3-frozendict: update to 2.0.6.
  2021-10-12 12:42 [PR PATCH] python3-frozendict: update to 2.0.6 TinfoilSubmarine
@ 2021-10-12 18:28 ` ericonr
  2021-10-12 18:32 ` TinfoilSubmarine
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-10-12 18:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33495#issuecomment-941270954

Comment:
Have you tested synapse and canonicaljson with it?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: python3-frozendict: update to 2.0.6.
  2021-10-12 12:42 [PR PATCH] python3-frozendict: update to 2.0.6 TinfoilSubmarine
  2021-10-12 18:28 ` ericonr
@ 2021-10-12 18:32 ` TinfoilSubmarine
  2021-10-16  0:05 ` TinfoilSubmarine
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: TinfoilSubmarine @ 2021-10-12 18:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/33495#issuecomment-941274468

Comment:
Yes, currently installed on my machine running `synapse` with no issues.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: python3-frozendict: update to 2.0.6.
  2021-10-12 12:42 [PR PATCH] python3-frozendict: update to 2.0.6 TinfoilSubmarine
  2021-10-12 18:28 ` ericonr
  2021-10-12 18:32 ` TinfoilSubmarine
@ 2021-10-16  0:05 ` TinfoilSubmarine
  2021-10-16  0:36 ` ericonr
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: TinfoilSubmarine @ 2021-10-16  0:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/33495#issuecomment-944817894

Comment:
Is this ready to be merged? The current `python3-frozendict` package is completely non-functional and anyone upgrading `synapse` will be unable to run it when restarting `synapse` after the upgrade. If there is any more validation/testing needed let me know and I can take a look, but this has been running stable on my server for almost 4 days now.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: python3-frozendict: update to 2.0.6.
  2021-10-12 12:42 [PR PATCH] python3-frozendict: update to 2.0.6 TinfoilSubmarine
                   ` (2 preceding siblings ...)
  2021-10-16  0:05 ` TinfoilSubmarine
@ 2021-10-16  0:36 ` ericonr
  2021-10-16  0:36 ` [PR PATCH] [Merged]: " ericonr
  2021-10-16  0:36 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-10-16  0:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33495#issuecomment-944826182

Comment:
Sorry! It slipped through.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: python3-frozendict: update to 2.0.6.
  2021-10-12 12:42 [PR PATCH] python3-frozendict: update to 2.0.6 TinfoilSubmarine
                   ` (3 preceding siblings ...)
  2021-10-16  0:36 ` ericonr
@ 2021-10-16  0:36 ` ericonr
  2021-10-16  0:36 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-10-16  0:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

There's a merged pull request on the void-packages repository

python3-frozendict: update to 2.0.6.
https://github.com/void-linux/void-packages/pull/33495

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Bumping to latest version to fix this deprecation error on Python 3.10:
```
----> 1 import frozendict

/usr/lib/python3.10/site-packages/frozendict/__init__.py in <module>
     14 
     15 
---> 16 class frozendict(collections.Mapping):
     17     """
     18     An immutable wrapper around dictionaries that implements the complete :py:class:`collections.Mapping`

AttributeError: module 'collections' has no attribute 'Mapping'
```

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: python3-frozendict: update to 2.0.6.
  2021-10-12 12:42 [PR PATCH] python3-frozendict: update to 2.0.6 TinfoilSubmarine
                   ` (4 preceding siblings ...)
  2021-10-16  0:36 ` [PR PATCH] [Merged]: " ericonr
@ 2021-10-16  0:36 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-10-16  0:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33495#issuecomment-944826207

Comment:
Thanks for pinging.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-10-16  0:36 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12 12:42 [PR PATCH] python3-frozendict: update to 2.0.6 TinfoilSubmarine
2021-10-12 18:28 ` ericonr
2021-10-12 18:32 ` TinfoilSubmarine
2021-10-16  0:05 ` TinfoilSubmarine
2021-10-16  0:36 ` ericonr
2021-10-16  0:36 ` [PR PATCH] [Merged]: " ericonr
2021-10-16  0:36 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).