[PR PATCH] starfighter: update to 2.4.

[PR PATCH] starfighter: update to 2.4.

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]

There is a new pull request by TinfoilSubmarine against master on the void-packages repository

https://github.com/TinfoilSubmarine/void-packages starfighter
https://github.com/void-linux/void-packages/pull/33510

starfighter: update to 2.4.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33510.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-starfighter-33510.patch --]
[-- Type: text/x-diff, Size: 1507 bytes --]

From 4b5815d010f44710c1181e2d572310e8c6c7f36e Mon Sep 17 00:00:00 2001
From: Joel Beckmeyer <joel@beckmeyer.us>
Date: Tue, 12 Oct 2021 15:40:46 -0400
Subject: [PATCH] starfighter: update to 2.4.

---
 srcpkgs/starfighter/template | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/starfighter/template b/srcpkgs/starfighter/template
index 0b13c8578649..59e70dc70271 100644
--- a/srcpkgs/starfighter/template
+++ b/srcpkgs/starfighter/template
@@ -1,21 +1,24 @@
 # Template file for 'starfighter'
 pkgname=starfighter
-version=2.0.0.2
-revision=2
-_version="${version%.*.*}"
+version=2.4
+revision=1
 build_style=gnu-configure
 configure_args="exec_prefix=/usr"
-hostmakedepends="pkg-config automake"
-makedepends="SDL2_image-devel SDL2_mixer-devel"
+hostmakedepends="pkg-config automake gettext"
+makedepends="SDL2_image-devel SDL2_mixer-devel SDL2_ttf-devel pango-devel"
 depends="desktop-file-utils"
 short_desc="Side-scrolling shoot 'em up space game"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://pr-starfighter.github.io"
 distfiles="https://github.com/pr-starfighter/starfighter/archive/v${version}.tar.gz"
-checksum=100562f2e12530ff4e360898ec5aace7f2c99806a9cba68d02466e82f8c1ae83
+checksum=d0757da7657253316053acf37dabf8e54607420d66a4d7cc2a9fc0d4b4d54074
 replaces="starfighter-data>=0"
 
+if [ "$CROSS_BUILD" ]; then
+	hostmakedepends+=" python3"
+fi
+
 pre_configure() {
-	autoreconf -fi
+	./autogen.sh
 }

Re: [PR REVIEW] starfighter: update to 2.4.

[abenson]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/33510#discussion_r738871071

Comment:
Why not just add `python3` to the `hostmakedepends`?

Re: starfighter: update to 2.4.

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/33510#issuecomment-954429850

Comment:
I was able to build this locally on `x86_64/glibc` and play the game with out any issues.  This will need a rebase onto master prior to merging, though.

Re: [PR PATCH] [Updated] starfighter: update to 2.4.

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

There is an updated pull request by TinfoilSubmarine against master on the void-packages repository

https://github.com/TinfoilSubmarine/void-packages starfighter
https://github.com/void-linux/void-packages/pull/33510

starfighter: update to 2.4.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33510.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-starfighter-33510.patch --]
[-- Type: text/x-diff, Size: 1445 bytes --]

From f6364266c5a3630b90966eea895d0216a5076c3e Mon Sep 17 00:00:00 2001
From: Joel Beckmeyer <joel@beckmeyer.us>
Date: Tue, 12 Oct 2021 15:40:46 -0400
Subject: [PATCH] starfighter: update to 2.4.

---
 srcpkgs/starfighter/template | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/starfighter/template b/srcpkgs/starfighter/template
index 0b13c8578649..265314882ae8 100644
--- a/srcpkgs/starfighter/template
+++ b/srcpkgs/starfighter/template
@@ -1,21 +1,20 @@
 # Template file for 'starfighter'
 pkgname=starfighter
-version=2.0.0.2
-revision=2
-_version="${version%.*.*}"
+version=2.4
+revision=1
 build_style=gnu-configure
 configure_args="exec_prefix=/usr"
-hostmakedepends="pkg-config automake"
-makedepends="SDL2_image-devel SDL2_mixer-devel"
+hostmakedepends="pkg-config automake gettext python3"
+makedepends="SDL2_image-devel SDL2_mixer-devel SDL2_ttf-devel pango-devel"
 depends="desktop-file-utils"
 short_desc="Side-scrolling shoot 'em up space game"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://pr-starfighter.github.io"
 distfiles="https://github.com/pr-starfighter/starfighter/archive/v${version}.tar.gz"
-checksum=100562f2e12530ff4e360898ec5aace7f2c99806a9cba68d02466e82f8c1ae83
+checksum=d0757da7657253316053acf37dabf8e54607420d66a4d7cc2a9fc0d4b4d54074
 replaces="starfighter-data>=0"
 
 pre_configure() {
-	autoreconf -fi
+	./autogen.sh
 }

Re: [PR PATCH] [Merged]: starfighter: update to 2.4.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

There's a merged pull request on the void-packages repository

starfighter: update to 2.4.
https://github.com/void-linux/void-packages/pull/33510

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->