[PR PATCH] Manual.md: require justification for make_check

[PR PATCH] Manual.md: require justification for make_check

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

There is a new pull request by Chocimier against master on the void-packages repository

https://github.com/Chocimier/void-packages-org explain_make_check
https://github.com/void-linux/void-packages/pull/33574

Manual.md: require justification for make_check
Helps to decide if tests can be reenabled.

xlint can check that with https://github.com/Chocimier/xtools/commit/2c9348ee837703994d0f367a4bb478e6b08a519f

Alternatively, we could split make_check into per-current-value variables set to freeform text, then ban `=yes|on|1|true`  on make_check_*, nocross, lib32disabled etc.

A patch file from https://github.com/void-linux/void-packages/pull/33574.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-explain_make_check-33574.patch --]
[-- Type: text/x-diff, Size: 935 bytes --]

From 406040f74c0ffdf384ff61fdbb170398a04231eb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Fri, 15 Oct 2021 19:47:27 +0200
Subject: [PATCH] Manual.md: require justification for make_check

---
 Manual.md | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Manual.md b/Manual.md
index db605c52135f..99c301f417eb 100644
--- a/Manual.md
+++ b/Manual.md
@@ -605,8 +605,7 @@ patches to the package sources during `do_patch()`. Patches are stored in
 and `XBPS_MAKEJOBS` has no effect.
 
 - `make_check` Sets the cases in which the `check` phase is run.
-This option should usually be accompanied by a comment explaining why it was set, especially when
-set to `no`.
+This option need to be accompanied by a comment explaining why tests do fail.
 Allowed values:
   - `yes` (the default) to run if `XBPS_CHECK_PKGS` is set.
   - `extended` to run if `XBPS_CHECK_PKGS` is `full`.

Re: [PR REVIEW] Manual.md: require justification for make_check

[paper42]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33574#discussion_r730076564

Comment:
```suggestion
This option has to be accompanied by a comment explaining why the tests fail.
```

Re: [PR PATCH] [Updated] Manual.md: require justification for make_check

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

There is an updated pull request by Chocimier against master on the void-packages repository

https://github.com/Chocimier/void-packages-org explain_make_check
https://github.com/void-linux/void-packages/pull/33574

Manual.md: require justification for make_check
Helps to decide if tests can be reenabled.

xlint can check that with https://github.com/Chocimier/xtools/commit/2c9348ee837703994d0f367a4bb478e6b08a519f

Alternatively, we could split make_check into per-current-value variables set to freeform text, then ban `=yes|on|1|true`  on make_check_*, nocross, lib32disabled etc.

A patch file from https://github.com/void-linux/void-packages/pull/33574.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-explain_make_check-33574.patch --]
[-- Type: text/x-diff, Size: 935 bytes --]

From d261d2068851172d2fb37bcc3dbbb2bb76052160 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Fri, 15 Oct 2021 19:47:27 +0200
Subject: [PATCH] Manual.md: require justification for make_check

---
 Manual.md | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Manual.md b/Manual.md
index db605c52135f..0f268fa79ea0 100644
--- a/Manual.md
+++ b/Manual.md
@@ -605,8 +605,7 @@ patches to the package sources during `do_patch()`. Patches are stored in
 and `XBPS_MAKEJOBS` has no effect.
 
 - `make_check` Sets the cases in which the `check` phase is run.
-This option should usually be accompanied by a comment explaining why it was set, especially when
-set to `no`.
+This option has to be accompanied by a comment explaining why the tests fail.
 Allowed values:
   - `yes` (the default) to run if `XBPS_CHECK_PKGS` is set.
   - `extended` to run if `XBPS_CHECK_PKGS` is `full`.

Re: [PR PATCH] [Merged]: Manual.md: require justification for make_check

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There's a merged pull request on the void-packages repository

Manual.md: require justification for make_check
https://github.com/void-linux/void-packages/pull/33574

Description:
Helps to decide if tests can be reenabled.

xlint can check that with https://github.com/Chocimier/xtools/commit/2c9348ee837703994d0f367a4bb478e6b08a519f

Alternatively, we could split make_check into per-current-value variables set to freeform text, then ban `=yes|on|1|true`  on make_check_*, nocross, lib32disabled etc.