[ISSUE] vipw/vigr displays y/n question only *after* receiving answer

[ISSUE] vipw/vigr displays y/n question only *after* receiving answer

[loreb]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

New issue by loreb on void-packages repository

https://github.com/void-linux/void-packages/issues/33699

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname:  
  Void 5.13.19_1 x86_64-musl GenuineIntel uptodate rFF
* package:  
  util-linux-2.37.2_1

### Expected behavior
The program prints "Would you like to edit (filename) now [y/n]? ", I see the question and reply

### Actual behavior
The program shows nothing, I type "y" and *then* it prints the question - there should be a `fflush(stdout)` between printf and fgets in login-utils/vipw.c:354, or to be even safer set stdout to unbuffered right on program startup.

### Steps to reproduce the behavior
as root, run vipw or vigr on a musl system using /etc/shadow, modify anything and see

Re: vipw/vigr displays y/n question only *after* receiving answer

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/33699#issuecomment-949650432

Comment:
Would you like to try sending a patch upstream or should I?

Re: vipw/vigr displays y/n question only *after* receiving answer

[loreb]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

New comment by loreb on void-packages repository

https://github.com/void-linux/void-packages/issues/33699#issuecomment-949700598

Comment:
If you already know how they work (mailing list, github, whatever) please send it, otherwise tell me and I'll do it.
Btw, would you happen to know if there's any linter or something to warn about these things? Not even clang's -Weverything has anything to say, and my search results are overwhelmed by tutorials/questions etc about stdout, fflush & co

Re: vipw/vigr displays y/n question only *after* receiving answer

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/33699#issuecomment-949832132

Comment:
https://github.com/karelzak/util-linux/pull/1481 will wait for upstream to answer, then we can backport the patch. Feel free to open a PR doing it ;)

Re: vipw/vigr displays y/n question only *after* receiving answer

[loreb]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by loreb on void-packages repository

https://github.com/void-linux/void-packages/issues/33699#issuecomment-949862572

Comment:
Ok thank you

Re: vipw/vigr displays y/n question only *after* receiving answer

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/33699#issuecomment-950350484

Comment:
@loreb if you'd like to backport it already, it's a small change and basically harmless. And would help in keeping issue count low.

Re: vipw/vigr displays y/n question only *after* receiving answer

[loreb]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New comment by loreb on void-packages repository

https://github.com/void-linux/void-packages/issues/33699#issuecomment-950814347

Comment:
Sorry for the late reply; it turned out that there was another teeny tiny bug, so let's wait just a little bit longer (fixing the other one has the advantage that the patch will fail to apply once a new release is made, so we don't keep useless patches around)

Re: [ISSUE] [CLOSED] vipw/vigr displays y/n question only *after* receiving answer

[sgn]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

Closed issue by loreb on void-packages repository

https://github.com/void-linux/void-packages/issues/33699

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname:  
  Void 5.13.19_1 x86_64-musl GenuineIntel uptodate rFF
* package:  
  util-linux-2.37.2_1

### Expected behavior
The program prints "Would you like to edit (filename) now [y/n]? ", I see the question and reply

### Actual behavior
The program shows nothing, I type "y" and *then* it prints the question - there should be a `fflush(stdout)` between printf and fgets in login-utils/vipw.c:354, or to be even safer set stdout to unbuffered right on program startup.

### Steps to reproduce the behavior
as root, run vipw or vigr on a musl system using /etc/shadow, modify anything and see